Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Florinel Iordache <florinel.iordache@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        Leo Li <leoyang.li@nxp.com>,
        "Madalin Bucur (OSS)" <madalin.bucur@oss.nxp.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Florinel Iordache <florinel.iordache@nxp.com>
Subject: RE: Re: [PATCH net-next v2 6/9] net: phy: add backplane kr driver
 support
Thread-Topic: Re: [PATCH net-next v2 6/9] net: phy: add backplane kr driver
 support
Thread-Index: AdYaRAr6OuhHlsgtRe2hojICsYdYXA==
Date:   Fri, 24 Apr 2020 14:39:54 +0000
Message-ID: <AM0PR04MB5443BCFEC71B6903BE6EFE02FBD00@AM0PR04MB5443.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: af9b0be3-049c-4d2a-0b30-08d7e85d5a92
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2020 14:39:54.3738
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RhZPaZelauvgQO5zNRDKoid0fIgK9UwyRG5aZUshHDZudKMUikZK08nKi7ZpuJoX0N51JE9No/QrubWzHSZaY2O3AqKiHHfKVhdO13r23vw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6481
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +/* Backplane custom logging */
> > +#define bpdev_fn(fn)                                                 \
> > +void bpdev_##fn(struct phy_device *phydev, char *fmt, ...)           \
> > +{                                                                    \
> > +     struct va_format vaf =3D {                                       =
 \
> > +             .fmt =3D fmt,                                            =
 \
> > +     };                                                              \
> > +     va_list args;                                                   \
> > +     va_start(args, fmt);                                            \
> > +     vaf.va =3D &args;                                                =
 \
> > +     if (!phydev->attached_dev)                                      \
> > +             dev_##fn(&phydev->mdio.dev, "%pV", &vaf);               \
> > +     else                                                            \
> > +             dev_##fn(&phydev->mdio.dev, "%s: %pV",                  \
> > +                     netdev_name(phydev->attached_dev), &vaf);       \
> > +     va_end(args);                                                   \
> > +}
> > +
> > +bpdev_fn(err)
> > +EXPORT_SYMBOL(bpdev_err);
> > +
> > +bpdev_fn(warn)
> > +EXPORT_SYMBOL(bpdev_warn);
> > +
> > +bpdev_fn(info)
> > +EXPORT_SYMBOL(bpdev_info);
> > +
> > +bpdev_fn(dbg)
> > +EXPORT_SYMBOL(bpdev_dbg);
>=20
> Didn't i say something about just using phydev_{err|warn|info|dbg}?
>=20
>        Andrew

Hi Andrew,

I used this custom logging in order to be able to add any kind of useful in=
formation we might need to all prints (err/warn/info/dbg).
For example all these bpdev_ functions are equivalent with phydev_ but only=
 in the case when there is no attached device: phydev->attached_dev =3D=3D =
NULL.
Otherwise, if there is a device attached, then we also want to add its name=
 to all these prints in order to know to which device the information refer=
s to.
For example in this case the print looks like this:
[   50.853515] backplane_qoriq 8c13000:00: eth1: 10gbase-kr link trained, T=
x equalization: C(-1)=3D0x0, C(0)=3D0x29, C(+1)=3D0x5
This is very useful because we can see very easy to which interface the inf=
ormation printed is related to: in this case the link was trained for inter=
face: eth1
This information (the name of attached device: eth1) is not printed by phyd=
ev_ functions.
I'm sorry I have not explained all this earlier, the first time when you as=
ked about it.=20

Florin.