Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp724568ybz; Fri, 24 Apr 2020 08:14:47 -0700 (PDT) X-Google-Smtp-Source: APiQypLoLc9ZLBkZHWYgXa0oBFOQKSMQbPnd/GYQNvRBlffQZW30lgApWZkkPFfNNVVDxvLIasyi X-Received: by 2002:a17:906:7743:: with SMTP id o3mr7783233ejn.120.1587741287121; Fri, 24 Apr 2020 08:14:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587741287; cv=none; d=google.com; s=arc-20160816; b=0Txh38eZBltsC0ogt2Io36qxULLh8A+fk/KY3+FNPdZJp7/s4qM6jqkFzo8xN+AoNt 3TxaFHw5ub0Ik+12NLIEOKBcKWpjblQ+EGrnTE8Eb9v7dt9cIGsrj2COSS3FLo3Mw6I3 WvRRUwe+eQDL+OVezQtakCZUFRCA0faDhJL48A0rRISy1gcG5oBVzfcLGvnVkVclirhb CZW/F3bbxYLCYYeIHlFRChxLQonW/J2/vrD74XdAOkM4NHko5dG2d6GKKcqFgEuxOUm+ 4si3PbFs2pbJJ2WVAUJB9j3vJz9AMPpcTqYiwIilvYQRFszAR9Y5gGFJOvQIIlR+TCfS 0ytA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:subject:autocrypt:from:references:cc:to:dkim-signature; bh=t+ZQznSM11E/jyn67D8qSqzd/m+JcwYtUk8g0RmRwFc=; b=XTwmN7VRUg74amLwTpBXfGOS8QFvCMFu2oQ6DiH0U0XnOrQcYCAYlKCuN3Z8kknox0 wikjNaOOW0umbAMFI7uz0BLRiKlSQwLTH4PyB4axSRcZ99rINIvyrxwclAfMHMIeqB2g Rnx4Cb/Lgm/Ovmjln2JFMMaCJUZ8ljKFG9w7Jd8NcXv5kiy0KzP5WRmeS8WytYIC9Fvn vsdhplzJzwEDzc4pMxyKho5D49oX6Sld2w0bl3s96zeskYtXp8ejh+KkA3+ilgr/895S jrX9B4kxn/YDfHgNuxN0Jbxy1PlW2/X+VSVb4pRYzIwZStIjharUzge2XgPbWrrKWLHR Ylhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@embeddedor.com header.s=default header.b="an/cUMdD"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ly26si778453ejb.190.2020.04.24.08.14.23; Fri, 24 Apr 2020 08:14:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@embeddedor.com header.s=default header.b="an/cUMdD"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728196AbgDXPMC (ORCPT + 99 others); Fri, 24 Apr 2020 11:12:02 -0400 Received: from gateway23.websitewelcome.com ([192.185.49.104]:37238 "EHLO gateway23.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727781AbgDXPMB (ORCPT ); Fri, 24 Apr 2020 11:12:01 -0400 X-Greylist: delayed 1381 seconds by postgrey-1.27 at vger.kernel.org; Fri, 24 Apr 2020 11:12:00 EDT Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 1A56849CD for ; Fri, 24 Apr 2020 09:48:58 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id RzdSjSPVyVQh0RzdSjasUC; Fri, 24 Apr 2020 09:48:58 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:Subject:From:References:Cc:To:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=t+ZQznSM11E/jyn67D8qSqzd/m+JcwYtUk8g0RmRwFc=; b=an/cUMdD8kdPcYHJ5nbciVlnJ/ 2kBl3GF3E+dswd+dJrflHzrrZ9O4Zf3K/jG/B/ehH4na3zV7OBQKUfsredn7w6XHT54CuZCDfgfqv jLydprrsb9QAn3yFaC1tf18LSyLdfmR3EBmWrZ9hN5hOvUMcElfHsJ29/B/6WUQFrGPOQzeDHA0oN mPhIuWWZLAtML7kwIh9rD0AF8Iz8U4FReVzjxc3TDPzt5F0ElxTon6+4jWuWn135F537KI7jHcRz+ etjQ8wPAhPfcO7/bCMQA6P8lXKmDXAo6lJphdygzv19uDYryJN3rWBz1rkJTHQaeBMxD11+1HjhbO W5N+7jPA==; Received: from [201.166.178.27] (port=57286 helo=[192.168.43.132]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1jRzdR-000M0V-PM; Fri, 24 Apr 2020 09:48:57 -0500 To: Linus Torvalds Cc: Kees Cook , Greg KH , Linux Kernel Mailing List References: <6342c465-e34b-3e18-cc31-1d989926aebd@embeddedor.com> From: "Gustavo A. R. Silva" Autocrypt: addr=gustavo@embeddedor.com; keydata= xsFNBFssHAwBEADIy3ZoPq3z5UpsUknd2v+IQud4TMJnJLTeXgTf4biSDSrXn73JQgsISBwG 2Pm4wnOyEgYUyJd5tRWcIbsURAgei918mck3tugT7AQiTUN3/5aAzqe/4ApDUC+uWNkpNnSV tjOx1hBpla0ifywy4bvFobwSh5/I3qohxDx+c1obd8Bp/B/iaOtnq0inli/8rlvKO9hp6Z4e DXL3PlD0QsLSc27AkwzLEc/D3ZaqBq7ItvT9Pyg0z3Q+2dtLF00f9+663HVC2EUgP25J3xDd 496SIeYDTkEgbJ7WYR0HYm9uirSET3lDqOVh1xPqoy+U9zTtuA9NQHVGk+hPcoazSqEtLGBk YE2mm2wzX5q2uoyptseSNceJ+HE9L+z1KlWW63HhddgtRGhbP8pj42bKaUSrrfDUsicfeJf6 m1iJRu0SXYVlMruGUB1PvZQ3O7TsVfAGCv85pFipdgk8KQnlRFkYhUjLft0u7CL1rDGZWDDr NaNj54q2CX9zuSxBn9XDXvGKyzKEZ4NY1Jfw+TAMPCp4buawuOsjONi2X0DfivFY+ZsjAIcx qQMglPtKk/wBs7q2lvJ+pHpgvLhLZyGqzAvKM1sVtRJ5j+ARKA0w4pYs5a5ufqcfT7dN6TBk LXZeD9xlVic93Ju08JSUx2ozlcfxq+BVNyA+dtv7elXUZ2DrYwARAQABzSxHdXN0YXZvIEEu IFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPsLBfQQTAQgAJwUCWywcDAIbIwUJ CWYBgAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRBHBbTLRwbbMZ6tEACk0hmmZ2FWL1Xi l/bPqDGFhzzexrdkXSfTTZjBV3a+4hIOe+jl6Rci/CvRicNW4H9yJHKBrqwwWm9fvKqOBAg9 obq753jydVmLwlXO7xjcfyfcMWyx9QdYLERTeQfDAfRqxir3xMeOiZwgQ6dzX3JjOXs6jHBP cgry90aWbaMpQRRhaAKeAS14EEe9TSIly5JepaHoVdASuxklvOC0VB0OwNblVSR2S5i5hSsh ewbOJtwSlonsYEj4EW1noQNSxnN/vKuvUNegMe+LTtnbbocFQ7dGMsT3kbYNIyIsp42B5eCu JXnyKLih7rSGBtPgJ540CjoPBkw2mCfhj2p5fElRJn1tcX2McsjzLFY5jK9RYFDavez5w3lx JFgFkla6sQHcrxH62gTkb9sUtNfXKucAfjjCMJ0iuQIHRbMYCa9v2YEymc0k0RvYr43GkA3N PJYd/vf9vU7VtZXaY4a/dz1d9dwIpyQARFQpSyvt++R74S78eY/+lX8wEznQdmRQ27kq7BJS R20KI/8knhUNUJR3epJu2YFT/JwHbRYC4BoIqWl+uNvDf+lUlI/D1wP+lCBSGr2LTkQRoU8U 64iK28BmjJh2K3WHmInC1hbUucWT7Swz/+6+FCuHzap/cjuzRN04Z3Fdj084oeUNpP6+b9yW e5YnLxF8ctRAp7K4yVlvA87BTQRbLBwMARAAsHCE31Ffrm6uig1BQplxMV8WnRBiZqbbsVJB H1AAh8tq2ULl7udfQo1bsPLGGQboJSVN9rckQQNahvHAIK8ZGfU4Qj8+CER+fYPp/MDZj+t0 DbnWSOrG7z9HIZo6PR9z4JZza3Hn/35jFggaqBtuydHwwBANZ7A6DVY+W0COEU4of7CAahQo 5NwYiwS0lGisLTqks5R0Vh+QpvDVfuaF6I8LUgQR/cSgLkR//V1uCEQYzhsoiJ3zc1HSRyOP otJTApqGBq80X0aCVj1LOiOF4rrdvQnj6iIlXQssdb+WhSYHeuJj1wD0ZlC7ds5zovXh+FfF l5qH5RFY/qVn3mNIVxeO987WSF0jh+T5ZlvUNdhedGndRmwFTxq2Li6GNMaolgnpO/CPcFpD jKxY/HBUSmaE9rNdAa1fCd4RsKLlhXda+IWpJZMHlmIKY8dlUybP+2qDzP2lY7kdFgPZRU+e zS/pzC/YTzAvCWM3tDgwoSl17vnZCr8wn2/1rKkcLvTDgiJLPCevqpTb6KFtZosQ02EGMuHQ I6Zk91jbx96nrdsSdBLGH3hbvLvjZm3C+fNlVb9uvWbdznObqcJxSH3SGOZ7kCHuVmXUcqoz ol6ioMHMb+InrHPP16aVDTBTPEGwgxXI38f7SUEn+NpbizWdLNz2hc907DvoPm6HEGCanpcA EQEAAcLBZQQYAQgADwUCWywcDAIbDAUJCWYBgAAKCRBHBbTLRwbbMdsZEACUjmsJx2CAY+QS UMebQRFjKavwXB/xE7fTt2ahuhHT8qQ/lWuRQedg4baInw9nhoPE+VenOzhGeGlsJ0Ys52sd XvUjUocKgUQq6ekOHbcw919nO5L9J2ejMf/VC/quN3r3xijgRtmuuwZjmmi8ct24TpGeoBK4 WrZGh/1hAYw4ieARvKvgjXRstcEqM5thUNkOOIheud/VpY+48QcccPKbngy//zNJWKbRbeVn imua0OpqRXhCrEVm/xomeOvl1WK1BVO7z8DjSdEBGzbV76sPDJb/fw+y+VWrkEiddD/9CSfg fBNOb1p1jVnT2mFgGneIWbU0zdDGhleI9UoQTr0e0b/7TU+Jo6TqwosP9nbk5hXw6uR5k5PF 8ieyHVq3qatJ9K1jPkBr8YWtI5uNwJJjTKIA1jHlj8McROroxMdI6qZ/wZ1ImuylpJuJwCDC ORYf5kW61fcrHEDlIvGc371OOvw6ejF8ksX5+L2zwh43l/pKkSVGFpxtMV6d6J3eqwTafL86 YJWH93PN+ZUh6i6Rd2U/i8jH5WvzR57UeWxE4P8bQc0hNGrUsHQH6bpHV2lbuhDdqo+cM9eh GZEO3+gCDFmKrjspZjkJbB5Gadzvts5fcWGOXEvuT8uQSvl+vEL0g6vczsyPBtqoBLa9SNrS VtSixD1uOgytAP7RWS474w== Subject: Re: remaining flexible-array conversions Message-ID: <5e64a055-a388-cac7-ad0d-7b50619b3e3f@embeddedor.com> Date: Fri, 24 Apr 2020 09:53:05 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 201.166.178.27 X-Source-L: No X-Exim-ID: 1jRzdR-000M0V-PM X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.43.132]) [201.166.178.27]:57286 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/23/20 14:15, Linus Torvalds wrote: > On Wed, Apr 22, 2020 at 11:23 AM Gustavo A. R. Silva > wrote: >> >> Just wanted to ask you if you would agree on pulling the remaining >> flexible-array conversions all at once, after they bake for a couple >> of weeks in linux-next[1] >> >> This is not a disruptive change and there are no code generation >> differences. > > The "no code generation differnces" is a good thing, but how was that > tested? I assume just one configuration or architecture? > That's correct. I used pahole to test it (x86_64, allyesconfig). I will test other archs (arm, arm64, powerpc, mips, etc...). > Also, it bothers me a bit that some of the diff is unrelated > whitespace cleanup. I'd actually be happier with a pure scripted patch > (maybe coccinelle, maybe something else), than something that looks > like it's at least partly manual. In particular, if I can re-create > the diff with a script, I'd not have to worry about verifying it other > ways.. > Yeah. I fixed up some "tabs and spaces" checkpatch warnings --I can omit this step in the future. I also had to drop changes from files that were causing warnings --with the idea of fixing those warnings later, after landing all the "non-problematic" conversions, first. I will generate an ad-hoc bash script for this and will send it to you. Thanks -- Gustavo