Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 24 Apr 2020 17:39:40 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Salman Qazi <sqazi@google.com>
Cc:     Jens Axboe <axboe@kernel.dk>, Ming Lei <ming.lei@redhat.com>,
        Bart Van Assche <bvanassche@acm.org>,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jesse Barnes <jsbarnes@google.com>,
        Gwendal Grignou <gwendal@google.com>,
        Hannes Reinecke <hare@suse.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3] block: Limit number of items taken from the I/O
 scheduler in one go
Message-ID: <20200424153940.GA17253@lst.de>
References: <20200424150321.38617-1-sqazi@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200424150321.38617-1-sqazi@google.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> +	/*
> +	 * A return of -EAGAIN is an indication that hctx->dispatch is not
> +	 * empty and we must run again in order to avoid starving flushes.
> +	 */
> +	if (__blk_mq_sched_dispatch_requests(hctx) == -EAGAIN) {
> +		if (__blk_mq_sched_dispatch_requests(hctx) == -EAGAIN)
> +			blk_mq_run_hw_queue(hctx, true);
> +	}

The comment doesn't explain why we give up after the second attempt and
do a blk_mq_run_hw_queue instead.