Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Bean Huo (beanhuo)" <beanhuo@micron.com>
To:     Jose Abreu <Jose.Abreu@synopsys.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
CC:     Joao Pinto <Joao.Pinto@synopsys.com>,
        Joao Lima <Joao.Lima@synopsys.com>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Avri Altman <avri.altman@wdc.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH v2 1/5] scsi: ufs: Allow UFS 3.0 as a valid version
Thread-Topic: [EXT] [PATCH v2 1/5] scsi: ufs: Allow UFS 3.0 as a valid version
Thread-Index: AQHWGj6R0nTpmn6fGEWz3ZvyHz0xNaiIaq7A
Date:   Fri, 24 Apr 2020 15:57:07 +0000
Message-ID: <SN6PR08MB5693C397D88D16EC43E85490DBD00@SN6PR08MB5693.namprd08.prod.outlook.com>
References: <cover.1587735561.git.Jose.Abreu@synopsys.com>
 <c006813f8fc3052eef97d5216e4f31829d7cd10b.1587735561.git.Jose.Abreu@synopsys.com>
In-Reply-To: <c006813f8fc3052eef97d5216e4f31829d7cd10b.1587735561.git.Jose.Abreu@synopsys.com>
Accept-Language: en-150, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: micron.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f760825-f4ad-4215-e82c-08d7e868245d
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2020 15:57:07.8712
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f38a5ecd-2813-4862-b11b-ac1d563c806f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: B9cGRMcmQSVx+XHnZ1VH1Od1ut0od6D//5adIvBi3eXHnKlHiYBmBYS4SPJRWMbBy1pSnY+fNCi77vnSHGgerw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR08MB5072
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Jose

> @@ -8441,7 +8441,8 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem
> *mmio_base, unsigned int irq)
>  	if ((hba->ufs_version !=3D UFSHCI_VERSION_10) &&
>  	    (hba->ufs_version !=3D UFSHCI_VERSION_11) &&
>  	    (hba->ufs_version !=3D UFSHCI_VERSION_20) &&
> -	    (hba->ufs_version !=3D UFSHCI_VERSION_21))
> +	    (hba->ufs_version !=3D UFSHCI_VERSION_21) &&
> +	    (hba->ufs_version !=3D UFSHCI_VERSION_30))

I don't think these checkups of UFSHCI version is necessary,  does the UFSH=
CI have other version number except these?
Is there somebody still v1.0 and v1.1?


> @@ -104,6 +104,7 @@ enum {
>  	UFSHCI_VERSION_11 =3D 0x00010100, /* 1.1 */
>  	UFSHCI_VERSION_20 =3D 0x00000200, /* 2.0 */
>  	UFSHCI_VERSION_21 =3D 0x00000210, /* 2.1 */
> +	UFSHCI_VERSION_30 =3D 0x00000300, /* 3.0 */
>  };
>=20
>  /*
> --
> 2.7.4

//Bean