Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200424130847.328584-1-jiaxun.yang@flygoat.com> <20200424130847.328584-6-jiaxun.yang@flygoat.com>
In-Reply-To: <20200424130847.328584-6-jiaxun.yang@flygoat.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Fri, 24 Apr 2020 14:10:36 -0500
Message-ID: <CAL_Jsq+33XrBowgg+pSAFLu-KChYzuFKL6DJRrOPuq60nSFN4g@mail.gmail.com>
Subject: Re: [PATCH v5 5/6] MIPS: DTS: Loongson64: Add PCI Controller Node
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc:     PCI <linux-pci@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Huacai Chen <chenhc@lemote.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Andrew Murray <amurray@thegoodpenguin.co.uk>,
        Paul Burton <paulburton@kernel.org>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "open list:MIPS" <linux-mips@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Apr 24, 2020 at 8:10 AM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
>
> Add PCI Host controller node for Loongson64 with RS780E PCH dts.
> Note that PCI interrupts are probed via legacy way, as different
> machine have different interrupt arrangement, we can't cover all
> of them in dt.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> --
> v2: Clean-up
> ---
>  arch/mips/boot/dts/loongson/rs780e-pch.dtsi | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/loongson/rs780e-pch.dtsi b/arch/mips/boot/dts/loongson/rs780e-pch.dtsi
> index 8687c4f7370a..5e68ceae20ca 100644
> --- a/arch/mips/boot/dts/loongson/rs780e-pch.dtsi
> +++ b/arch/mips/boot/dts/loongson/rs780e-pch.dtsi
> @@ -5,10 +5,25 @@ bus@10000000 {
>                 compatible = "simple-bus";
>                 #address-cells = <2>;
>                 #size-cells = <2>;
> -               ranges = <0 0x10000000 0 0x10000000 0 0x10000000
> +               ranges = <0 0x00000000 0 0x00000000 0 0x00010000 /* I/O Ports */

You're changing the first entry, so bus@10000000 unit-address should change.

Are i/o addresses really at 0x0 physical address?

> +                               0 0x10000000 0 0x10000000 0 0x10000000
>                                 0 0x40000000 0 0x40000000 0 0x40000000
>                                 0xfd 0xfe000000 0xfd 0xfe000000  0 0x2000000 /* PCI Config Space */>;
>
> +               pci@1a000000 {
> +                       compatible = "loongson,rs780e-pci";
> +                       device_type = "pci";
> +                       #address-cells = <3>;
> +                       #size-cells = <2>;
> +
> +                       reg = <0 0x1a000000 0 0x02000000>;
> +
> +                       ranges = <0x01000000 0 0x00004000 0 0x00004000 0 0x00004000>,
> +                                <0x02000000 0 0x40000000 0 0x40000000 0 0x40000000>;
> +
> +                       bus-range = <0x00 0xff>;

Not needed.

> +               };
> +
>                 isa {
>                         compatible = "isa";
>                         #address-cells = <2>;
> --
> 2.26.0.rc2
>