Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200328185916.98423-1-rajatja@google.com> <20200328185916.98423-3-rajatja@google.com>
 <20200410164140.GA25924@bogus>
In-Reply-To: <20200410164140.GA25924@bogus>
From:   Rajat Jain <rajatja@google.com>
Date:   Fri, 24 Apr 2020 12:41:09 -0700
Message-ID: <CACK8Z6G=oy9Gesazk1jJVhk22Dgm8_TGZCcpNndkv+WLqAe8hg@mail.gmail.com>
Subject: Re: [PATCH v4 3/5] dt-bindings: input/atkbd.txt: Add binding for "function-row-physmap"
To:     Rob Herring <robh@kernel.org>
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Dmitry Torokhov <dtor@google.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        Enrico Weigelt <info@metux.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Allison Randal <allison@lohutok.net>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Stephen Boyd <swboyd@chromium.org>,
        linux-input <linux-input@vger.kernel.org>,
        devicetree@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Furquan Shaikh <furquan@google.com>,
        Duncan Laurie <dlaurie@google.com>,
        Benson Leung <bleung@google.com>,
        Zentaro Kavanagh <zentaro@google.com>,
        Dominik Behr <dbehr@google.com>,
        Rajat Jain <rajatxjain@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Fri, Apr 10, 2020 at 10:38 AM Rob Herring <robh@kernel.org> wrote:
>
> On Sat, Mar 28, 2020 at 11:59:14AM -0700, Rajat Jain wrote:
> > Create the documentation for the new introduced property, that
> > describes the function-row keys physical positions.
> >
> > Signed-off-by: Rajat Jain <rajatja@google.com>
> > ---
> > v4: Same as v3
> > v3: same as v2
> > v2: Remove the Change-Id from the commit log
> >
> >  .../devicetree/bindings/input/atkbd.txt       | 34 +++++++++++++++++++
> >  1 file changed, 34 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/input/atkbd.txt
> >
> > diff --git a/Documentation/devicetree/bindings/input/atkbd.txt b/Documentation/devicetree/bindings/input/atkbd.txt
> > new file mode 100644
> > index 0000000000000..816653eb8e98d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/input/atkbd.txt
> > @@ -0,0 +1,34 @@
> > +Device tree bindings for AT / PS2 keyboard device
> > +
> > +Optional properties:
> > +
> > +     function-row-physmap:
> > +                     An ordered array of the physical codes for the function
> > +                     row keys. Arranged in order from left to right.
>
> A single optional property doesn't constitute a DT binding.
>
> > +
> > +Example:
> > +
> > +     This is a sample ACPI _DSD node describing the property:
>
> Neither does this ACPI stuff.

I assume this means a nack to the documentation patches.

Dmitry, can you apply the other patches in the series?

Thanks,

Rajat

>
> Rob