Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <156f8353-5841-39ad-3bc2-af9cadac3c71@kernel.dk>
In-Reply-To: <156f8353-5841-39ad-3bc2-af9cadac3c71@kernel.dk>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Fri, 24 Apr 2020 13:03:23 -0700
Message-ID: <CAHk-=wibcCGvPy=PjevdSzEtzrYPWJnLo+t=S3zy3AQ5+NNeEg@mail.gmail.com>
Subject: Re: [GIT PULL] io_uring fix for 5.7-rc3
To:     Jens Axboe <axboe@kernel.dk>
Cc:     io-uring <io-uring@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Apr 24, 2020 at 11:03 AM Jens Axboe <axboe@kernel.dk> wrote:
>
> Single fixup for a change that went into -rc2, please pull.

I'd like to point out that this was exactly the code that I pointed to
as being badly written and hard to understand:

 "That whole apoll thing is disgusting.

  I cannot convince myself it is right. How do you convince yourself?"

And you at that time claimed it was all fairly simple and clear.

I repeat: that whole apoll thing is disgusting. It wasn't simple and
clear and only a few obvious cases that had issues.

In fact, now it's even less clear, with an even more complicated check
for when to restore things,

I think that whole approach needs re-thinking. Is the union really worth it?

Can you guarantee and explain why _this_ time it is right?

                Linus