Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp222032ybz; Fri, 24 Apr 2020 14:52:30 -0700 (PDT) X-Google-Smtp-Source: APiQypKlmEvHUB/qFKyWUV0vA5pKHjZVYn13VbIY/b3HQ+Y3CzEwuS5XQzxL3npaw/QbvKb9Zi/b X-Received: by 2002:a17:906:edb5:: with SMTP id sa21mr9335950ejb.270.1587765150626; Fri, 24 Apr 2020 14:52:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587765150; cv=none; d=google.com; s=arc-20160816; b=y4dAiSQdnjlWenvpRGcXI+FOMP6QBqHrTSaTqNFzc2kdscHCx/ciJa3XyeBzJ7BUGU 4WIbZUI0JXYDzNESueYODlWw2GrZEXbHwxE94jmfEahhaRrAmJX1AbI5TEEP9r5xtiev vdglBAbr/pUQh27368Vmv4+DMegV00ApgqJhHE9IfqVcCkcAW+7GKdNAg0yUG1uPZ/Nj sWZkJcPDzQWXROBMMR6xmglHLQW1yaIJQEbQiUu/8fsaicF4AueGlvoQ5eCxrTSRJOpZ iNMfJnPr1sknGAwUd+reOV4BGOaOeN0UuQUq9AUMnyeGkt0Vo6eMd8RShkgANDaoA8JE O8ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=43oNIeAM2vviurTuYaXvvZkrfgMWcle93HjBNJ1xvM4=; b=WdoiggHRUgBK9ElzxK+rrQDEXBr+bvhV8pbQrbYs4mx3MRqFaisUcFQhkK5N8TY1dM iEpajbAOi4N1yqdhagKvKtRyaMnCtldlKk4KmjJUBH9hqdPL261h11DMAH9Cs5XF+bMt nffc5m2zST/pdg9u9lmZCXfOTcCCu+CeLAPYLjLPFNaQftdt4cmbnoHrgGC39L1B4Hm6 94zsBlnqWngdgxQWpQOTV6NnQjXOBGgY1Mrf8coDJADS6GvLdRVpUVy5H7t7A/811h3+ qhHlJ6d0EMzzMro0JRBontzcC9vjooJ8SmZJctVAONzPOZrNsJGb0z7gM/JnVdYX8YBV 5i4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y7si4009469ede.225.2020.04.24.14.52.07; Fri, 24 Apr 2020 14:52:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726076AbgDXVun (ORCPT + 99 others); Fri, 24 Apr 2020 17:50:43 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:41534 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbgDXVun (ORCPT ); Fri, 24 Apr 2020 17:50:43 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 502391C0237; Fri, 24 Apr 2020 23:50:41 +0200 (CEST) Date: Fri, 24 Apr 2020 23:50:40 +0200 From: Pavel Machek To: Johan Hovold Cc: Tony Lindgren , Greg Kroah-Hartman , Rob Herring , Alan Cox , Lee Jones , Jiri Slaby , Merlijn Wajer , Peter Hurley , Sebastian Reichel , linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCHv6 0/4] n_gsm serdev support and protocol driver for droid4 modem Message-ID: <20200424215040.GA14087@amd> References: <20200421232752.3070-1-tony@atomide.com> <20200423114326.GQ18608@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PNTmBPCT7hxwcZjr" Content-Disposition: inline In-Reply-To: <20200423114326.GQ18608@localhost> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PNTmBPCT7hxwcZjr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > Here's v4 set of n_gsm serdev support patches, and the related protocol > > driver for the modem found on Motorola Mapphone phones and tablets > > like droid4. > >=20 > > This series only adds basic character device support for the serdev > > driver. Other serdev consumer drivers for specific devices will be > > posted separately. >=20 > I'm still missing an architectural (design) overview here -- reviewer > time is a scarce resource. >=20 > I also suggested earlier that you include, at least as an RFC, one or > more of your child-device drivers so that we can see how this ends up > being used in the end (including an example devicetree). Note that this is useful on its own: we have ofonod running on the top of this doing calls and SMSes. Tony: I know you have drivers depending on this somewhere (audio routing and GPS), but I can't find them. It is not droid4-pending-v5.6 AFAICT. Do you have a pointer / could you publish them somewhere? Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --PNTmBPCT7hxwcZjr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl6jXzAACgkQMOfwapXb+vL1MgCgkfDgPdNCuH+IVEioBezNZBZW CdIAnR1+l1rBSV1qT6U8BWmkXXdKbSoT =NUS7 -----END PGP SIGNATURE----- --PNTmBPCT7hxwcZjr--