Date: Sun, 5 Mar 2006 22:36:23 -0800
From: Andrew Morton <akpm@osdl.org>
To: Latchesar Ionkov <lucho@ionkov.net>
Cc: linux-kernel@vger.kernel.org, v9fs-developer@lists.sourceforge.net
Subject: Re: [PATCH] v9fs: print 9p messages
Message-Id: <20060305223623.1deb25a4.akpm@osdl.org>
In-Reply-To: <20060304152513.GA24046@ionkov.net>
References: <20060304152513.GA24046@ionkov.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1003
Lines: 36

Latchesar Ionkov <lucho@ionkov.net> wrote:
>
> Print 9p messages.
> 
> ...
>
> +#define DEBUG_FCALL		(1<<8)
>  
> ..
>
> +	if ((v9fs_debug_level&DEBUG_FCALL) == DEBUG_FCALL) {

There's no point in the rhs of this comparison.  Given that DEBUG_FCALL is
a single bit and that won't be changing, one may as well do

	if (v9fs_debug_level & DEBUG_FCALL) {

Also, those macro names:

#define DEBUG_ERROR		(1<<0)
#define DEBUG_CURRENT		(1<<1)
#define DEBUG_9P	        (1<<2)
#define DEBUG_VFS	        (1<<3)
#define DEBUG_CONV		(1<<4)
#define DEBUG_MUX		(1<<5)
#define DEBUG_TRANS		(1<<6)
#define DEBUG_SLABS	      	(1<<7)
#define DEBUG_FCALL		(1<<8)

are quite poorly chosen.  If someone else were to make a similarly poor
naming choice there would be collisions.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/