Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp298722ybz; Fri, 24 Apr 2020 16:26:11 -0700 (PDT) X-Google-Smtp-Source: APiQypIbCbs+A8S0Xaa0H5JAr7JplDUPIPEYD2zhjsGrPR9Dw6+4AaUyj0PdZOaoq89XPkSDqdmp X-Received: by 2002:a05:6402:14ce:: with SMTP id f14mr2976635edx.244.1587770771786; Fri, 24 Apr 2020 16:26:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587770771; cv=none; d=google.com; s=arc-20160816; b=MaSdDUs6lyLLoDS3UhTq5B01t3IpGCOFbcfk2L5FGlJg14ESI0IR3/cL3RGwwPXi8l DxxaeCEW93mFFlFrNQ83gd2lWLj11W1qVQCIBDLDxE2rnghU892+7UVFip6PKeFRf65P FPMEgzPxlXY3s6yrZ9uPASHIbFNPAFNuQh+wUw2XGPGEuAjWuxIhENLFKm9+DOAskXxT aKUWeTKXMmty1OdQorO3XKepi8R0zb+oTz9PSortgEUX0bquapnlPVzrJmv9aHsgPYl5 uuSuB2W7D2fo+f1i/KTEtF8wEExQR3vUWyfRAVHoZxuWbPNcs1lz8ci5f55CkkLU3xal jpuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=RjkafEpEUlQYwXmiRYMLYyVW1y9J3/I8SnW+sAOLIww=; b=bzl6oEzIq9bG2repJIO9j9SZGsQncjxiJghwHgHl4ogCVVvQTjX0/Tf9HcmDwKSoJq DnaWWMMuatqXEFXNDpAxM+yzqPN6+u4Uz0hk5n9INOp3Iv2nqMGRmfs2BbslwLiau0WN rgmJQGGZpjX7TrTbHkop4GS7DA7Mi2SMfCn+olf4lbq9vXSt6cTGEw8o0/NSWWc0qcj+ 0VZ5duo/JLlPp5ir1OqAorxbVgvwpNleayNdlcFONUbqHUa9ugxzvUlwHmCawLbwtsj2 1Qu1T10GxtJeOSOeQaf7gDL+OitmBjPj7CXiFltFsmqirc/QVaHxtl6LhBAVazKE7oVn qMYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="HV8jmH/S"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ca20si3955355edb.181.2020.04.24.16.25.47; Fri, 24 Apr 2020 16:26:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="HV8jmH/S"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726107AbgDXXX2 (ORCPT + 99 others); Fri, 24 Apr 2020 19:23:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:39310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725932AbgDXXX1 (ORCPT ); Fri, 24 Apr 2020 19:23:27 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 31F0A214AF; Fri, 24 Apr 2020 23:23:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587770607; bh=RjkafEpEUlQYwXmiRYMLYyVW1y9J3/I8SnW+sAOLIww=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HV8jmH/SAcHEHgDgQ60/GA2j/puMEj3tRbY/nBniFWjKcxufSx8NbpB7kOUd8Q80A i9w7c0QTzGN5M7+vTOFOfz+uEvLkPc0zCFXC/lRaw8+/zpC7/3+C2g7++l5tAecg7A owDeZ7Z1dveUZF4X/UAmHjUdDpDmxuqy30YW7WvY= Date: Fri, 24 Apr 2020 16:23:25 -0700 From: Jakub Kicinski To: Huazhong Tan Cc: , , , , , Subject: Re: [PATCH net-next 0/8] net: hns3: refactor for MAC table Message-ID: <20200424162325.4547ce9c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1587694993-25183-1-git-send-email-tanhuazhong@huawei.com> References: <1587694993-25183-1-git-send-email-tanhuazhong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Apr 2020 10:23:05 +0800 Huazhong Tan wrote: > This patchset refactors the MAC table management, configure > the MAC address asynchronously, instead of synchronously. > Base on this change, it also refines the handle of promisc > mode and filter table entries restoring after reset. Looks like in patch 2 you could also remove the check if allocated_size is NULL if there is only once caller ;) But that's a nit, series seems okay: Acked-by: Jakub Kicinski