Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp553377ybz; Fri, 24 Apr 2020 22:52:56 -0700 (PDT) X-Google-Smtp-Source: APiQypJtVasbdnMlLnpGunOK3e4frtGIauKzPQ7lgHozHCgxaxpq3YOteMOl6HQCmBb8m2lkr36G X-Received: by 2002:a17:906:a441:: with SMTP id cb1mr10854013ejb.242.1587793976521; Fri, 24 Apr 2020 22:52:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587793976; cv=none; d=google.com; s=arc-20160816; b=K3jxHNQLudv4MPplLL9GhQrwW9g/xIswWXym+5ais1Nzf6c1NmoZHzkggylCrtLXhm wArowoG/1tUAbzZIzTVmiJH/o7+aRfBHwohwlJnOTrrrh4WgWkAFb8QCrEl/wMupHxCC m4sSzPXUOXS2dXJX5BDG6q2GpVjuSP1/PvFA6QL82onhlE5FHErceQxjQ0KVe93a3h3T UgNcXo/oCeYJJHSxc65uSjplQGP8786Zyu4m9t1h4ediox1JSwCyHe1ZElcrgxakPjHE 5GmCwI2vu92E0yxovz/Auql5rsmg+ZnP+3ydmLrMJLpTv9akhVBk2/6bOk1+62PRlE+c aTug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:date:subject:cc:to:from:dkim-signature; bh=zsUhVDiIyys3/DM7IV+eemDr2Iu9PifSAtNGIwB9uHA=; b=eb4uYV9ZdbTSHhehneJzVyJtJJMjHFwy+s5r4Q4aFaSyU/hTeShhW6wFoyHYqMqI3Q mhi/+Qxx5foAUo7IZQcdtoALqdcjmawL3BTK2xweH3tipzPJnSNhbXXn+MamyOwiAsnG mZ4+mkwUeKBQQ2GPXBzzJRuGhak7r2/t2NjNMwxjL5OnKhp8Tsv+ELXWsBloF/RL59IR hcgNg1NM58foDbehREBC71q2f8N4SnxhdPY9peOuaJYcFTYXMHIwaJhX+kAIKtQerfW4 CQN3qGV7PMUcI3SADxc0G6F5E5Bu79b1oXj8xKofoCsWt2qHyqOfKr1UN5LUl+Guizwx XiLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=18e56uqe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lu44si4571822ejb.394.2020.04.24.22.52.04; Fri, 24 Apr 2020 22:52:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=18e56uqe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726118AbgDYFtE (ORCPT + 99 others); Sat, 25 Apr 2020 01:49:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:46022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725837AbgDYFtE (ORCPT ); Sat, 25 Apr 2020 01:49:04 -0400 Received: from localhost.localdomain (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF2C720724; Sat, 25 Apr 2020 05:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587793744; bh=4NqYWINnuunoPX9IvhIS+iUNF07BaWx/NUJI+gPGKo8=; h=From:To:Cc:Subject:Date:From; b=18e56uqerNIa5cd05qoAqdyf50xBj1VyTF05WOx408I+54UotE/qO9JkXPztbA7Kf n1k4u079z/SAGEVZmIjMVq/xcYfSBNjSFSnwCfbHw70VciTjWdLu/OGWMKtUfMR0jl iY4wTNGVfdtwd9XmAlitjXi3V8io/E4PxT869ppw= From: Masami Hiramatsu To: Steven Rostedt Cc: Masami Hiramatsu , Tom Zanussi , linux-kernel@vger.kernel.org, Ingo Molnar Subject: [PATCH 0/3] tracing/kprobes: Fix event generation API etc. Date: Sat, 25 Apr 2020 14:48:59 +0900 Message-Id: <158779373972.6082.16695832932765258919.stgit@devnote2> X-Mailer: git-send-email 2.20.1 User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Here are bugfix/cleanup patches for the kprobe tracer, [1/3] is a typo fix, [2/3] is fixing boot-time tracer and [3/3] is error checking for the new in-kernel kprobe event API. Tom, I found that your commit 29a154810546 ("tracing: Change trace_boot to use kprobe_event interface") broke the boot-time tracer's kprobe event because of wrong API usage. Could you review it? I marked [3/3] as a bugfix, because if the loc == NULL, __kprobe_event_gen_cmd_start() obviously does not work. But it reports actual error at kprobe_event_gen_cmd_end(). That is not good for developers to debug it. Thank you, --- Masami Hiramatsu (3): tracing/kprobes: Fix a double initialization typo tracing/boottime: Fix kprobe event API usage tracing/kprobes: Reject new event if loc is NULL kernel/trace/trace_boot.c | 20 ++++++++------------ kernel/trace/trace_kprobe.c | 8 +++++++- 2 files changed, 15 insertions(+), 13 deletions(-) -- Masami Hiramatsu (Linaro)