Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp600234ybz; Sat, 25 Apr 2020 00:05:03 -0700 (PDT) X-Google-Smtp-Source: APiQypIZtk/CjQuoHuT1KGsona3ZyOh4rvLL8k+QsZDtm6FrJxnmmeS1ECWRlDw5k5kM/pze4VFR X-Received: by 2002:a17:906:3004:: with SMTP id 4mr10766139ejz.381.1587798303386; Sat, 25 Apr 2020 00:05:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587798303; cv=none; d=google.com; s=arc-20160816; b=R/Hu17LdAIi+xitYQeEAka2bdPIUdVm+zGY6KW7ipLnUe8S6aU9zIrccBr9wEFmEBA 67/bXK9IBQxIyCvR0dD+w5nsa7W7i8uTk+ert9hQIZ/zYqSSdoDKlxAiI19zSQBwbKrB x8sf6k0LmeXTupiB7E0LaiTMSDGwuhKRI/QXUR5v980D5yu4MxZGToGW4q6rNBPwsrXj ywBFeGzmWuAaxvOwA57v4Z4tB8UzQOYU+UiOnLpIgnazgDmNB3HS6dMLmqP/9Kcwmyfc iwl8VKXlI6vDsSV8HMJoF2TIuovhuds5S/rGkgeJZv0fXddkCcvgZI0FosJfGgdVOnre t55Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=HZm6DwXTwnx3KiIUACMsSmVOaGpBtskQUoUJSCSU4Rk=; b=ELSM8eH+z4JHS7UZ8BJmylORIdu33P3TzPxd6ELDIOsFNPFzS3oYnA+ZyjY6TqUphI 9sJu6OtG9TBX7d/HQ/oeqVpNDLih29IC/0YoF9CdJYSZ65ofyo7PCjhoDTke2Pdbj4go y2vqV5sNMfBO5UpQl/duC6zI5hu1Xp/UHWENdZrgsykG1ATg8+B14MuZVibaWCcZRwCM KEY6MHlMb5CVlO8sbvFA09Wzog7d9+Vm++5WIGegdIzlUh4wzqlSdbEB3Kqo8d7ijngo 2aGGAKTG4GOLbSrllXz9IkGOBBtds45Rk9VLM7gV+qiHKgyKI3IAcGwN77H9a4rMFYaL zmgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UwkN3maF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a4si4818733edn.451.2020.04.25.00.04.40; Sat, 25 Apr 2020 00:05:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UwkN3maF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726445AbgDYHCg (ORCPT + 99 others); Sat, 25 Apr 2020 03:02:36 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:52856 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726398AbgDYHCY (ORCPT ); Sat, 25 Apr 2020 03:02:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587798143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:in-reply-to:in-reply-to:references:references; bh=HZm6DwXTwnx3KiIUACMsSmVOaGpBtskQUoUJSCSU4Rk=; b=UwkN3maF7BJQptgnM1/4776MctmZ9m2sCLWi2DzvI8mFD/5Zc1pFC7g1wKI379J1xmtasX QtQ3O8mwz+8xQpj4f4WTtd5ri1GOOMK8Kh4q9awk7rpRhmxerWwVkLzDCBG8ABKlCjE4HN tVoa2XDDR1Z0QnN2EUZ6b4d2NpCIhnw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-380-4ZB6agrCM12kT8-FC1h6-w-1; Sat, 25 Apr 2020 03:02:18 -0400 X-MC-Unique: 4ZB6agrCM12kT8-FC1h6-w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 888271895950; Sat, 25 Apr 2020 07:02:17 +0000 (UTC) Received: from virtlab511.virt.lab.eng.bos.redhat.com (virtlab511.virt.lab.eng.bos.redhat.com [10.19.152.198]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB2DB600E8; Sat, 25 Apr 2020 07:02:16 +0000 (UTC) From: Paolo Bonzini To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: wei.huang2@amd.com, cavery@redhat.com, vkuznets@redhat.com, Sean Christopherson , Oliver Upton , Jim Mattson Subject: [PATCH v2 21/22] KVM: VMX: Use vmx_get_rflags() to query RFLAGS in vmx_interrupt_blocked() Date: Sat, 25 Apr 2020 03:02:14 -0400 Message-Id: <20200425070215.251397-2-pbonzini@redhat.com> In-Reply-To: <20200424172416.243870-1-pbonzini@redhat.com> References: <20200424172416.243870-1-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sean Christopherson Use vmx_get_rflags() instead of manually reading vmcs.GUEST_RFLAGS when querying RFLAGS.IF so that multiple checks against interrupt blocking in a single run loop only require a single VMREAD. Signed-off-by: Sean Christopherson Message-Id: <20200423022550.15113-14-sean.j.christopherson@intel.com> Signed-off-by: Paolo Bonzini --- arch/x86/kvm/vmx/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index 0e5eacd6f911..9e2ba1f96cd1 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -4537,7 +4537,7 @@ bool vmx_interrupt_blocked(struct kvm_vcpu *vcpu) if (is_guest_mode(vcpu) && nested_exit_on_intr(vcpu)) return false; - return !(vmcs_readl(GUEST_RFLAGS) & X86_EFLAGS_IF) || + return !(vmx_get_rflags(vcpu) & X86_EFLAGS_IF) || (vmcs_read32(GUEST_INTERRUPTIBILITY_INFO) & (GUEST_INTR_STATE_STI | GUEST_INTR_STATE_MOV_SS)); } -- 2.18.2