Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp637856ybz; Sat, 25 Apr 2020 01:01:45 -0700 (PDT) X-Google-Smtp-Source: APiQypLYYEZ0AYA7jox/LPQcbrf5W4Eefs4csv28UWliwMCbB3MjJyY+r2VTfZTQ0CaSHuzRP/BJ X-Received: by 2002:a05:6402:28e:: with SMTP id l14mr10480809edv.184.1587801705662; Sat, 25 Apr 2020 01:01:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587801705; cv=none; d=google.com; s=arc-20160816; b=jZFtmtmR8j/2wcShtOmJWzEvM3k+3a1yJt8iueRhrMfCL4qcIvYenqXK+iRBQU6OFx aSbw3K8wtO4S9WV/oCvZLwI1d4YZDtmee3p6BHVSZlSguOKIj5wvH6yg2IlHMjsJbpw2 8LdeCORbYPheCIuN5wWhHHWf2PKBni+lmuQtd2vgFwF/3g1IFxTAxyZLOpdp5x97o3Ug B3q6gs2K/UzYBhmPvqAmvYG5/RC9Dw2Nzj/w2MEuiY35UFalsR8CrSy2tcySifwwtYlJ tRyqPLUKYA2bmOOs2i/968UtUT6LvtmOTtI5701g5LWNCH1J6VVmwR+NfZC3KQbgJ8+6 wpsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=m05S9ckcfqH+AsAeGfxl4bDUEgO09heXqe8WR8G0tyI=; b=LEQU8ld4mjrHrl7oDkjpKt3T+dba/kMNfNlKWuR6pUw3xPBwvv6lsOZ6fzJf55TPJF 51JkzshVUEii890hzLX+ypZVokl9J6LegvUQ6eXPMoam0ACZFiiyETc14DvrGAPDqxlI NFlQNgOUlkYkcwXLWr5SGypUTw2g5IFhllJ/pyXnA7EEokuuJG3kmlRj136ZgTHGEZLL euNvMRKQE5vevKPWfJkEtp+fh9c4o0INTraw8qjJ6rS8w1JT5qBhaacH2cwqDcl4Arfe C/HLMgv3By98/v/HOfVTDl8AKhGWx3ZHDB3WjqOaOigNfQK8ipqgx3lFm3tLvdB17PQ7 avpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=pqwaL8Ep; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q4si4529128eji.14.2020.04.25.01.01.22; Sat, 25 Apr 2020 01:01:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=pqwaL8Ep; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726392AbgDYH54 (ORCPT + 99 others); Sat, 25 Apr 2020 03:57:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726132AbgDYH5Z (ORCPT ); Sat, 25 Apr 2020 03:57:25 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10164C09B04B; Sat, 25 Apr 2020 00:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=m05S9ckcfqH+AsAeGfxl4bDUEgO09heXqe8WR8G0tyI=; b=pqwaL8EpVLFjH3rNRBkUNo0a9b PvakZp1T7jgMNPzEcMO1UdOlXGeznQ57/53/W+yvbLT7aKOQvf8z8XfaT7W5glWXhYbZfmOsvCH0A 7P+iMSCurR1mZ6aSed1Z4yrqoKPzGO+5o0MID26a3fBVb6DpR0y5K9utEIZJ/NfnGZjIH4rVLrSWH G6sRDFa66M93X7Sehbqm/ce09XmKHR2CTAMPNvcOH535RsBJPLjgv0Ni9SvD7iXMMnfFXLlVHWaKz OaNxZTuEr+BGUW/AkSI3b9bd3CuRf1fTpqIfLal/TnBJ/sFVruQKI8GVIeQT4UjICpP0Xc3oGAuqF S846XK5Q==; Received: from [2001:4bb8:193:f203:c70:4a89:bc61:2] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSFgS-00021F-KA; Sat, 25 Apr 2020 07:57:08 +0000 From: Christoph Hellwig To: Jens Axboe Cc: Tim Waugh , Borislav Petkov , Jan Kara , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: stop using ioctl_by_bdev for file system access to CDROMs v2 Date: Sat, 25 Apr 2020 09:56:59 +0200 Message-Id: <20200425075706.721917-1-hch@lst.de> X-Mailer: git-send-email 2.26.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jens, except for the DASD case under discussion the last users of ioctl_by_bdev are the file system drivers that want to query CDROM information using ioctls. This series switches them to use function calls directly into the CDROM midlayer instead, which implies: - adding a cdrom_device_info pointer to the gendisk, so that file systems can find it without going to the low-level driver first - ensuring that the CDROM midlayer (which isn't a lot of code) is built in if the file systems are built in so that they can actually call the exported functions Changes since v1: - fix up the no-CDROM error case in isofs_get_last_session to return 0 instead of -EINVAL.