Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 25 Apr 2020 11:28:49 +0100
From:   Russell King - ARM Linux admin <linux@armlinux.org.uk>
To:     Florinel Iordache <florinel.iordache@nxp.com>
Cc:     davem@davemloft.net, netdev@vger.kernel.org, andrew@lunn.ch,
        f.fainelli@gmail.com, hkallweit1@gmail.com,
        devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
        robh+dt@kernel.org, mark.rutland@arm.com, kuba@kernel.org,
        corbet@lwn.net, shawnguo@kernel.org, leoyang.li@nxp.com,
        madalin.bucur@oss.nxp.com, ioana.ciornei@nxp.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/9] doc: net: add backplane documentation
Message-ID: <20200425102849.GX25745@shell.armlinux.org.uk>
References: <1587732391-3374-1-git-send-email-florinel.iordache@nxp.com>
 <1587732391-3374-2-git-send-email-florinel.iordache@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1587732391-3374-2-git-send-email-florinel.iordache@nxp.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Apr 24, 2020 at 03:46:23PM +0300, Florinel Iordache wrote:
> +Supported platforms
> +===================
> +
> +Ethernet Backplane is enabled on the following platforms:
> +
> +LS1046A
> +LS1088A
> +LS2088A
> +LX2160A
> \ No newline at end of file

Please fix.

> diff --git a/Documentation/networking/phy.rst b/Documentation/networking/phy.rst
> index 2561060..1f1ebf2 100644
> --- a/Documentation/networking/phy.rst
> +++ b/Documentation/networking/phy.rst
> @@ -279,13 +279,22 @@ Some of the interface modes are described below:
>      XFI and SFI are not PHY interface types in their own right.
>  
>  ``PHY_INTERFACE_MODE_10GKR``
> -    This is the IEEE 802.3 Clause 49 defined 10GBASE-R with Clause 73
> -    autonegotiation. Please refer to the IEEE standard for further
> -    information.
> +    This is 10G Ethernet Backplane over single lane specified in
> +    IEEE802.3ap-2007 Amendment 4: Ethernet Operation over Electrical
> +    Backplanes which includes the new Clause 69 through Clause 74
> +    including autonegotiation. 10GKR uses the same physical layer
> +    encoding as 10GBASE-R defined in IEEE802.3 Clause 49. Please refer
> +    to the IEEE standard for further information.
>  
>      Note: due to legacy usage, some 10GBASE-R usage incorrectly makes
>      use of this definition.
>  
> +``PHY_INTERFACE_MODE_40GKR4``
> +    This is 40G Ethernet Backplane over 4-lanes using the same main
> +    standard used for Ethernet Operation over Electrical Backplanes
> +    and additional specifications that define support for Ethernet
> +    Backplane over 4-lanes specified in IEEE802.3ba-2010.
> +
>  Pause frames / flow control
>  ===========================
>  

This ought to be in patch 3.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up