Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 25 Apr 2020 05:41:10 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Ingo Molnar <mingo@kernel.org>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Vince Weaver <vincent.weaver@maine.edu>,
        Dave Jones <dsj@fb.com>, Jann Horn <jannh@google.com>,
        Miroslav Benes <mbenes@suse.cz>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v2 00/11] ORC fixes
Message-ID: <20200425104110.3bx5xb57fssdvd4y@treble>
References: <cover.1587808742.git.jpoimboe@redhat.com>
 <20200425102512.GA12331@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200425102512.GA12331@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Apr 25, 2020 at 12:25:12PM +0200, Ingo Molnar wrote:
> 
> * Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> 
> > v2:
> > - Dropped three patches which technically weren't fixes.  Will post them
> >   later as part of another patch set with more improvements.
> > - Removed show_iret_regs() declaration [mbenes]
> > - Added Miroslav Reviewed-by, Linus Reported-by
> > 
> > v1 was here:
> > https://lkml.kernel.org/r/cover.1584033751.git.jpoimboe@redhat.com
> > 
> > Jann Horn (1):
> >   x86/entry/64: Fix unwind hints in rewind_stack_do_exit()
> > 
> > Josh Poimboeuf (9):
> >   objtool: Fix stack offset tracking for indirect CFAs
> >   x86/entry/64: Fix unwind hints in register clearing code
> >   x86/entry/64: Fix unwind hints in kernel exit path
> >   x86/entry/64: Fix unwind hints in __switch_to_asm()
> >   x86/unwind/orc: Convert global variables to static
> >   x86/unwind: Prevent false warnings for non-current tasks
> >   x86/unwind/orc: Prevent unwinding before ORC initialization
> >   x86/unwind/orc: Fix error path for bad ORC entry type
> >   x86/unwind/orc: Fix premature unwind stoppage due to IRET frames
> > 
> > Miroslav Benes (1):
> >   x86/unwind/orc: Don't skip the first frame for inactive tasks
> 
> Thanks for doing this. These ORC handling bugs IMHO look serious and 
> widespread enough to warrant x86/urgent treatment, and the v2 series is 
> fixes-only.
> 
> Any objections against targeting v5.7-rc3 with this, assuming that 
> there's no problems found during review and it passes about a week of 
> testing?

Hi Ingo,

Due to other distractions, I unfortunately have been sitting on some of
these fixes for several months -- notice some of the long Reported-by
chains :-/

They're good small localized fixes and I would agree it makes sense to
target x86/urgent.

Thanks!

-- 
Josh