Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp759885ybz; Sat, 25 Apr 2020 03:45:27 -0700 (PDT) X-Google-Smtp-Source: APiQypLXmVrNq13qfCfbRb/WTrm34tOJn0MYK2cOG1wFteiKeELOM1CTKatNO1SewuvkWnqdZWUV X-Received: by 2002:a50:da49:: with SMTP id a9mr10650477edk.388.1587811527047; Sat, 25 Apr 2020 03:45:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587811527; cv=none; d=google.com; s=arc-20160816; b=NyFN7aThvqBSSso08IN3ouEWAC4INh25cNnO+ZtMiuTJtdjnxE91f7/YvfXApahKOg 8EIv+1iwyr9cvzwtOYAUCiWn9Q7jTvMxMme4Cyq/yNW0NUn93PYuoRhw8vzEArNPBakX 8TfNYP3KPW+lPtVZULEW3NF491aJ+PFT6iAVTNQzNlPFVpB3GYmwzYEtBBAkDn9mMgYj vbhvuolp6D0iO7douQ8X0/yhIlnfmGRXsHUNuAgAfSPmKGM1g4lhX0l/IVnXr4oEnNBY GgTTK4noQU59b0dyJJP7lohiJecWHYfUHrpgR3wt+qgfyyadboumAxInkedTTU6ITRAC BavQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=zenMpg+2v4nQ44+/jX7Ww4Nj5mK/XgsXmzCGzWANwV8=; b=JSNx1ZaFZow5k4GjZLp2kcKFtTT0nEDZztHM7kXiUiTT44HP7eKu6UX62AtetPyt1a MKsdKtX0tjBgwlwZ+L8vQUIIcMv4onliyHQkRZcr7HWN0iEDdpocIUMb+IS3+gcSKJXU NhPopVO3mfX3oHonxipqesRUhDNTBstQjyOJlsGVOxnQhvCGoAu4oGYkbiWqql2oOWPO kv7JGcTO9JefspV+Tgghui6X7ExtsLapLqg1wJKIiyy78H6mWph3KQQZAd4fID13HEhX QzMtzHzhIqoxcYs49Lwm60MUTTG3OD1kvrr8qiWZIHPMH0BN17JA2xDh8iPBK+XGb6PT OTAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aefTb9R0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ss10si2654063ejb.103.2020.04.25.03.45.03; Sat, 25 Apr 2020 03:45:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aefTb9R0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726128AbgDYKnn (ORCPT + 99 others); Sat, 25 Apr 2020 06:43:43 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:52775 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726050AbgDYKnl (ORCPT ); Sat, 25 Apr 2020 06:43:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587811420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zenMpg+2v4nQ44+/jX7Ww4Nj5mK/XgsXmzCGzWANwV8=; b=aefTb9R06CSZey0rgWcce0Y8X8TNDdsjWPkZA4qniRj9xB035FnpTEJejLiT861s5D/enb JFPPp8LvRl6H4UScjKFJGWomYyZies49OYgjM5tMb120wnFQ3cTEi1oI4tyn/ahOzH4qhQ AW2tbYIrzt8ZVxqckYzIygHio/DLmUs= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-217-5dVvx2_jM4mVRBrX59UMDA-1; Sat, 25 Apr 2020 06:43:38 -0400 X-MC-Unique: 5dVvx2_jM4mVRBrX59UMDA-1 Received: by mail-wr1-f69.google.com with SMTP id v9so6488728wrt.7 for ; Sat, 25 Apr 2020 03:43:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zenMpg+2v4nQ44+/jX7Ww4Nj5mK/XgsXmzCGzWANwV8=; b=Q20uj/Eg5nykrD5defV2/RUk/RX2XmfiZe4CGJcjp+N34jsA6BpHYAT7b7QMy4RAZ2 GJRdKEvOTrR2i2Ch0QwdfrQ58bpX9Dn/AYeeGHDRErfmOA8UWJCEQYC5g4n9Rm9SxloP 6jqjPeU5XJQJndxqebrC7VlHXOXqWLjbEeqAgEpr51M5PVpxko+nifEEOENutzDeIwum ERj5I0gTwY9sDCQWVKFq09GjYsP2yVtW0ie8Olej1jPK45eRWHDWeZEOQg6yF+a912Nq u83jBjsU+/Grz3JR37opN1Pdlwq0/qe/0ruaiV6QbgHIfdfRst82xN63bOga88YHJgLJ AFgQ== X-Gm-Message-State: AGi0PuaOTtl+R0ch5hXJgZwmEgVLvCTvWL/qdxBQ1nUYxYYM0pE30sQR R/E8wSnnT29rUOjVtibVqtbcytWSWuaGlH/hg/ThrwitCBVH8/iVHxa+rYpxXNYQNtDOPpVB8TN eeK5F0E8ZSO3ktvp+Thk7tPss X-Received: by 2002:a1c:f20c:: with SMTP id s12mr16485418wmc.83.1587811417047; Sat, 25 Apr 2020 03:43:37 -0700 (PDT) X-Received: by 2002:a1c:f20c:: with SMTP id s12mr16485405wmc.83.1587811416907; Sat, 25 Apr 2020 03:43:36 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id x132sm7007951wmg.33.2020.04.25.03.43.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Apr 2020 03:43:36 -0700 (PDT) Subject: Re: bdi: fix use-after-free for dev_name(bdi->dev) v3 To: Christoph Hellwig , axboe@kernel.dk Cc: yuyufen@huawei.com, tj@kernel.org, jack@suse.cz, bvanassche@acm.org, tytso@mit.edu, gregkh@linuxfoundation.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200422073851.303714-1-hch@lst.de> <20200425075906.GA5250@lst.de> From: Hans de Goede Message-ID: <7bac482b-7940-e6a1-6256-194bc3393063@redhat.com> Date: Sat, 25 Apr 2020 12:43:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200425075906.GA5250@lst.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 4/25/20 9:59 AM, Christoph Hellwig wrote: > Any more comments? Are we ready to merge this now? Merging this fine with me. Regards, Hans > On Wed, Apr 22, 2020 at 09:38:42AM +0200, Christoph Hellwig wrote: >> Hi all, >> >> the first three patches are my take on the proposal from Yufen Yu >> to fix the use after free of the device name of the bdi device. >> >> The rest is vaguely related cleanups. >> >> Changes since v2: >> - switch vboxsf to a shorter bdi name >> >> Changes since v1: >> - use a static dev_name buffer inside struct backing_dev_info > ---end quoted text--- >