Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp768529ybz; Sat, 25 Apr 2020 03:58:57 -0700 (PDT) X-Google-Smtp-Source: APiQypKxM7/qB1PHX25vvgX3QJeMKfPpTlVDgQTMhKY5VtU5kEoMbelAAxk0IG/P2iL2++U8jPGv X-Received: by 2002:a17:906:328c:: with SMTP id 12mr10619424ejw.69.1587812337404; Sat, 25 Apr 2020 03:58:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587812337; cv=none; d=google.com; s=arc-20160816; b=vKQHXNRaIEyxPGVh8ts4vL056cuwHVaISJyXQ0maZu7DwmZSFRkN00t2dJlkhOSbUb k+ExAnSetUDCU2yWOWYus+k4aOeXJ6zaf3pqGsol3prnflWmw7yIhsoOinysd9LksgXL ODpTh20bZyNS71454WD+BnUruHSgSjPFrCc7vLTIsLaIULrC5iiSTSujLObuH2pdskQd FsterK0YB0CRcrKylmKyhMkpkdEB9UCQjWDxNj5UJ0ZdzrtZIuXtZ1QXUIctN+oLl03g gqmn7113Vz1kdHGlG6jvw2NPgGxdV42oMKKd0JkqDnY73k9+xEBAYg4WnqID7ANHkSFc QxBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=qTue+FDhiBAgX38sor7KiX5ufEQlL5VQiONYzIvZc/c=; b=e+zWRTmIQ7MagJ64gyIRc18B11buTU1qgQc9T15U8cCuDpiyuFMJrl/NImYlKxL8SC 98nEbB5OESf9QFX35YD/SceDVs/vm0brw57f/gPP8/ljoQrnNe0FBSdfTNwIMsQOpb4Q fGYzOFo5wN+16jjx3kTg41h4w5wYNUP/Xo2/L5NGyNdmmlkg0VKeHb7aqVhlYcB/S7ti DrnhgRnYp6ETi7X/SDbx/2XcwbJn5akvicazYaEjVt98RnTBPDcQeHK/GfDBbTGh5+VG BSTmBmwYTqT4hCFft4Hl0/t7t5XWDAdHlLg2eTwzDEmnPohtIvBYFPOH52tbj5vvXzXJ 5paQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KoTEhf54; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rl27si4901813ejb.17.2020.04.25.03.58.33; Sat, 25 Apr 2020 03:58:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KoTEhf54; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726090AbgDYK43 (ORCPT + 99 others); Sat, 25 Apr 2020 06:56:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:35736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726050AbgDYK43 (ORCPT ); Sat, 25 Apr 2020 06:56:29 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6649320714; Sat, 25 Apr 2020 10:56:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587812189; bh=5WUhtskZxlE9n338vkgbHZfKEH8M1JzBUBkWJZF/qo8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KoTEhf54SHrrXeIMq57jRFSwhq7z8lmvBEhiN2G45IYURC5nB2kO3riLOXxhhVS9i 86ZuHW9IFyzVOWxsKA2t8qYJTqTPNtB1u4n7T5TkrHfU9F5e7iLfx7i2K1F3q1S714 f3mV3oAuCkuhdy++lr18EtT4E9i6CFAcsl8vZ0kg= Date: Sat, 25 Apr 2020 12:56:26 +0200 From: Greg Kroah-Hartman To: Oscar Carter Cc: Forest Bond , devel@driverdev.osuosl.org, Malcolm Priestley , "John B. Wyatt IV" , linux-kernel@vger.kernel.org, Stefano Brivio , Colin Ian King , Dan Carpenter Subject: Re: [PATCH v3 0/2] staging: vt6656: Check the return value of vnt_control_out_* calls Message-ID: <20200425105626.GA2071483@kroah.com> References: <20200423153836.5582-1-oscar.carter@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200423153836.5582-1-oscar.carter@gmx.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 23, 2020 at 05:38:34PM +0200, Oscar Carter wrote: > This patch series checks the return value of vnt_control_out_* function > calls. > > The first patch checks the return value and when necessary modify the > function prototype to be able to return the new checked error code. > > The second patch removes the documentation of functions that their > prototype has changed as the function names are clear enought. Also, > the actual documentation is not correct in all cases. > > Changelog v1 -> v2 > - Remove the function's documentation instead of fix them as suggested > Malcolm Priestley. > > Changelog v2 -> v3 > - Rebase against the staging-next branch of Greg's staging tree. Are you sure? It still doesn't apply :( Please try again. thanks, greg k-h