DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=l3QAULJFBscGtMpjHAUnzbV8+nQr68ms5bYdXK3eQKk+659qE1AFEVSoxNGuUqa7K+8JACqExtVkZNU/MtZ8QFGWL9jEpb87eYFvjlkpDMHzd956xM9ghspPRlaQm2eBSeKivd6nwaKG8oPvpPUOyQrkRLO52YA7+SzShqpS/g4=
Message-ID: <84144f020603060023s236c7221i3d6b20b6c7132ef4@mail.gmail.com>
Date: Mon, 6 Mar 2006 10:23:36 +0200
From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Al Viro" <viro@ftp.linux.org.uk>
Subject: Re: 9pfs double kfree
Cc: "Dave Jones" <davej@redhat.com>, "David S. Miller" <davem@davemloft.net>,
       linux-kernel@vger.kernel.org, ericvh@gmail.com, rminnich@lanl.gov
In-Reply-To: <20060306081651.GG27946@ftp.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Content-Disposition: inline
References: <20060306070456.GA16478@redhat.com>
	 <20060305.230711.06026976.davem@davemloft.net>
	 <20060306072346.GF27946@ftp.linux.org.uk>
	 <20060306072823.GF21445@redhat.com>
	 <84144f020603052356r321bc78dp66263fbfc73517c6@mail.gmail.com>
	 <20060306081651.GG27946@ftp.linux.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 545
Lines: 13

On 3/6/06, Al Viro <viro@ftp.linux.org.uk> wrote:
> Legal, but rather bad taste.  Init to NULL, possibly assign the value
> if kmalloc(), then kfree() unconditionally - sure, but that... almost
> certainly one hell of a lousy cleanup logics somewhere.

Agreed.

                                 Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/