Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp893138ybz; Sat, 25 Apr 2020 06:35:55 -0700 (PDT) X-Google-Smtp-Source: APiQypJtJtYu0ZrADLMWq75OiTaDQhrodLF82ah65vqIokz35ypKcCEm8ENhonq3AyK4ft7Uq1I7 X-Received: by 2002:a17:906:4310:: with SMTP id j16mr12156442ejm.102.1587821755165; Sat, 25 Apr 2020 06:35:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587821755; cv=none; d=google.com; s=arc-20160816; b=bmWjag/a6SBR4fpj88UfORfHZGRmIZyvbBPXcwa9+W1+vfs3d2Ri9cc2DuaV81G/+v s0XSafcd1aTXqjvFvSYgYEdtyBIK36eyjvmvGKfCMAPkwo67sZQvskXrvXrlF58fviUq YBOfsKDEI1j4Go3TwDb0OoqI/weGUjyL+nyjSNouv/cMMrTuFPhNxu/8TvjohUN6cFTk BJZI/F/pnok/2EpurCy5wcaQFhhUNLMyq8UzTDA0ThDVS/2O6f+IotiliDg4fcCmYb5a 4kkM+l42LODuXJHyCkZajfD90wwR+I+mufGSB/aQfzJLyDJXZRtWIybT/ixoEPH4RWRX j4qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:user-agent :in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:dkim-signature; bh=g8mVEgIpxUfB6m1Lu7D6u/PpEpBcm/7Z6L0AkNrQ/FA=; b=sLbsL+vxggvrB7M8wSz6oUMFucp6A/MGe8gH4ap6kwgnI0myX3ieKKfmrpszJh1GoS pwMZpgV7E3Kcxrbm+VKfEqklESuv6/yhqk4lGLXtvDi+Oi5ikyx7rRyiKVfziVAjMr15 C9nCR9B1lbCX+HcGbAy/ScPc5yolrhVP8h6AItnITjALzikCZ0Ti7WQghAgB/68+dtiN r5hQCfaiAwAI/rY3t0UFoNbJFjP6ZBM38CzVZ8C5i3Pay5S7UYinNIgJN2QAUnZap3nL 5k3JeDvZanNdA9jN478joIzIV2pONvWoOdj0g5AYML5wKJyxW8Bq0y9yE1Eg35l+vK83 4/zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=f4JVweYj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id di22si4760267edb.427.2020.04.25.06.35.30; Sat, 25 Apr 2020 06:35:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=f4JVweYj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726101AbgDYNeN (ORCPT + 99 others); Sat, 25 Apr 2020 09:34:13 -0400 Received: from mout.gmx.net ([212.227.17.22]:56021 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbgDYNeN (ORCPT ); Sat, 25 Apr 2020 09:34:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1587821640; bh=IHJr0EedB5g0v4EzA2wx0bNnO9PYSjipPdPGkVa4SwU=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=f4JVweYjLw53F+uNpzUpE2HiBzszaSwE1tAPftFGZbZmSQZVo7kF/Ko7XaQnP7Fum 6ZQrvlhCQ+lBZyLEOGVQ+ugAqTlA9V8McyeUBywP8Qlslr84zdTnVbTSLOO80q+PMQ b+DsKvTO0XAA516wrHuxdheSHidO2EmtdUEwBJnw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from ubuntu ([83.52.229.196]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N4QsY-1j1YhK15aY-011SPq; Sat, 25 Apr 2020 15:34:00 +0200 Date: Sat, 25 Apr 2020 15:33:45 +0200 From: Oscar Carter To: Greg Kroah-Hartman Cc: Oscar Carter , Forest Bond , devel@driverdev.osuosl.org, Malcolm Priestley , "John B. Wyatt IV" , linux-kernel@vger.kernel.org, Stefano Brivio , Colin Ian King , Dan Carpenter Subject: Re: [PATCH v3 0/2] staging: vt6656: Check the return value of vnt_control_out_* calls Message-ID: <20200425133345.GA3213@ubuntu> References: <20200423153836.5582-1-oscar.carter@gmx.com> <20200425105626.GA2071483@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200425105626.GA2071483@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Provags-ID: V03:K1:KXBYBCq2DCQlw3hPhjG7bnN9XK+vmznMHfD1l/dURAheFhBu1dL 9/+ahVPvXZISDT+0glhxM/rLKOeJBzMwoeD3qFc4vOkz834ohoMf+kMe1F1250ACaZif7OM yZxZriAm7QGiyJU0aRDe03SvDdNrPeSoIObEh1xlzKR2JvtTLRDTF9Ay0aV72alS6GB16JR /TpHerwHqQc6bg8bxVIuw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:zNIjFPpz60s=:R2DLJ+tTejcjTD/tSOEl59 6lN4YIFMLvk+eMiU9R9fCUWY8CzZkfWsfs4es8tjPxKDxZEtNRfZYFt3Z+cIM3v+bqqCwf1B+ auPEaCHgHKPH4DxDPlwdfYwbB7A+1B+7eJqmR17yotv1qiMpbOrw1wVHH4aCgJWgsIk970wXK sC7HmLo6SnYKGSAVcF30deQkNLyRLwlPULNfclCPJANp1+1T723+01YfM9DeN7t6Q0JNeK4AA ihnishmzciGf25vQTzCMXvFhcQr/ZUC4DCjIIdlX4fYFNUVxw/m3HLi62TXgzIdyPgza9CkqC TlPgoDgz+lA09C62fyh6CUjORUswU5jfDdHmDgcfx+nnsy1Cszt1M6yfJ7xrS7mJkULz7o3UE aNNBBErEtLjo4ucSP7ZhjISKtFflkCjw1fjaAECAlZ+gHdF7Z/PZ3EsZzT1kQSDN0+M7SR30m mzite2idKAzDExIj05db8CFdg0qcC9y7JjKcKCGVOty5fpTgV2QgGkhs9b1w6wg6nOAN22SZ9 D6XVBQHsgbzQ4nnMltjeu/10kINKq+lzavq4emqX28oM1aU+dsJjFkDBxReJ4s8z8QnKdzWaJ y7OCbR43RBX8l04w2RYgQ319Ngp2kFlz61UqD3vimpsbuWiHKkDaOhV8pIVAIIkk1niOJIr2X Xw8a+inpwgtdGlO5SnA5/BNlHH7Ek2PEo0ERykb4HxwB6Py5pItdD46MR9n0DL1jEj551o3HT g49NNH0STwnKC2rqvYumpL0TZaAEzEPL9KJ1m2oiaG/LuItmJBGobQK0HBBFIHeIJGj5GlkgC ENKNQKj9Bz/j0sEY+8u8hZylLhcUEpaqdFck1qnF41llIA+mizGNBj28TpfniwAnSXWlwkb/P 8euALhf7Vmpm6bL53qlbRGgjQb8GIvJSgEJn0yNMFqi3CKJZpLhOwsnBW5F//bc0ua6Lsl0aY qlxxeuWFrZDadfdGDWI7zVwivqAQgjmau/OWJQT1Ur9mLw82rqjtcH4owv66kGrjYiAqw9fqO 2E722y3BTwOQfaDVj+O1w02Z1p8T2BVQM0MlmVqSHBSObuL3hI+gTo5MeasfFi6ZgdO18rGTm kJAqfGzvzIpjbO9vwLc7C6oF7Qg32vNEuORxLrs2tyZD/xaVzOfIzHO4RnC9YdZM4iIhCzQq3 M7kPG4wodVcyKJL5SZScSzYSGbhyrHIVbadeMVaM6lSkaS18n6imARFllzzsvLdBdvNS5Nzql mLqbJsEZGawvyPRUy Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 25, 2020 at 12:56:26PM +0200, Greg Kroah-Hartman wrote: > On Thu, Apr 23, 2020 at 05:38:34PM +0200, Oscar Carter wrote: > > This patch series checks the return value of vnt_control_out_* functio= n > > calls. > > > > The first patch checks the return value and when necessary modify the > > function prototype to be able to return the new checked error code. > > > > The second patch removes the documentation of functions that their > > prototype has changed as the function names are clear enought. Also, > > the actual documentation is not correct in all cases. > > > > Changelog v1 -> v2 > > - Remove the function's documentation instead of fix them as suggested > > Malcolm Priestley. > > > > Changelog v2 -> v3 > > - Rebase against the staging-next branch of Greg's staging tree. > > Are you sure? It still doesn't apply :( > > Please try again. > Ok, I will try again. > thanks, > > greg k-h thanks, oscar carter