Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp900148ybz; Sat, 25 Apr 2020 06:45:27 -0700 (PDT) X-Google-Smtp-Source: APiQypJZ9WdOf8enLtC6xiFETJfTqTNGz8BNYgzKKmnen48szP3R7bvjV0RV+MDjvbKc/5qwkKfo X-Received: by 2002:a50:d98b:: with SMTP id w11mr10901347edj.196.1587822327431; Sat, 25 Apr 2020 06:45:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587822327; cv=none; d=google.com; s=arc-20160816; b=P0vLpBoN1bjwtXx6NDNC0ORcAv1AitiCN6bKfBeoSxG+k5xqxWMIEtRsK3y80Q9vej bAGPDxN/kcjttgBrtDCJLToSiQUlhTddwUqPV0hHEznUG+hFGBoaXB7nh5gCTJbUTqk3 8/gxlVGeHsytOkrf4yKwPdrqtaH6q7UtlXl0Y4tGlJuvfdMA3rDayQrP3wSTr0v0M8ef wAinSGnYpkkydnMDvQK5XRLN7O7FUM5m1rCkYypp7RRXyY6CZe82GA/DDZBoruORruoJ JzS+OQ6T8MdRy4bW5/9Jqeifni2bcb1XiFRP9dl97eeVcE2mkad/QuWionL2TKZlSl01 JnPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LGB3othFoJOZedk+rwrbfWun18M41ZXnWN7UzUaY+H0=; b=Y5oNxrBYWvNM6iNlgkOFAPYnB7nxQYDh4qheVwrzOWKK5Rqe/L2Tj9qsV2t3Npp++N PFuOv6yhJbEEJwSUF7b6XgnD+PHJ1zG3PZIHAXuHnAUh0UrlnSnXR90PRTgEbdztTTpU awVh9ArG2f/drSENawNkpNT4Jz/JGRfuJ9+t7w+OkhLglVQGJPdv/tyKj1Bo0vg414fS +kqQ70Ne0yRQx48iHWDIlTLHn0HYyfIh0zic6qqAeu1zrjsTH6CNUqpnLFPSF2GmFGd8 0rZNPpYHddjLQWK/uOQKg4kIjwzNzkjxwuJq5mDxLwLXyzn2kO7xArBx7EQDmGB64Jo5 caWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=bclzM9w1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cm21si5090117edb.275.2020.04.25.06.45.04; Sat, 25 Apr 2020 06:45:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=bclzM9w1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726116AbgDYNnl (ORCPT + 99 others); Sat, 25 Apr 2020 09:43:41 -0400 Received: from mout.gmx.net ([212.227.17.22]:39533 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726087AbgDYNnl (ORCPT ); Sat, 25 Apr 2020 09:43:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1587822209; bh=F4k0zl5YuytqaKhKKfGkEmxzH9EdfgCDn9zR9dDO458=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=bclzM9w1gJP6B6o4fvnI3JEAspz32bIy9G0tcjl7KtVhcNa2SpIVHhomSueRL9YtZ WQJ+vyr2Vn+kUwZaUG71Sfo0ga1upxC2evbyZhID2yilrBNEe6ntbXkIXEBSNFo3Sq UHmJLm1qNhTVc/V+HnPwcTNstlPnjg6VWmINKvS0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([83.52.229.196]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MAfYm-1jLhGK3u1Y-00B4DQ; Sat, 25 Apr 2020 15:43:29 +0200 From: Oscar Carter To: Forest Bond , Greg Kroah-Hartman Cc: Oscar Carter , Quentin Deslandes , Malcolm Priestley , Amir Mahdi Ghorbanian , Stefano Brivio , "John B. Wyatt IV" , Colin Ian King , Dan Carpenter , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 0/2] staging: vt6656: Check the return value of vnt_control_out_* calls Date: Sat, 25 Apr 2020 15:42:55 +0200 Message-Id: <20200425134257.4502-1-oscar.carter@gmx.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:URSGQf31W8t2vC+124LfT2jdGxXZpkjVu6xG6qwbv5Fi33rUSWg /hBqk0OJlQAOKtGtLx0KxEBGNVrP1J6+cNS/tLcI0uYIPq4M4xHfs6R4E91o7oPaC1JN+FZ Eq6Ut6Ql4cMSQ2ISp9kp2St73LPvNeBLwynI6fGW8BP5C1mPgG05GTvg+JuZAGDaOv7aRUc DV46e8lOp2iaMBWqKj9Xg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:UHGDVHN0vVI=:18fo+ciUKitQTMJ2rnE180 cabaSCZnPV2GG958sZ97+pORsUqLEgLSuAAlwjjTrkmMYWJTkOgEJDkKjW+IBqJsZIbuSS/xE Z5RLjujy7DnCg7jBxrFn/TIuhRVb9ytRaB/6t7AYzvOjFmBKj9aC330xfM0er8bMJ9xe0Y9QC QjOtaxzdbreSk1w38zcA7UzEu+v/5ldqgk7SLvyZ1wt05f7CkmyB+GzzcBFo7QTh20of7WD/J 3kg6dwr6i/dP5FIENFx8iGtPUquCfPTi5YutzZT2bl8MYGJexCdunuTblkpzWF8Pbp4I3GniR nB7q+cwc2nNDLztcSmS3jM+IyyFi6XwLI87GzHr6asdnf9xtArvNkJvf6kaSIAaidiwMTrDdp REHNN74roULwOoKGVUDKgSff70NsWQSk7L+n117n6bYPEQYDRf/pA4BTaUV9dg1wzzOzmoTQW fy9V81Tm7fr4kyWPs48MYzCy6ZT4eBY1h5/OMZwNqz12uKBJFjJ9MBTUqGAxoXPqZtHehGUeb whBKUL4rLnkfNQjBNh+2s8TfXW2UAAS8vrqSwFT4urAgplSXswbq+ObZYIxslEfsR8fDCuZ/A QwKPjUJNmo/IoqysGau3A80iRxh9nIwewIu9QSqt4EjSfCVdo+t4SMRKSXKiEo1/gL7JFw+mv DqOyf7dv/pH+ga+2RQ590MOAreLIaHdYIinmtBrAn5dEIZnLq+wOCqPTBm5by883xOHay0PP2 zH7MAQP3tGH0EHI/m1IxmmlagyTHz8GAshFTwnML71ZXZUlCfSBTyqk458KmMMzt1DSi5VVCY V70jcp2ID2jBiaZTgZAfnhaPuZbZjvN03r6FZnWDjoPMcd2+N+v1F7UwJQUbhVyhXkdijPk6G 33GmaDtiiLRM8kcIoQ9rU7J4cw3MOvo8N1/wpA2znhGXgcyiLMAOI6nsYRAIyr6ZfAbbGDTqU fHa1amX7XlfYYQrQhZYHH6GZ/EAIyn47enJTtkvakJTUkkVnk/JFqMfCkNQ5BMcMbbS3S050z KiJmxCQc6VpbZrGtXY345bYzh9Gr88Quu+N4bFA23GphWXC6Z0sduKgwKDHSmm9xPiEKcTGSo uAPZhO7pcXq5DTOZJMX152PX0mUyfc3M6+czjHXlbHuBJu+79rbeKycv57bp7UFFa7RNUqPAl lehABpW0CuqgcF1ARG+cbpfidAAN8uZBZWDV907BYZEdDnwPswbYMSKtyLT7IoD/VDb4T8r/m vbgcZWMB/IGA0pprE Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series checks the return value of vnt_control_out_* function calls. The first patch checks the return value and when necessary modify the function prototype to be able to return the new checked error code. The second patch removes the documentation of functions that their prototype has changed as the function names are clear enought. Also, the actual documentation is not correct in all cases. Changelog v1 -> v2 - Remove the function's documentation instead of fix them as suggested Malcolm Priestley. Changelog v2 -> v3 - Rebase against the staging-next branch of Greg's staging tree. Changelog v3 -> v4 - Rebase again. Oscar Carter (2): staging: vt6656: Check the return value of vnt_control_out_* calls staging: vt6656: Remove functions' documentation drivers/staging/vt6656/baseband.c | 35 +++--- drivers/staging/vt6656/baseband.h | 4 +- drivers/staging/vt6656/card.c | 176 +++++++++++------------------- drivers/staging/vt6656/card.h | 18 +-- drivers/staging/vt6656/mac.c | 128 +++++++--------------- drivers/staging/vt6656/mac.h | 26 ++--- drivers/staging/vt6656/power.c | 22 ++-- drivers/staging/vt6656/power.h | 2 +- 8 files changed, 156 insertions(+), 255 deletions(-) =2D- 2.20.1