Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200421075532.19192-1-m.othacehe@gmail.com> <20200421075532.19192-4-m.othacehe@gmail.com>
 <CAHp75VcJ300S8r_f2cueYzB0OaLBJK9oJySgz5Jekb7dGFWnCw@mail.gmail.com> <20200425165223.0fc0e930@archlinux>
In-Reply-To: <20200425165223.0fc0e930@archlinux>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sat, 25 Apr 2020 20:14:51 +0300
Message-ID: <CAHp75VebfouNqOJjiKY0zAdxG5d+_JmpO5aVYR_EqcjsmBeXyg@mail.gmail.com>
Subject: Re: [PATCH v4 3/4] iio: vcnl4000: Add sampling frequency support for VCNL4010/20.
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Mathieu Othacehe <m.othacehe@gmail.com>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald <pmeerw@pmeerw.net>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Apr 25, 2020 at 6:52 PM Jonathan Cameron <jic23@kernel.org> wrote:
> On Tue, 21 Apr 2020 15:22:11 +0300
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On Tue, Apr 21, 2020 at 10:56 AM Mathieu Othacehe <m.othacehe@gmail.com> wrote:

...

> > > +static const int vcnl4010_prox_sampling_frequency[][2] = {
> > > +       {1, 950000},
> > > +       {3, 906250},
> > > +       {7, 812500},
> > > +       {16, 625000},
> > > +       {31, 250000},
> > > +       {62, 500000},
> > > +       {125, 0},
> >
> > > +       {250, 0}
> >
> > Leave comma here, potentially helpful if it will be extended.
>
> Hi Andy,
>
> Doesn't particularly matter either way, but given this is a list of the values
> supported by the device, very unlikely it will be extended.
>
> Games like trying to share the first part of a longer array between
> multiple device types might occur, but those are usually really ugly.

Good point. Though I would limit amount of entries by explicitly
writing down the array size.

> > > +};

-- 
With Best Regards,
Andy Shevchenko