Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1276148ybz;
        Sat, 25 Apr 2020 15:13:57 -0700 (PDT)
X-Google-Smtp-Source: APiQypKa+EJ4KoaKIqrP+sJZFKLsfnH1HSx/ZXiNu+LUP0uae7efDqFnHYlBPUAIMuhSF3jQdupB
X-Received: by 2002:aa7:c0d2:: with SMTP id j18mr13427738edp.283.1587852837117;
        Sat, 25 Apr 2020 15:13:57 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1587852837; cv=none;
        d=google.com; s=arc-20160816;
        b=JolAvESo9pzhZxb/SWn8aQay+SY5f3NZFrf6W9lJc29LU5kLYPt3+m8lVsgsX70BaY
         ui3dnoXUMrORqE7KwAtBbBzbH1s7sfQR0Yip+QFRJBvnu6v7mJO/Q3E+O49PHdx5hTVT
         MOhvYr+QNxwO1xJRdlN7C26qL7qodxEv08EPHzOEg4nw9z56mO26xNYZg5BoCcDL2JgQ
         iEmFGu6vmvEYHpsOpM38TDUsNw0rsCRQkFX3P1HYcmFkCpMjtLq2goakrnH7CYtIMd7u
         KsLxghnXsNqkT5ZUPg4eykTlL9QysoKeFovu767PTlicbsdFebpso+7+zgkOgQe2cZWL
         Regw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=M+2SLVtDyEOZG9XNt7U9Wdx7inYhYLLVw0PqKdlIUQ8=;
        b=mrm2Gz2h9U4vfMzAX2gIgiTWj5aQgDxwKDJ80lmDLmd3GiNmPSLRof4jegVDOMvi0K
         dM1+Sue6dCn9UAP07nr0wCiEf4RWJizmN/TO51swilQiw/BxsiBZUlkwIMLb4jI4Ofx5
         h2CAQd6Sb7F4texkZgp2E5j3KT6wpKRM2Mzf6qnpdaqmwIddxzhuEVRy15xc/goYXCfZ
         u0sKkbJPHvmgRqqo+G/7gXsSe5I9zXxYeeEmMeScmypz2HjVodR2LCNhDHLC4Xx3DX6J
         jNcHgC8gAG8cDJawBs0voDso/MmjlFAKs9J0m2tRtgVIYgakcU2BmC6WWDb40qBwm/QN
         dkZg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=qXkJZuk7;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id g7si5348970edk.195.2020.04.25.15.13.34;
        Sat, 25 Apr 2020 15:13:57 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=qXkJZuk7;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726374AbgDYWLz (ORCPT <rfc822;zjuysxie86@gmail.com>
        + 99 others); Sat, 25 Apr 2020 18:11:55 -0400
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:1927 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726220AbgDYWLy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 25 Apr 2020 18:11:54 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5ea4b59d0000>; Sat, 25 Apr 2020 15:11:41 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Sat, 25 Apr 2020 15:11:54 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Sat, 25 Apr 2020 15:11:54 -0700
Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL111.nvidia.com
 (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 25 Apr
 2020 22:11:54 +0000
Received: from [10.2.165.152] (10.124.1.5) by DRHQMAIL107.nvidia.com
 (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 25 Apr
 2020 22:11:52 +0000
Subject: Re: [RFC PATCH v10 6/9] media: tegra: Add Tegra210 Video input driver
To:     Dmitry Osipenko <digetx@gmail.com>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>, <frankc@nvidia.com>, <hverkuil@xs4all.nl>,
        <sakari.ailus@iki.fi>, <helen.koike@collabora.com>
CC:     <sboyd@kernel.org>, <linux-media@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1587700513-28449-1-git-send-email-skomatineni@nvidia.com>
 <1587700513-28449-7-git-send-email-skomatineni@nvidia.com>
 <3155e0d2-94b0-6e0a-bf35-b3560c201039@gmail.com>
 <fffc09d1-a25f-2d6e-83bd-f7657dd2ff16@nvidia.com>
 <e5602c48-a73e-8e71-188d-6a53ebf8e4a4@gmail.com>
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
Message-ID: <f6d62dde-9ab5-7001-0ff4-93ed70cb207f@nvidia.com>
Date:   Sat, 25 Apr 2020 15:11:36 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <e5602c48-a73e-8e71-188d-6a53ebf8e4a4@gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 DRHQMAIL107.nvidia.com (10.27.9.16)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1587852701; bh=M+2SLVtDyEOZG9XNt7U9Wdx7inYhYLLVw0PqKdlIUQ8=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=qXkJZuk7r6LyMrT+wOSNjhCrklbWB1e2SV7oesMNqEqRM5b/VInmh0yb1aXS9CS4l
         SztHqt0F7XVjAO6uQfM6DvVCJd5rryf1lFFwUb1bpXf1ung2gF5nMyzSO6T2CqFDt4
         2pO6I5Rsu+iihq/MDDmyoXXKoewIqNe8NZ67ivJtb8Bb5757hRutLSb6ml+YjIgOiB
         S7ZlRZ6c03O4FR8OwCoomrcZN/yfX0sIZnkGkNTrRtINrYATiguwsblcNGbpRotaAU
         e2X6BDAWEIrMtotyVIFYGu1BlWwXCfnQBnRtRhw8UBSmvE9bzzmlRQ0v3S4VWjjZ+c
         8ni16M1u9QoHg==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/25/20 3:08 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 25.04.2020 01:00, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>> On 4/24/20 8:07 AM, Dmitry Osipenko wrote:
>>> External email: Use caution opening links or attachments
>>>
>>>
>>> 24.04.2020 06:55, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>>
>>> Is this driver compiled as a single kernel module file?
>>>
>>>> +MODULE_AUTHOR("Sowjanya Komatineni <skomatineni@nvidia.com>");
>>>> +MODULE_DESCRIPTION("NVIDIA Tegra CSI Device Driver");
>>>> +MODULE_LICENSE("GPL v2");
>>> ...
>>>> +MODULE_AUTHOR("Sowjanya Komatineni <skomatineni@nvidia.com>");
>>>> +MODULE_DESCRIPTION("NVIDIA Tegra Video Input Device Driver");
>>>> +MODULE_LICENSE("GPL v2");
>>> I don't think that these macros are needed in that case.
>>> The video.c should be enough, isn't it?
>> yes these can be removed
> It will be nice to factor out the Tegra210-specific VI/CSI OPS into a
> separate driver module (say tegra210-vi) to ease supporting of other
> Tegra versions. Of course this could be done later on, although I
> suppose the amount of hassle could be reduced if it's done from the start=
.
vi/csi.c are common drivers for all Tegras. All Tegra chip specific=20
related programming for both vi and csi were already moved to Tegra210.c=20
based on prior feedbacks.