Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1326070ybz;
        Sat, 25 Apr 2020 16:29:46 -0700 (PDT)
X-Google-Smtp-Source: APiQypLl0okHiq22ceDU79t46WJgnpng5PLbLtva/Oz+kOGStaTBHCm4GwZVC4mvJmTYbFDZsoj8
X-Received: by 2002:a17:906:a3ca:: with SMTP id ca10mr13755978ejb.298.1587857385706;
        Sat, 25 Apr 2020 16:29:45 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1587857385; cv=none;
        d=google.com; s=arc-20160816;
        b=YwoS0K2HFJIIQp/SoeXfd5/83b7RC8qbR/liVIb8dG7nW9ss8V2C2om+GI12KbRE0c
         xmx3okBrul2S4M8/9D0scT25N4+yIhPhh9Wb5gv/o00Q7voAZmjyUSK+VRH3sJzmDbhI
         Z2TVI0ckD3vDVd1OxxCxdQNLNQVo4LNr0aj56WU0lOi8vdPEBkZ7MqyYnuDXFL1yFp5e
         nlUe982Hm5jezytp5jLM3INtlhnhygenSI7GbZkb5gERqDdjVld2dGsswKkhhX9JPF7r
         2qGGptvjch4X8VQCJev9oQY78MzKbb+x1BwCLB+KeXizo+GlfDxHL2dDq0GALOPkseE1
         j9OQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=k0BxiokrF/2M0NnlajINaEcvm90VbfOjizpL77vDiIQ=;
        b=jIGU2+CYPikqdlKdgRo8Pwm0JV6tZkJ2BpZ5g9NODjmBbeCt/0huFAkUu/FULVRjyJ
         ROXPrbJLpAY0m0ucgIK8TZfGvPtw38nGkAWuv9Ag1C7lWnVsv/n28rAz/3LV/JA1erZN
         F7ykqje0xhtJVQ4Scnyl/gFY2S7EFl/qo0mXbDwZyqKtHDGk0wqcUZoqKc5DUOHBGGJL
         eoGLrLkCFxkBRqLG1mPsKS4ojFi0F6UXvWyVafFcNaUy/oMfWi1O+Ir/MPvG7oTdNKeJ
         gMdbKM+THSE4j9lIwN4hAUNjkSkbwaAfFshOPcVqz+oaSdm+qf2sjShDWakhHC+FvO+u
         60rg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=rjwDQdVm;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id s13si5646305ejd.436.2020.04.25.16.29.22;
        Sat, 25 Apr 2020 16:29:45 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=rjwDQdVm;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726359AbgDYX2H (ORCPT <rfc822;zjuysxie86@gmail.com>
        + 99 others); Sat, 25 Apr 2020 19:28:07 -0400
Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:5569 "EHLO
        hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726271AbgDYX2H (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 25 Apr 2020 19:28:07 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5ea4c70f0000>; Sat, 25 Apr 2020 16:26:07 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Sat, 25 Apr 2020 16:28:06 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Sat, 25 Apr 2020 16:28:06 -0700
Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 25 Apr
 2020 23:28:06 +0000
Received: from [10.2.165.152] (10.124.1.5) by DRHQMAIL107.nvidia.com
 (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 25 Apr
 2020 23:28:05 +0000
Subject: Re: [RFC PATCH v10 6/9] media: tegra: Add Tegra210 Video input driver
To:     Dmitry Osipenko <digetx@gmail.com>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>, <frankc@nvidia.com>, <hverkuil@xs4all.nl>,
        <sakari.ailus@iki.fi>, <helen.koike@collabora.com>
CC:     <sboyd@kernel.org>, <linux-media@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1587700513-28449-1-git-send-email-skomatineni@nvidia.com>
 <1587700513-28449-7-git-send-email-skomatineni@nvidia.com>
 <fd5300fd-33af-babe-95d0-9669b66a8c06@gmail.com>
 <2983577f-fec9-f24c-0563-6d1f0e1dd5d8@gmail.com>
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
Message-ID: <32e30b7f-865b-282e-5e19-e4c8cf217e63@nvidia.com>
Date:   Sat, 25 Apr 2020 16:27:48 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <2983577f-fec9-f24c-0563-6d1f0e1dd5d8@gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 DRHQMAIL107.nvidia.com (10.27.9.16)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1587857167; bh=k0BxiokrF/2M0NnlajINaEcvm90VbfOjizpL77vDiIQ=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=rjwDQdVmVcSpIMmhzEwFsPUPfI9a9YvIVMIafrnk9wNwv6kaiB7sIE7oyz86FkT+L
         bNkl+s19YYd3LwLcz1GH8EMN4WXxStosZY3xi4bdTJ3NnEH5M5fCZDusxOfvFcps9p
         7bJLaoiphQ3TlvM6CTkEpOI2gqLAaExtORs6GC/F/+BoNqbiHVp8zM/95KTw5i4JDy
         7Jxdx7pXu5U+Pl8vtqdfTPqf7hdCaP0tGCn3Zd4DNSgg0TwlnPaqatbV8OARusPwQ/
         DjoURTC+9M27dn4QsYiU1SGEsIO/uxMUcMY+ByU/NqnG7QZj8BihYxrQpr8PcVa9sv
         tauuUmWdr+FbA==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/25/20 4:25 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 26.04.2020 02:13, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>> 24.04.2020 06:55, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>> +static int __maybe_unused vi_runtime_resume(struct device *dev)
>>> +{
>>> +    struct tegra_vi *vi =3D dev_get_drvdata(dev);
>>> +    int ret;
>>> +
>>> +    ret =3D regulator_enable(vi->vdd);
>>> +    if (ret) {
>>> +            dev_err(dev, "failed to enable VDD supply: %d\n", ret);
>>> +            return ret;
>>> +    }
>>> +
>>> +    ret =3D clk_set_rate(vi->clk, vi->soc->vi_max_clk_hz);
>>> +    if (ret) {
>>> +            dev_err(dev, "failed to set vi clock rate: %d\n", ret);
>>> +            goto disable_vdd;
>>> +    }
>> Isn't setting clock rate using assigned-clocks in a device-tree enough?
>> Could you please clarify why this vi_max_clk_hz is needed?
>>
> In that case it should be wrong to set the clock rate in the RPM
> callback because RPM works asynchronously and RPM may not be suspended
> on TGP -> sensor source switch.

Driver will not do TPG and Sensor switch dynamically.

Based on kconfig, it will only do TPG or Sensor and sensor will be=20
default all the time once sensor support is added in next series.