Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1338852ybz;
        Sat, 25 Apr 2020 16:49:45 -0700 (PDT)
X-Google-Smtp-Source: APiQypLmM30xVY8a1/Ryd3fZamj9AdYHgh82H2RqXRX5HoSb5GbybrWwkSTKtu9UJH3PP7A8s2Kw
X-Received: by 2002:a17:906:359b:: with SMTP id o27mr13691379ejb.282.1587858585536;
        Sat, 25 Apr 2020 16:49:45 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1587858585; cv=none;
        d=google.com; s=arc-20160816;
        b=X0h3u0UKIEP5d3/kXHwOPc7L9QB0ulhc2HI8cAGD+8BanShrHeLH+bPvkj0Lk8Tavk
         81Zvja+F8C9xATCT4Qg11Sfq/PATH9zVlPHpgn8JGmb04fKDem9mzYkq8oxkrwdOc+Yl
         KgfH0XN19E6flNlJrX9UwSJ/l9Cap/lvVDUaSUYENKimYF7mVaLmdtJvH9QR4iekIrKF
         GIf9rBvHQfnNISKCk+gNa33OEzGiS/y97H/CcpGClFiF2osu8Klfj+Qpn7aPHaMoMNNm
         VKFrvrzku6PBoM7R7sOfmsKsRO7NyfnahfMBuikc2x1R4ICYY1R6dlOecds8M2SaLHsf
         aewA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=xJiuZTcLjj9AdrCnXCklkLXIe/2zaVwC0Drp+U1/dAs=;
        b=DV4qfRatGBigR1Y4Y/lM+yoVoV3p/iuu17mYkJY+yffAO5w+MfEy4+oC64RxcHBsdx
         jbj4w7C6igjwVR6iBd70fZ66WlvEflREKYntyYKNDMRq/kBkBESfPqj2ti3Lu+MzXP5p
         oZL/yaCrwy5nzgpHDISDGFSn+ZiOCUIyYnV195EdmZ+XBc3kdrT/nWN1jN752sJ+TZf7
         LmN7BPxaUSgx3dBOpaWWeS7g/wvfCYc2MzfcFAjz5rVmvFeCUSjQ2V5NwZH9+gzXOSqq
         1Ci+GJfcN0/nsx4dvOqEQMeah2fLelGCZS/IYnbNIKz9+nSjAG6tf/JjmHxZFvJQHsOC
         cB7A==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=O3s85kka;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id cm18si5315279edb.130.2020.04.25.16.49.21;
        Sat, 25 Apr 2020 16:49:45 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=O3s85kka;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726108AbgDYXsE (ORCPT <rfc822;zjuysxie86@gmail.com>
        + 99 others); Sat, 25 Apr 2020 19:48:04 -0400
Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:5928 "EHLO
        hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726070AbgDYXsE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 25 Apr 2020 19:48:04 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5ea4cbb90000>; Sat, 25 Apr 2020 16:46:04 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Sat, 25 Apr 2020 16:48:03 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Sat, 25 Apr 2020 16:48:03 -0700
Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL105.nvidia.com
 (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 25 Apr
 2020 23:48:00 +0000
Received: from [10.2.165.152] (10.124.1.5) by DRHQMAIL107.nvidia.com
 (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 25 Apr
 2020 23:47:59 +0000
Subject: Re: [RFC PATCH v10 6/9] media: tegra: Add Tegra210 Video input driver
To:     Dmitry Osipenko <digetx@gmail.com>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>, <frankc@nvidia.com>, <hverkuil@xs4all.nl>,
        <sakari.ailus@iki.fi>, <helen.koike@collabora.com>
CC:     <sboyd@kernel.org>, <linux-media@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1587700513-28449-1-git-send-email-skomatineni@nvidia.com>
 <1587700513-28449-7-git-send-email-skomatineni@nvidia.com>
 <fd5300fd-33af-babe-95d0-9669b66a8c06@gmail.com>
 <2983577f-fec9-f24c-0563-6d1f0e1dd5d8@gmail.com>
 <32e30b7f-865b-282e-5e19-e4c8cf217e63@nvidia.com>
 <3f2916eb-dcd4-58c3-4d45-7f88620d4a83@gmail.com>
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
Message-ID: <cefa2bbb-5d29-1ea8-9c28-b5470a4c9535@nvidia.com>
Date:   Sat, 25 Apr 2020 16:47:42 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <3f2916eb-dcd4-58c3-4d45-7f88620d4a83@gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 DRHQMAIL107.nvidia.com (10.27.9.16)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1587858364; bh=xJiuZTcLjj9AdrCnXCklkLXIe/2zaVwC0Drp+U1/dAs=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=O3s85kkaVzyA0Ax3S90NSp3lCx9TBKPpPUdZn66TMNyL+Qebyxu3Dr9RnOCmZkkFO
         QI/KOdFrOeURJwqX6XghG9aaXVMK1EfOtgLB8M7Nf34LOMVysMsvN65cLPn5kH6UkI
         yFEYnkB1YHrIe3aUMbLx7CQtLPhcwLz4OJpDebhBX8c1uH+JXiTWZRshJAFgXZo/kF
         nj8AidNTawxVen7vHMPVPa9g+2P3OEmB7uOplOQwegPH5AsiF73iLcMFRPzR5bvPVW
         G/Go+YhQOekbpxQ0Xk9KNmN0MrAUjdimQQ3tRQk0bWXyWKMG5SxDhvcHUGdYE2GGih
         Xh0SPe58Ofn2w==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/25/20 4:44 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 26.04.2020 02:27, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>> On 4/25/20 4:25 PM, Dmitry Osipenko wrote:
>>> External email: Use caution opening links or attachments
>>>
>>>
>>> 26.04.2020 02:13, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>>> 24.04.2020 06:55, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>>>> +static int __maybe_unused vi_runtime_resume(struct device *dev)
>>>>> +{
>>>>> +    struct tegra_vi *vi =3D dev_get_drvdata(dev);
>>>>> +    int ret;
>>>>> +
>>>>> +    ret =3D regulator_enable(vi->vdd);
>>>>> +    if (ret) {
>>>>> +            dev_err(dev, "failed to enable VDD supply: %d\n", ret);
>>>>> +            return ret;
>>>>> +    }
>>>>> +
>>>>> +    ret =3D clk_set_rate(vi->clk, vi->soc->vi_max_clk_hz);
>>>>> +    if (ret) {
>>>>> +            dev_err(dev, "failed to set vi clock rate: %d\n", ret);
>>>>> +            goto disable_vdd;
>>>>> +    }
>>>> Isn't setting clock rate using assigned-clocks in a device-tree enough=
?
>>>> Could you please clarify why this vi_max_clk_hz is needed?
>>>>
>>> In that case it should be wrong to set the clock rate in the RPM
>>> callback because RPM works asynchronously and RPM may not be suspended
>>> on TGP -> sensor source switch.
>> Driver will not do TPG and Sensor switch dynamically.
>>
>> Based on kconfig, it will only do TPG or Sensor and sensor will be
>> default all the time once sensor support is added in next series.
>>
> Doesn't V4L have a native support for the capture source selection? Why
> it needs to be a compile-time option?
>
> I think other drivers use a generic V4L "Image Processing Controls" with
> a configurable test_pattern option.

selecting test pattern thru v4l2 controls is once device graph is=20
already set for TPG to choose test pattern modes.

But as internal TPG is b/w CSI and VI only, device graph is diff and for=20
sensor device graph is different.


Based on internal discussion and discussion with Hans, decided to use=20
kconfig for TPG Vs Sensor and TPG is rarely used only to test driver=20
without sensor