Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1362744ybz;
        Sat, 25 Apr 2020 17:26:30 -0700 (PDT)
X-Google-Smtp-Source: APiQypKNGyy6pGTDNWeVcuzO5nE6/cD+TRtlq2rHqWUtDYiCHhSmAgg0QtU5vsvWqMUOgA4kA9y/
X-Received: by 2002:aa7:cdd9:: with SMTP id h25mr13961728edw.17.1587860790239;
        Sat, 25 Apr 2020 17:26:30 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1587860790; cv=none;
        d=google.com; s=arc-20160816;
        b=CyeJ46TOroThCvcXyzCcWDAUDFRH6+95rOVmiBAo7WXtNRFcMFvNIp0Fop+FCrvzJB
         xTMPVHFddaiznfnKOv+6fFng3/bvtg4PqYfYjUwZGP5ICT4WbAmJJK8zkn4m3na5NQAI
         Fss4dTyFAZnLFj84EGJrd1XcqSrnnpPPKWFwuHN8Xkz9s7pRlBuAkatV/dzzv8UHbmVZ
         JSvTWXOOd7TreTPBIN7MCGpbM8V0OViD9f8NAkqKZCOno1TL+yeBFIpj/cJrY4EypO0v
         9d56L6QaL/ejljI6SdAb7mygOBBg/zA62ESQ/QmdueQW9G01m2D7ZdNGt4aqW7/sXHA8
         HBZw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=hb53MB8otx0fgIwAwPT0XxRe4kRtoWZiaHC1vuSyd1Y=;
        b=YDsWzUCE8mDT4cmZ+OmM2s8X2+gDkiU8a2lTNW/xYktpxTOqU8hVyE1QjqBzD0mVGs
         +I4W6LoCdUxg39vZpbdPC8gLi+rWnYY6Uvajnis9Vi8xVOc9Y63O/A9+4fQIJH2+Nftb
         QI7hb5AONWa8m8ZiyDU3OVJ6ZLI91DKRYtU2qlfev+CgZvkBFotnxri0cbMylrNDuBfS
         msGaiMO2ctWCYaF7Lm90bxqVrCeHSfvAMSmDDInaaZEKaagK1icbo0P+Y+IdB7g7Rg56
         cWVCVGZzA/eUeuuckYvKLxcT1O2Odhrnd9Ve9+mHa13JPD6yVRRMQsZOD9KfuaIiu5Av
         k9hw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=WwVtLuFR;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id e16si5504461eds.503.2020.04.25.17.26.06;
        Sat, 25 Apr 2020 17:26:30 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=WwVtLuFR;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726126AbgDZAYs (ORCPT <rfc822;zjuysxie86@gmail.com>
        + 99 others); Sat, 25 Apr 2020 20:24:48 -0400
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:4126 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726070AbgDZAYr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 25 Apr 2020 20:24:47 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5ea4d4c20000>; Sat, 25 Apr 2020 17:24:34 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Sat, 25 Apr 2020 17:24:47 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Sat, 25 Apr 2020 17:24:47 -0700
Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL111.nvidia.com
 (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 26 Apr
 2020 00:24:46 +0000
Received: from [10.2.165.152] (10.124.1.5) by DRHQMAIL107.nvidia.com
 (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 26 Apr
 2020 00:24:45 +0000
Subject: Re: [RFC PATCH v10 6/9] media: tegra: Add Tegra210 Video input driver
To:     Dmitry Osipenko <digetx@gmail.com>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>, <frankc@nvidia.com>, <hverkuil@xs4all.nl>,
        <sakari.ailus@iki.fi>, <helen.koike@collabora.com>
CC:     <sboyd@kernel.org>, <linux-media@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1587700513-28449-1-git-send-email-skomatineni@nvidia.com>
 <1587700513-28449-7-git-send-email-skomatineni@nvidia.com>
 <3155e0d2-94b0-6e0a-bf35-b3560c201039@gmail.com>
 <fffc09d1-a25f-2d6e-83bd-f7657dd2ff16@nvidia.com>
 <e5602c48-a73e-8e71-188d-6a53ebf8e4a4@gmail.com>
 <f6d62dde-9ab5-7001-0ff4-93ed70cb207f@nvidia.com>
 <6568af00-3d65-4ddb-f003-7a4161d751a0@gmail.com>
 <f3a122b9-3600-b1eb-be4f-39be79d979a5@nvidia.com>
 <5a6f61c6-2049-fb61-3a80-e729708b3fb8@gmail.com>
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
Message-ID: <94d6d159-950a-ee78-05a2-c37fb8fb9873@nvidia.com>
Date:   Sat, 25 Apr 2020 17:24:28 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <5a6f61c6-2049-fb61-3a80-e729708b3fb8@gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 DRHQMAIL107.nvidia.com (10.27.9.16)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1587860674; bh=hb53MB8otx0fgIwAwPT0XxRe4kRtoWZiaHC1vuSyd1Y=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=WwVtLuFRIaUN9TOqgp156qFxIqiROwu+5FBT3XXYfQ96kVxvwcs8LpXTXqIvEKVIY
         iXD/sQFsA0O+TyR8azb0OGo+klXxftPf4XNgBDIovY416GQSeY22rIKN5riJBZ7ZCS
         QJam55oiShxaQyGNF0J2DihQYXCUFxqYEpdwxxdXdV6zPrgB9UQgWiF4HVGf7fwm0R
         373DGsnUj33v7Hz5SeFIZNAAKXXWtcGLflGw67nLgu2XTktIslC4BL9odx/DEmbBuz
         /AplL9HJATkFzMFyF3cJqMyHMs+LcBnKlUXXMRVo6wHLDI6G+Ptw1joI4goLoHewo5
         rLIAoKpbaXSZw==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/25/20 5:19 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 26.04.2020 02:44, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> ...
>>> How much of the T210 code could be reused by T186/194?
>> vi/csi are common driver where soc structure should be populated for
>> T186/T194
>>
>> Tegra210.c can't be reused for Tegra186/t194 as programming seq is a
>> whole lot diff
>>
> How are you going to separate Tegra210/186/194 drivers from each other?
> I don't think you'll want to have one "fat" driver that covers all those
> SoCs, won't you?
>
> In the end it should be three modules: tegra210-video.ko
> tegra186-video.ko tegra194-video.ko.
>
> Using a per-SoC OPS doesn't allow you to do that because the "root"
> driver will have to lookup OPS' code symbols of every SoC, and thus, the
> unwanted driver modules will get auto-loaded if you'll try to factor out
> the OPS into a separate driver modules.

tegra-video driver will be common for t210/186/194

we add corresponding compatibles to tegra-video and vi/csi drivers along=20
with that need to add tegra186_vi_soc, tegra194_vi_soc and implement=20
tegra186.c/tegra194.c

tegra-video driver updated for later tegra include updating drivers list=20
and subdevs list to add t186/t194 compatibles