Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1367546ybz; Sat, 25 Apr 2020 17:34:03 -0700 (PDT) X-Google-Smtp-Source: APiQypIymxOqtMKW+97L3RfdDK9CiFICH+ImQiLfDqTVe3X4K3Pydsut0TGGvQs7DfYaDIHB7NVX X-Received: by 2002:a17:906:bfc9:: with SMTP id us9mr12790129ejb.84.1587861243210; Sat, 25 Apr 2020 17:34:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587861243; cv=none; d=google.com; s=arc-20160816; b=qNWdozbk5aBiPgGAV7pSzv7Rlb3xPBfqBiXH7Mb+UKn/rK+pbg+lJhweMNehZi4UMp pyTbh7i5JXMlC4Y13o+eCW/fJVW1aCyIdOw5KXM8AI0e5jV2/Ug/rNqSKa6F2K8MoljV iWuC2g02LXfLtWeMT5lQmTLRZJHgwu6l2e6HIeEb/FtMcW4GCU2vPpAhtsLnFoKPhoVS cqrB8lW0Hu9odBhS1GqJTOgmmvsd3aX7PRKPQmVIvM9LYZXD1GW1j9Gmd2BjMwdtogyb Q4UnoS0ygF0ob5ymFGgSn+IzZA7n3Wcs20+Zph7XYf5YwdSbKCmQkaVAxV97dVPwsz2o rNJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:in-reply-to :subject:cc:to:from:date; bh=MVTUIqEhMHlWLP3V3pQad5b5VmRthZdrHsOjTlurGfk=; b=lOX5ynYX+4P2awT6skIVQspUixfEvoCg5pjPIXkn9dN0kXM2fL5/96R4zRHyeU31xA GiFDYBF9qfpRujAqCQLlY5FneNY3YRwfw1GsZVKlMUSptjyZMwK11vtTBtERPFDq3AXJ kxvGAkABts5CeQIxYgy99hgf4JL5AHcyrE5XHVOJ7sILSMWrqkRorfjlvDuSHdHPFymN 6XiHx4YT2hJbVpOAX1qSZ58ABlE0rLZ+4TwPe88D1FyO+wTHGh8+laseoBSu4MxKsgS7 plHYdhpLLNasAx3HhOoq6Jm5TpDL1SzI6nHCANtNkYFeLkEScn7/hnLn7LEwdDsQSmaN J/zA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b1si5961897edh.318.2020.04.25.17.33.38; Sat, 25 Apr 2020 17:34:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726108AbgDZAcL (ORCPT + 99 others); Sat, 25 Apr 2020 20:32:11 -0400 Received: from netrider.rowland.org ([192.131.102.5]:36577 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1725962AbgDZAcL (ORCPT ); Sat, 25 Apr 2020 20:32:11 -0400 Received: (qmail 14241 invoked by uid 500); 25 Apr 2020 20:32:10 -0400 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 25 Apr 2020 20:32:10 -0400 Date: Sat, 25 Apr 2020 20:32:09 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: vladimir.stankovic@displaylink.com cc: gregkh@linuxfoundation.org, , , Subject: Re: [PATCH v5 5/8] usb: mausb_host: Introduce PAL processing In-Reply-To: <20200425091954.1610-6-vladimir.stankovic@displaylink.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 25 Apr 2020 vladimir.stankovic@displaylink.com wrote: > Protocol adaptation layer (PAL) implementation has been added to > introduce MA-USB structures and logic. > > Signed-off-by: Vladimir Stankovic ... > + /* > + * Masking URB_SHORT_NOT_OK flag as SCSI driver is adding it where it > + * should not, so it is breaking the USB drive on the linux > + */ > + urb->transfer_flags &= ~URB_SHORT_NOT_OK; Removing the SHORT_NOT_OK flag is _not_ a valid thing to do. It will cause drivers to malfunction. Can you please explain this comment? What SCSI driver? When is the flag being added? How does it break USB drives? Why haven't you already reported this problem to the appropriate maintainers? Alan Stern