Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1387805ybz;
        Sat, 25 Apr 2020 18:06:02 -0700 (PDT)
X-Google-Smtp-Source: APiQypLZH6VbSzoVoBtXELtD8DgsDQ7QBlH60Wqj/M3JrR70CQiPem5PuP8jlxfwHixADuOsMK/I
X-Received: by 2002:aa7:d4c3:: with SMTP id t3mr13151539edr.191.1587863161922;
        Sat, 25 Apr 2020 18:06:01 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1587863161; cv=none;
        d=google.com; s=arc-20160816;
        b=LkOGYyN8uYdtnbFtv1exx9scn4QeYp+ACQtzSxVfVm81LrzeZyQ58KdOVqvhsx1Yvl
         0eDMwyEzWXGRd1RRUDQTMYRmivV0J+/kCagymidu4Wy+bcaE36U0yPHCB4fuTkkKMWa/
         8sVuQIHsfQMKorJxElNcfv7gj1bH6/H9VprBzaJ+G1Jlv3mheussWTEsHGUniD06R1O3
         IXrYuoMJCkhP3m9GBZIj6SYeRLfNTp1feToxoyu21aItS93e5ikiOwgRulfmeQCCox8K
         jNydBFLCfewt0BpEvJt8e1VveA0qnujrBb6DfcaoxiuGdXxMkBrAks3DIM1hzsDECH7u
         He8g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=VNhJYVm5RUzNojdXqak0dh5Q/KOm805oU3Sr5ZNtA84=;
        b=bFOAhToLFtxAIZwhyq7Hwm5PBD2qR+iXY2OKohm7IppBP6gAKvuVgbfnPXnBd2wESR
         As1AD9QQz7skUmSMeFKtE6QUE38Z0+p6omsJvJCAOgC117Ayh6aCxLZKkiIS6Izb4V43
         Atwk1jrgNsG/QwoQDx72IP4EdhV6MQzWSKFP5qT5gOHhQiSGeHMz04Fki16U7m6RH055
         kx0Gsn5EFyhF9wcutaFLf+dgh5/NqD0TEL5l6FOflUfsbWMyQuUKYU8JfxzPygQF4cX4
         h7HCsYoM0PKQxLQBh5YbywteXKwCobDSGfX3l98ydmbvixQaVMt44/KxMNmQpmyL1Uvt
         kOvA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=jPdl+CRu;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id ga21si5692152ejb.350.2020.04.25.18.05.38;
        Sat, 25 Apr 2020 18:06:01 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=jPdl+CRu;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726116AbgDZBEV (ORCPT <rfc822;zjuysxie86@gmail.com>
        + 99 others); Sat, 25 Apr 2020 21:04:21 -0400
Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:7250 "EHLO
        hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725962AbgDZBEU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 25 Apr 2020 21:04:20 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5ea4dd9d0000>; Sat, 25 Apr 2020 18:02:21 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Sat, 25 Apr 2020 18:04:20 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Sat, 25 Apr 2020 18:04:20 -0700
Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 26 Apr
 2020 01:04:20 +0000
Received: from [10.2.165.152] (10.124.1.5) by DRHQMAIL107.nvidia.com
 (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 26 Apr
 2020 01:04:18 +0000
Subject: Re: [RFC PATCH v10 6/9] media: tegra: Add Tegra210 Video input driver
To:     Dmitry Osipenko <digetx@gmail.com>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>, <frankc@nvidia.com>, <hverkuil@xs4all.nl>,
        <sakari.ailus@iki.fi>, <helen.koike@collabora.com>
CC:     <sboyd@kernel.org>, <linux-media@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1587700513-28449-1-git-send-email-skomatineni@nvidia.com>
 <1587700513-28449-7-git-send-email-skomatineni@nvidia.com>
 <ae7a4614-c84c-f5dd-d0a5-4090e1bf5a9d@gmail.com>
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
Message-ID: <64b636af-a63f-6c5e-5d66-d481f79660c2@nvidia.com>
Date:   Sat, 25 Apr 2020 18:04:00 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <ae7a4614-c84c-f5dd-d0a5-4090e1bf5a9d@gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 DRHQMAIL107.nvidia.com (10.27.9.16)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1587862941; bh=VNhJYVm5RUzNojdXqak0dh5Q/KOm805oU3Sr5ZNtA84=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=jPdl+CRuVcIeXZS/MqiiI4UTmP+6IjnTImWyG/16xb1vlvT5DKf/ozaBMy0x17ckL
         kyh7dPa83EoerauLJQhVsAlRhp45f7grmF8rK3yOzwht4Q8+gY9vXvEUs2xESinbij
         C7gbhw90U/F+UL/TtR8ZlBjCI7pR3hXSg+6epTz7SoWhu8pgSvvGB8qHWV59Ie2OFO
         p/GxyywN+V6OlIJ8DdDU7GjRfChkBJetq1h4hYVvQJx994hkv4MsEO/4gY7GB5sS+U
         r1GjIFrTCfrOMTW9KBuUAGlUF0xhtIZbA0N7mOZX+xr9s/4UBX9oMzFFlbWqX0+xVU
         CokQhhT5bwgfQ==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/25/20 4:29 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 24.04.2020 06:55, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>> +static int tegra_csi_init(struct host1x_client *client)
>> +{
>> +     struct tegra_csi *csi =3D host1x_client_to_csi(client);
>> +     struct tegra_video_device *vid =3D dev_get_drvdata(client->host);
>> +     int ret;
>> +
>> +     INIT_LIST_HEAD(&csi->csi_chans);
>> +
>> +     ret =3D pm_runtime_get_sync(csi->dev);
>> +     if (ret < 0) {
>> +             dev_err(csi->dev, "failed to get runtime PM: %d\n", ret);
>> +             pm_runtime_put_noidle(csi->dev);
>> +             return ret;
>> +     }
> The whole point of RPM is to keep hardware enabled only when needed,
> i.e. during of the capture process in this case. You should move all RPM
> handling to the capture start / stop functions.
Will move it to handle during stream start/stop