Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1389104ybz; Sat, 25 Apr 2020 18:07:54 -0700 (PDT) X-Google-Smtp-Source: APiQypIG3Bq6bk8BBlDY3Oq3+/Wyl0yWo8Xe7qrXL/z2wPWHjK2eg2ePH4AgEqngjyrE5PqNjMV+ X-Received: by 2002:a17:906:2458:: with SMTP id a24mr13371758ejb.239.1587863274551; Sat, 25 Apr 2020 18:07:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587863274; cv=none; d=google.com; s=arc-20160816; b=M4uRylp2Ze56T2qqKIHJOtEcpVe1cbOqZSQ49ko3wPdfuhvEtcCGlkz46bCf+SRb5k K7S9ceYSir7NKvd/nWuO6O4N+J2QiaIxt6HR9fQOl1y67qqcVA9RzOhdrL13+gM2Srnu NRtCG8VRmKrQkRMCVeIFKKgIsi5ctKA6VorC3hJteMYDsF0/1eSUsUz2BZnjilZvFsBv Q5V2TgrROFdtVpCkZw20SA8PIHQHD5sVeZfzn/0+EOeek+VjfaI9hLiAUjibRQ+OoGEO fQC53+m8DOdJHCUnqQYu+8tYypcLNUEJ58E7IQDXXqDWeqW5CYlyZtvbmgXqfI6ee4jb aFzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=uKOtKNaS2MVqBJSkNeVOBAfIRWocy7ki1LICFqTWWaE=; b=LUj0riS3nWYDOUkdVfETs2W0lmb2Cg8vPqONRgOa2/vaCp8ZQLd+Sg5AsMKjFq3jIl cqqEEAga76DIgUCWHAl3pWA/o8EuVa/h/BNzxbKKYYFBSlO7qNqLIkYKnkaQh7aQ2Cqq qxP6V45mk0mc+ldfLCykQHQmB8+JmISmealG3zHO4DEmO3jEVDp0/+5dwHGSb6ZW+RFz HUG2TuHYBhtG3MFovyJ+mKtwgG116Zbc5jS5HzcRd2qn6kVfwEAeufzK1+cB2PnT1GaS 8/fSg3vEdyvMwcPe7C/D+bplQRuwde/jNuN73ENmeyYJByP8gAlNFARm73nLHGqAmsDx KJ2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xyssavs7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jt10si5878519ejb.446.2020.04.25.18.07.31; Sat, 25 Apr 2020 18:07:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xyssavs7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726128AbgDZBFi (ORCPT + 99 others); Sat, 25 Apr 2020 21:05:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:40764 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725962AbgDZBFi (ORCPT ); Sat, 25 Apr 2020 21:05:38 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9BEDC206DD; Sun, 26 Apr 2020 01:05:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587863138; bh=TW9WOI1NaKEA7K+nsipDf0IuvMnVChZsi71PeMPMFD0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=xyssavs7qBvNOpyHvBtiegJkq8Wqg9HwnL8VSZPm/f8KpEORw/jy4AReSAPnbTyaS c0Cw8kBn/g+AbZeu0VCV07nAEV8i657DrVx4QfURgeCFg0zIN8wLlvc0ertQQb0mih zxkGvbWu7NndBLJ4agHVO4dFK7txamla8RvIHWDs= Date: Sat, 25 Apr 2020 18:05:37 -0700 From: Andrew Morton To: Zong Li Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, linux-riscv@lists.infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/4] riscv: support DEBUG_WX Message-Id: <20200425180537.063e976b232f8771e22f7ee1@linux-foundation.org> In-Reply-To: <282e266311bced080bc6f7c255b92f87c1eb65d6.1587455584.git.zong.li@sifive.com> References: <282e266311bced080bc6f7c255b92f87c1eb65d6.1587455584.git.zong.li@sifive.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Apr 2020 16:17:13 +0800 Zong Li wrote: > Support DEBUG_WX to check whether there are mapping with write and > execute permission at the same time. > > --- a/arch/riscv/include/asm/ptdump.h > +++ b/arch/riscv/include/asm/ptdump.h > @@ -8,4 +8,10 @@ > > void ptdump_check_wx(void); > > +#ifdef CONFIG_DEBUG_WX > +#define debug_checkwx() ptdump_check_wx() > +#else > +#define debug_checkwx() do { } while (0) > +#endif > + > #endif /* _ASM_RISCV_PTDUMP_H */ It's preferred to implement things in regular C, unless they MUST be implemented in the preprocessor. So... --- a/arch/riscv/include/asm/ptdump.h~riscv-support-debug_wx-fix +++ a/arch/riscv/include/asm/ptdump.h @@ -9,9 +9,14 @@ void ptdump_check_wx(void); #ifdef CONFIG_DEBUG_WX -#define debug_checkwx() ptdump_check_wx() +static inline void debug_checkwx(void) +{ + ptdump_check_wx(); +} #else -#define debug_checkwx() do { } while (0) +static inline void debug_checkwx(void) +{ +} #endif #endif /* _ASM_RISCV_PTDUMP_H */ _