Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1481993ybz; Sat, 25 Apr 2020 20:43:52 -0700 (PDT) X-Google-Smtp-Source: APiQypKA+1mCTUsxHVi08Half4K7jEjzv49NNp2kt4C2AN51azu6IqDmwZX5mhcrmiM4wnRHL4jD X-Received: by 2002:a17:906:68d7:: with SMTP id y23mr14508530ejr.85.1587872632532; Sat, 25 Apr 2020 20:43:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587872632; cv=none; d=google.com; s=arc-20160816; b=vJPHoqF4stQMw3zSFai7WyFKRjSWfx/JH/jWH6dVRy4X2NU6xN/ornUFx8PkTnXciG ritF7PlG6prg3UsbmXJgkE3ab58nHo29TzRMQqzW/odtljmp61038Dhz8/LV6YihgLHB fWZi3VRz3hEDKA++565E9hjkigsP9kdCPMMwUeQcqO2ajd260XHzWLSil900RbmOkZo6 FVWgI5+kdffkYZyM5wKp9BD8nALJVDLih7EUCmzNJcoY1pQaaFOBcr0Btde+E99ILMTy AVelX9N6Ln0kH96eLm/9KFu+yGQDCk4uDSKXw3JNoNlO5Dwi7IbTVALShv9dGdGD+5Ov rDAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=oMNr4WsUgRHHxMI3fNaZ+ftB+cZVekeS9loCoPV7zwg=; b=M4CDk6OfWIkCAF0N4Zrl9oXsnVlvKE5Oy3874IfjADfIYjMVoOaK4bvWGKLkoD8bNy VIZVas9PQAEc1l114rW+u8Hac+h1lfTJv7CaqCWPv67gMnLdCeGHTTYnCVc96JYzlsjl K+7aTMTYv4Y7FuKt9e3leCv0vkQ44XWsXhiX9JfOW9fjQWw5/4BhGUoUcUCv4h8GDZwy wiuyPD4Wp3Lp8VNB/qGK3PazejPwOmp09xZDeidShzKvEImdB5MW/315spnquvSYFfNx +vP97acRTiZA1BcWAmDTygpLjFkCIUIX/uuSn6Wiwqrhvq1B1bcHVBIAY+uaL9ZoATPG wXKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m18si5981489eja.298.2020.04.25.20.43.28; Sat, 25 Apr 2020 20:43:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726196AbgDZDmA (ORCPT + 99 others); Sat, 25 Apr 2020 23:42:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbgDZDl7 (ORCPT ); Sat, 25 Apr 2020 23:41:59 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE412C061A0C; Sat, 25 Apr 2020 20:41:59 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 736D5159FD9F4; Sat, 25 Apr 2020 20:41:59 -0700 (PDT) Date: Sat, 25 Apr 2020 20:41:58 -0700 (PDT) Message-Id: <20200425.204158.1357076098544552662.davem@davemloft.net> To: yangyingliang@huawei.com Cc: richardcochran@gmail.com, vincent.cheng.xh@renesas.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] ptp: clockmatrix: remove unnecessary comparison From: David Miller In-Reply-To: <1587732746-98057-1-git-send-email-yangyingliang@huawei.com> References: <1587732746-98057-1-git-send-email-yangyingliang@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 25 Apr 2020 20:41:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang Date: Fri, 24 Apr 2020 20:52:26 +0800 > The type of loaddr is u8 which is always '<=' 0xff, so the > loaddr <= 0xff is always true, we can remove this comparison. > > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang Applied.