Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1617909ybz; Sun, 26 Apr 2020 00:20:47 -0700 (PDT) X-Google-Smtp-Source: APiQypJ8/y//XXzeScp5Ra3JCZkj6xNxVJcSUS4k44MQ5cNCDoBkC8U3FzvgYWuWvxgJ4nO2OYLk X-Received: by 2002:a17:906:16ce:: with SMTP id t14mr14751805ejd.366.1587885647304; Sun, 26 Apr 2020 00:20:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587885647; cv=none; d=google.com; s=arc-20160816; b=oDMjczVgrdkE7q6opqfGnHdGwhZU+DmH9GEXOGda4M2d0QsH4G8ciKoynoN3Qx2y5P vR28udfkfxJK2NdTpd39Bo4Qibq5i7XqHrsTB0gbom8oxD0muEYp6NJdkJNLfz7Y+XjU 1isBq3fvjMlhU8jTvSo9trFNRO2VeOHFvWZEs3MRhh8iRUwax1V/jVQEpJIL2mL7Kwip Ng7TwaoC0vKe4fpz8RQq8efIxwz9vFx28XN36IBU5i7GxtdZBxANPf0s5xOmqoY8f/xu z9OlZ0SJ7gr9hbpnk/KrJmp+6CT4TvXl1uG/Q5oVC1eDL6Odsxl1d9qelWzbbbnFnqP3 eXnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=gVV5b9PP8/2lQ3gQpFCXt1Bgf0mJTR3lYv79NGJAEks=; b=O4mI9DrCQxMN1zwv3pTkeGHjBxUQe/wP01LYFfl2TtaueN+nqyenfPwEvf7sZpEfnp koMC74v7hutMf70M6f4lwRmU2X2Lh8hm3pQMBk5U9/cj7dziv3wKGK/UGNn/gRZBf+RY Qf2GFctoym846ksrALjqdbSf5xGy0K5+upMkQ5aCd5Pt8uvWvhMQ5ixXS/SIT/v7IuCL f4UJVlfzsynUVZlaYQPae5vDa+pCWVgT/V3b7fv2KIPvc50SXw7UxGUBcTHprELZRxW/ 7i7TrqVjpXb2eilEJ7iIvb9UADujJz0/6uXsbTIvv19ndaSNGvowMmYyQHHYTAjhxDhb BZHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=MlR328Hh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z21si5910068edq.21.2020.04.26.00.20.23; Sun, 26 Apr 2020 00:20:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=MlR328Hh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726462AbgDZHSD (ORCPT + 99 others); Sun, 26 Apr 2020 03:18:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726315AbgDZHR2 (ORCPT ); Sun, 26 Apr 2020 03:17:28 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12275C061A0C; Sun, 26 Apr 2020 00:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gVV5b9PP8/2lQ3gQpFCXt1Bgf0mJTR3lYv79NGJAEks=; b=MlR328Hh4px4NzcShXKyCi53gu O9zE7xglbKdVix8zGmxRGFZubjftjlfEH43fv+SOSTvhKsRsnzkymORnknX3aqRIjr54ld6uT/sFw rhgoBEYrEDJpqXWUND4aUYkEiB2ptKr31uvh23RMt4StQn26VizPpazlG71bp/Eexr7A1+dDs1iRM O0RF3poc9iqFCa1rkkwpq99FACQdTYQsq005u1wommGC5DfZyg4tvvM6Pur7qEf+1V/NRnra5X17+ 9iPz+fSP3sv2xC8qXnu/wKRor1YOTI86OwZ92QA1um75xqEvLoP6r3HAWqe+CMUB5jFZUMeaxClYc 5f0Xq0mw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSbXP-0000Io-H8; Sun, 26 Apr 2020 07:17:15 +0000 Date: Sun, 26 Apr 2020 00:17:15 -0700 From: Christoph Hellwig To: ira.weiny@intel.com Cc: linux-kernel@vger.kernel.org, Andrew Morton , Dan Williams , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Chris Zankel , Max Filippov , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org Subject: Re: [PATCH 2/5] arch/kmap: Remove redundant arch specific kmaps Message-ID: <20200426071715.GA22024@infradead.org> References: <20200426055406.134198-1-ira.weiny@intel.com> <20200426055406.134198-3-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200426055406.134198-3-ira.weiny@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 25, 2020 at 10:54:03PM -0700, ira.weiny@intel.com wrote: > From: Ira Weiny > > The kmap code for all the architectures is almost 100% identical. > > Lift the common code to the core. Use ARCH_HAS_KMAP to indicate if an > arch needs a special kmap. Can you add a kmap_flush_tlb hook that csky and mips define, and the just entirely consolidate the code instead?