Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1622345ybz; Sun, 26 Apr 2020 00:27:36 -0700 (PDT) X-Google-Smtp-Source: APiQypIMqxIwWO6OV/CpiyLCxKj95Fueh5hO5ixSuEKWadOrWon/tMYpaNM9JD6V9tpNBznT7MRU X-Received: by 2002:aa7:db0b:: with SMTP id t11mr13299893eds.304.1587886056081; Sun, 26 Apr 2020 00:27:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587886056; cv=none; d=google.com; s=arc-20160816; b=jq/fBE0YXSwa0bjMDI4W73iBdUYBbz/BWZHpwspYoZVdaBisJ43LjDDGBd7TqgJuPl d2wCzbDHKCpsSDozbtcBx26UXm3vsLIrsqYOLqo+6xPS7eBW3REcV1gpR793qeo8gBGe LjMVvK+sAYWJvZ4Kmdt3bs5bIjTxlN24iEjvmYIF3c7B+eCz8aVAQNq/Mzstj0+YYhG6 VKYOKJFgRbsgB9x2E+0X4VpOzpZRFHX2yPjb5qvOlZ03x4v9WA4yd1DrGBlaF8nfeqVg CgxoLIjWoKvvLbbZOucpGcUSkTBqR7oeZzjfz/p3GhjIdUeRC1a9V7FZWxGJAdX2ZnJb dXVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=UX3AdXQHlea5bwFa5+UBA4Pn4ozpIJeECuUTYfpNqh4=; b=CpN6FYwNgZTLe2tA5koAlLm3lM+06FNf1PJf8OAcKopjbTMS1smOjCwTYvRCoIbEHb KdNTqPxZpztEPfCGQ0lEPwVso84E9qx4/Q/qHgFwaFIt9AEAg16NxK0t7vJYyuY8XwAP sWrYcO0ZcdeM/wGrWGgJY0Nu5DJP+fXStpTg0lFQ4AEnAZILCGXP0YOqdtiAF7jVkTgA lD7MPRh9jTBUuNKq1Vh5q2IA4k7B28JV7KEghAXD1ctyou7NQszFPRNR2NE86pMmR4DN PHkTPBXl9AIRd2LjqTGwfYUZBhZmQLJieyoviXI7Q5PxGTFS0DiG26lzmtnihAbsRFgQ ILew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qXrgwMg0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q9si5943817edn.501.2020.04.26.00.27.13; Sun, 26 Apr 2020 00:27:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qXrgwMg0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726216AbgDZHBW (ORCPT + 99 others); Sun, 26 Apr 2020 03:01:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:57294 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726179AbgDZHBW (ORCPT ); Sun, 26 Apr 2020 03:01:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E6DBD20700; Sun, 26 Apr 2020 07:01:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587884481; bh=gDlxekB/2N2vqpIddLrHidD79tcnpmMBQVDOhy4Z6BU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qXrgwMg0f9dUvourwVLSx7FE5mTQiqT6tSylKLvlVlbe3ywGngs9gaWmn7i+THwzG tWgN29BdSYwtnemcyLmKIQcIU7ZQ3xfSYvWe9bUCL2ARAWHtzrlf6y1JVdcTICEmgA qfhGACT4iidV7YzOU/OVTh6kMtavESsiZ7k7cinE= Date: Sun, 26 Apr 2020 09:01:18 +0200 From: Greg KH To: Dave Jiang Cc: vkoul@kernel.org, megha.dey@linux.intel.com, maz@kernel.org, bhelgaas@google.com, rafael@kernel.org, tglx@linutronix.de, hpa@zytor.com, alex.williamson@redhat.com, jacob.jun.pan@intel.com, ashok.raj@intel.com, jgg@mellanox.com, yi.l.liu@intel.com, baolu.lu@intel.com, kevin.tian@intel.com, sanjay.k.kumar@intel.com, tony.luck@intel.com, jing.lin@intel.com, dan.j.williams@intel.com, kwankhede@nvidia.com, eric.auger@redhat.com, parav@mellanox.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH RFC 01/15] drivers/base: Introduce platform_msi_ops Message-ID: <20200426070118.GA2083720@kroah.com> References: <158751095889.36773.6009825070990637468.stgit@djiang5-desk3.ch.intel.com> <158751203294.36773.11436842117908325764.stgit@djiang5-desk3.ch.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <158751203294.36773.11436842117908325764.stgit@djiang5-desk3.ch.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 21, 2020 at 04:33:53PM -0700, Dave Jiang wrote: > From: Megha Dey > > This is a preparatory patch to introduce Interrupt Message Store (IMS). > > Until now, platform-msi.c provided a generic way to handle non-PCI MSI > interrupts. Platform-msi uses its parent chip's mask/unmask routines > and only provides a way to write the message in the generating device. > > Newly creeping non-PCI complaint MSI-like interrupts (Intel's IMS for > instance) might need to provide a device specific mask and unmask callback > as well, apart from the write function. > > Hence, introduce a new structure platform_msi_ops, which would provide > device specific write function as well as other device specific callbacks > (mask/unmask). > > Signed-off-by: Megha Dey As this is not following the Intel-specific rules for sending me new code, I am just deleting it all from my inbox. Please follow the rules you all have been given, they are specific and there for a reason. And in looking at this code, those rules are not going away any time soon. greg k-h