Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1631500ybz; Sun, 26 Apr 2020 00:40:36 -0700 (PDT) X-Google-Smtp-Source: APiQypIbCCB50iOVp1BhF6jc5/hDXW4MUyRdnY5nAxepRwcc3ZNlHfSSRV96jNYkOkufkCteNiwg X-Received: by 2002:a17:906:a857:: with SMTP id dx23mr14819846ejb.52.1587886836139; Sun, 26 Apr 2020 00:40:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587886836; cv=none; d=google.com; s=arc-20160816; b=NYdzJJeAi4v7i8MQ0IUU3AcQdlETARkHD0KKtm0qW7TUp4+AtFMZg/UzuJPi4ZTHs0 w0nqa+M+zuc2ZIK7NWcGTGdAAwBkmOz3ZUeffgivFxglvCG2m/hOUE94YCeF1Fc7Vvg9 VVMrXtyl0lwUBQ+QT3905noZFLzgg9D9hJmcO/f3ndtxYjmbx7zjtUxCaildofdDDVOX wtolxcYSzfSLkzgGcsjexFpV+s7G0Qo3SeMOp9mYd76htq6WAlnz2GnM8drSpzvYlH6c t31HoLA6ujeXn8ZrkGBi7l2r8hI2uAzSFqjoT/4oNCvawGSvJSW8KeVhf2RqgT/jKHuz YkQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=qZWK5jsgUGuEBkWMaNbtRLW4deqZp8vXhvwCXWJ1Pps=; b=hTg2X2YlXMHyHNhzFlR/fI6MQO/oeGFUEFRyqTIMxESDvs1JIpyGY6HmdZI0TGptPp oXJKePL7dlvr3V8KaOd/6eK40YqMq1k+839cTC3NIDsB/Qa5hlw9Z1Qjkuxl1DfLxBG+ HLowTBhUYDdan4tz2BvNvy2ncwg8OdocOq4cTnUxzLzglHRGvQ6Rgipm9LjSCDr50ggO +YV23AMjl609ZUxV/9UWaymJzvaGndV3JmTF2ECAnYYdBLbmIcbPwXMcBVI9uaCzVxhM 2wXWIE5NdZwoH4sILDmxQ2zJW1RES+HDIG6JhhKt/A5CEMnMqACHxdKrvoTAwZ6wOX7M EqGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y15si5990682edv.297.2020.04.26.00.40.12; Sun, 26 Apr 2020 00:40:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726163AbgDZHiS (ORCPT + 99 others); Sun, 26 Apr 2020 03:38:18 -0400 Received: from mx0a-00128a01.pphosted.com ([148.163.135.77]:65472 "EHLO mx0a-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726132AbgDZHiR (ORCPT ); Sun, 26 Apr 2020 03:38:17 -0400 Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03Q7b5II003593; Sun, 26 Apr 2020 03:38:04 -0400 Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com with ESMTP id 30mj452m9s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 26 Apr 2020 03:38:03 -0400 Received: from ASHBMBX8.ad.analog.com (ashbmbx8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 03Q7c2iQ028383 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=FAIL); Sun, 26 Apr 2020 03:38:02 -0400 Received: from ASHBCASHYB5.ad.analog.com (10.64.17.133) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Sun, 26 Apr 2020 03:37:55 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB5.ad.analog.com (10.64.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Sun, 26 Apr 2020 03:37:54 -0400 Received: from zeus.spd.analog.com (10.64.82.11) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.1.1779.2 via Frontend Transport; Sun, 26 Apr 2020 03:37:54 -0400 Received: from localhost.localdomain ([10.48.65.12]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 03Q7bqds011885; Sun, 26 Apr 2020 03:37:52 -0400 From: Alexandru Ardelean To: , CC: , , , "Alexandru Ardelean" Subject: [PATCH v5 0/6] iio: core,buffer: re-organize chardev creation Date: Sun, 26 Apr 2020 10:38:11 +0300 Message-ID: <20200426073817.33307-1-alexandru.ardelean@analog.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-ADIRoutedOnPrem: True X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-04-25_14:2020-04-24,2020-04-25 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 suspectscore=2 malwarescore=0 spamscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 mlxlogscore=999 clxscore=1015 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004260070 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The main intent is to be able to add more chardevs per IIO device, one for each buffer. To get there, some rework is needed. This tries to re-organize the init of the chardev. Changelog v4 -> v5: - dropped patch 'iio: Use an early return in iio_device_alloc to simplify code.' is applied upstream Changelog v3 -> v4: - added patch [1] 'iio: Use an early return in iio_device_alloc to simplify code.' it's main purpose is so that this patch applies: [2]'iio: core: add simple centralized mechanism for ioctl() handlers' depending on the final version of patch [1], patch [2] needs some minor fixup - added patch 'iio: core,buffer: wrap iio_buffer_put() call into iio_buffers_put()' - patch 'iio: core: register buffer fileops only if buffer present' is now: 'iio: core: register chardev only if needed' - dropped 'iio: buffer: move sysfs alloc/free in industrialio-buffer.c' it's likely we won't be doing this patch anymore - patches: 'iio: buffer: move iio buffer chrdev in industrialio-buffer.c' 'iio: event: move event-only chardev in industrialio-event.c' have been merged into 'iio: buffer,event: duplicate chardev creation for buffers & events' since now, the logic is a bit different, and 'indio_dev->chrdev' is now a reference to either the buffer's chrdev & or the events-only chrdev - added simple mechanism to register ioctl() handlers for IIO device which is currently used only by events mechanism Changelog v2 -> v3: * removed double init in 'iio: event: move event-only chardev in industrialio-event.c' Changelog v1 -> v2: * re-reviewed some exit-paths and cleanup some potential leaks on those exit paths: - for 'iio: buffer: move iio buffer chrdev in industrialio-buffer.c' add iio_device_buffers_put() helper and calling iio_buffers_uninit() on device un-regsiter - for 'move sysfs alloc/free in industrialio-buffer.c' call 'iio_buffer_free_sysfs_and_mask()' on exit path if cdev_device_add() fails - for 'move event-only chardev in industrialio-event.c' check if event_interface is NULL in iio_device_unregister_event_chrdev() Alexandru Ardelean (6): iio: buffer: add back-ref from iio_buffer to iio_dev iio: core,buffer: wrap iio_buffer_put() call into iio_buffers_put() iio: core: register chardev only if needed iio: buffer,event: duplicate chardev creation for buffers & events iio: core: add simple centralized mechanism for ioctl() handlers iio: core: use new common ioctl() mechanism drivers/iio/iio_core.h | 29 ++++++--- drivers/iio/industrialio-buffer.c | 102 +++++++++++++++++++++++++++-- drivers/iio/industrialio-core.c | 105 +++++++++++------------------- drivers/iio/industrialio-event.c | 100 +++++++++++++++++++++++++++- include/linux/iio/buffer_impl.h | 10 +++ include/linux/iio/iio.h | 8 +-- 6 files changed, 267 insertions(+), 87 deletions(-) -- 2.17.1