Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1676073ybz; Sun, 26 Apr 2020 01:48:04 -0700 (PDT) X-Google-Smtp-Source: APiQypLOvcxE/Dp5dQsk6PWzs63AkHBTo80IN7xvbZ6HeTc8rpoecX+qVEDfb2qgyiioDkE0vOY3 X-Received: by 2002:a50:fa87:: with SMTP id w7mr14798578edr.0.1587890884159; Sun, 26 Apr 2020 01:48:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587890884; cv=none; d=google.com; s=arc-20160816; b=jJ2IYUMTksuWaj/AiTxZTU5wg5ix7Ke9PinCNSEgDxvvW5eOk7ERE4Rap5JeN51ttn pAQxBLOa1ApmDf9UCnHzd0EuNKgmK/g6ORbXmYyEGBtcigUrnviMelbDrZiyl0Xlt5Tj RMb9cD2oi2A59tM3BoJWlT2e1IKsUR7RHX0MuRwICTP2BGT2qvEVRmlvKwesilO/Wqlr dd09mnuNUtM5qXvVOLFOr5uW2jrEzCuL4K+IHQPsORyUSlNvcbt9kU+MWgUXkAzozlbw GHDyKH08rBEK/TzZH6gPUFwdr7C+T/s6LgItzZ/8nAhOUqLqSYQAr0sGC/y1FcYDagDu tZBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=VDWh9WdwyXAnTeyjirmRWYgZgYhUoEBLJoOtyOTjwig=; b=UDYe3/cG1Mce9S2+6Udrtk6/RPYXVqAFgAfSKukTx7BAUzc+jSeHJ/5cr/xB2mBSxt D7oXpcQbxI6/3jTvL9YETutiDoNjjkdb+dRqr6plWWAQf1f6KTtJ142xPjm26JbBzCLg 5Tt0hqniVMC3qoRL3MvEMUTRsQxlAVp54P5Z6yZSPh3FpSaq9kyWUL4Z8MkE28+C9+tY sBYwijNdbwSkD46yM8hjJUBdo/7AoWsN7yfaHzXaVK8t3fISAs6UWRSeL9UUvvUhjkI7 Wm/NS2SZQpYfU81viCIFR59FCU7nbfiFvkiUi9r8S05FvmpPTdQNPCxqGuWLfdeOGvlv XFkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o18si6599969ejr.273.2020.04.26.01.47.40; Sun, 26 Apr 2020 01:48:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726156AbgDZIoU (ORCPT + 99 others); Sun, 26 Apr 2020 04:44:20 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:53230 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726108AbgDZIoU (ORCPT ); Sun, 26 Apr 2020 04:44:20 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id F313ED09628CC06D999E; Sun, 26 Apr 2020 16:44:17 +0800 (CST) Received: from [127.0.0.1] (10.166.213.7) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Sun, 26 Apr 2020 16:44:16 +0800 Subject: Re: [PATCH] i2c: busses: remove unneeded conversion to bool To: Wolfram Sang CC: , , , , References: <20200420042816.18989-1-yanaijie@huawei.com> <20200426081652.GH1262@kunai> From: Jason Yan Message-ID: Date: Sun, 26 Apr 2020 16:44:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200426081652.GH1262@kunai> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.166.213.7] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/4/26 16:16, Wolfram Sang 写道: > On Mon, Apr 20, 2020 at 12:28:16PM +0800, Jason Yan wrote: >> The '>' expression itself is bool, no need to convert it to bool again. >> This fixes the following coccicheck warning: >> >> drivers/i2c/busses/i2c-qup.c:960:48-53: WARNING: conversion to bool not needed here >> drivers/i2c/busses/i2c-qup.c:962:47-52: WARNING: conversion to bool not needed here >> drivers/i2c/busses/i2c-qup.c:1531:29-34: WARNING: conversion to bool not needed here >> drivers/i2c/busses/i2c-qup.c:1533:29-34: WARNING: conversion to bool not needed here >> >> Signed-off-by: Jason Yan > > Applied to for-next, thanks! But please fix $subject to have the driver > name "qup" next time. > OK, get it. Thanks, Jason