Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1711668ybz; Sun, 26 Apr 2020 02:36:55 -0700 (PDT) X-Google-Smtp-Source: APiQypK8AfclrxrTY1e95HSBBePx6wy4nM1/b4xD8v3814hbsmiqXH2KNg03o7/pp98A0vYGcmEe X-Received: by 2002:a17:907:b11:: with SMTP id h17mr15555895ejl.371.1587893815270; Sun, 26 Apr 2020 02:36:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587893815; cv=none; d=google.com; s=arc-20160816; b=01DanROOJUKtW2QoovqLpHQfKSRxdh5uxG79pzHgEat9E05zJ7R7K2IP0DnpOwGyC6 BUAc+UZz4AtI66Psl+1FehSXBtAshulAnVrAYhCqvUvfFUbgreHMQG/b8whLhwWFxnK8 9HkvXntdRYJZzTRpebF2dWJGobn2H/sE1xcde5BhDtdwtOHOrjAGmwVOdP0S/mHlvRUS NI7tVHwvW5TJjtgNs9KStvO0pDK+T7BL1450qTBD7OtBCorJ88o5UZ1iy+zAkuJpI9RE eXuzsTynsHTpNCaprOjI+TfZJDQZjN6DnMXFUee4A6ddbdU/eAMNon4oZQp9ufOKAM3j Cnbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=pxe2kgNmPOwLreOfTE1QexJc1RVsCcMvQPsOzl+UUPo=; b=mHWSnAd33bWaRRy8DcykfIcfUUVfJpGM7iKXJkRnPvPFye+hoD6O21ttaw7ZOjzh23 0bFTx3xEZqRfSXpxwxyYBj0/IBSUcoiC10///5HJjJBWI7BB1OVkTkNFPQgVe2ZHSLyn 39qu2CMQPUPLGvvTj3Ol61aGZwxX4bCgXZ0zQcb4aVhx1YKaT78ZUeH4jQbBAB5SRba/ 0GTLIhfImTgnKEQbgIDvdTthCMorMmF40n9aT7lNww3p4iJyQDvZQY+7HMgPVxiWA/XJ 4HPI72f8ByaAhGlG+8d5Mtl2GpbEFpy5joiU5tH421j5LGll2XGlYi3eWaAoWJpbbBev iqQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Fho/YBff"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n20si6236637edo.531.2020.04.26.02.36.31; Sun, 26 Apr 2020 02:36:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Fho/YBff"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726132AbgDZJer (ORCPT + 99 others); Sun, 26 Apr 2020 05:34:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:57254 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725806AbgDZJer (ORCPT ); Sun, 26 Apr 2020 05:34:47 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8EBD920700; Sun, 26 Apr 2020 09:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587893686; bh=kR/2T0w9mJ2ALzxxWE7yrQhRXtKJQ4uWeSGOt4AfhqM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Fho/YBffK/t7UX26k+VLGEZmmfe9aTKeWH1BSRttXhmqktyT/BqwPnW/Mh/D33Y0f KHd41pE2W33CpmB0/233MxFgvQf1TOUDfI/5Q1vm71pEgQTAUvkTon2hc/3ho6eX8I tKPh1C2RP3iZnSb/8JSamvLoR1OCBR80op9zKYpA= Date: Sun, 26 Apr 2020 10:34:41 +0100 From: Jonathan Cameron To: Ivan Mikhaylov Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , , , , Mark Rutland , Rob Herring , Andy Shevchenko Subject: Re: [PATCH v11 1/2] iio: proximity: provide device tree binding document Message-ID: <20200426103441.6d822c7c@archlinux> In-Reply-To: <20200422160509.7117-2-i.mikhaylov@yadro.com> References: <20200422160509.7117-1-i.mikhaylov@yadro.com> <20200422160509.7117-2-i.mikhaylov@yadro.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Apr 2020 19:05:08 +0300 Ivan Mikhaylov wrote: > Mostly standard i2c driver with some additional led-current option > for vcnl3020. > > Signed-off-by: Ivan Mikhaylov Hm. I missed on previous versions that the title of this patch doesn't match the dt-bindings standard. Please look at other bindings patches. e.g. dt-bindings: proximity: Add docs for vcnl3020 One other comment inline from me. > --- > .../bindings/iio/proximity/vcnl3020.yaml | 64 +++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/proximity/vcnl3020.yaml > > diff --git a/Documentation/devicetree/bindings/iio/proximity/vcnl3020.yaml b/Documentation/devicetree/bindings/iio/proximity/vcnl3020.yaml > new file mode 100644 > index 000000000000..ac47770609d2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/proximity/vcnl3020.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/proximity/vcnl3020.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Integrated Proximity Sensor With Infrared Emitter > + > +maintainers: > + - Ivan Mikhaylov > + > +description: | > + The VCNL3020 is a fully integrated proximity sensor. Fully integrated means > + that the infrared emitter is included in the package. It has 16-bit > + resolution. It includes a signal processing IC and features standard I2C > + communication interface. It features an interrupt function. > + > + Specifications about the devices can be found at: > + https://www.vishay.com/docs/84150/vcnl3020.pdf > + > +properties: > + compatible: > + enum: > + - vishay,vcnl3020 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + vdd-supply: > + description: Regulator that provides power to the sensor > + > + vddio-supply: > + description: Regulator that provides power to the bus > + > + vishay,led-current-microamp: > + description: > + IR LED current value with valid Range = 0 to 20d. e.g. 0 = 0 mA, > + 1 = 10 mA, 20 = 200 mA. LED Current is limited to 200 mA for values > + higher than decimal 20. The text doesn't add anything to the enum which fully defines the values. I'd go with something simple like: The drive current for the LED used in proximity sensing. > + enum: [0, 10000, 20000, 30000, 40000, 50000, 60000, 70000, 80000, 90000, > + 100000, 110000, 120000, 130000, 140000, 150000, 160000, 170000, > + 180000, 190000, 200000] > + default: 20000 > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + i2c { > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + proximity@13 { > + compatible = "vishay,vcnl3020"; > + reg = <0x13>; > + vishay,led-current-microamp = <200000>; > + }; > + };