Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1886853ybz; Sun, 26 Apr 2020 06:29:05 -0700 (PDT) X-Google-Smtp-Source: APiQypJhH86gFmO3Audo2sHWSvNwAFZNkoze7fx9uG8sfEgztmaHpgBNgOJ0ywan4xodMZkqlpdJ X-Received: by 2002:a17:906:7717:: with SMTP id q23mr15676806ejm.38.1587907745331; Sun, 26 Apr 2020 06:29:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587907745; cv=none; d=google.com; s=arc-20160816; b=0nOIRW5R640KJ/CBpPy5oouqNDrI6LSHVOYyCPkD1uaEov57Py0u8N+qvpm1gNXn4x BIf0v3Emztz2504uyYuSdhrTTkbR49HN7nrC3OK15vP9kEk5NG4Z9BKb5sLICaoLNehY zHVcA6srmEoyK2PDZrMYxUyNcJ0p9AxJB2Hnyvk71I0NEt5PJ+BY+ZIQIkaTbbRSzHdM /n0v1k3x1z8uZIbndF2ud8ojNfr7adKK8mJJSU8plPcBuiqcfmyllH71rfFTiH2Iw4tV 2LIKUdOLRNxU/wzIApzW7g6cjc+HavZ7ATiLVXeZ4b5txCbgUth8Ht3fJOjCWyhmd25G t0Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from; bh=wo4SZeDn978c9zPJ13eG2gcr3ehv+87IxlHP2S8+3Q0=; b=YM8iaUkX0co+hBVajwg/Lc0w+k1w/3/EJBOBUl0DEULp1f0qtN7ZYe0UFnFDXE2nki LekcBKj4DQ6leDcLT2D6kpqtCyUfc6W6gDJn9UtMBTkXbjXblkoUQM9WT72jB04Eq3lz PleNs4ZlwR+CBPDN3Z6RLpiPsouCN/YPMj2ztyGn2jobvorFBOYgSJNWZHhgo7w2fwHc KcCjFsYODzZmzmSp53GSzWl1YY3SyvBqx+GQl921GJfGKdBJlLIjlOnWG/yJ2aKLdQt7 fQjDTznAkhAT0egfDxWUwc5Z02Cf+N9kYIb6ru2W/9fONUUzPgWxduSMgo9toHxu8NMS 2VmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp6si8263934ejc.238.2020.04.26.06.28.42; Sun, 26 Apr 2020 06:29:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726152AbgDZN04 (ORCPT + 99 others); Sun, 26 Apr 2020 09:26:56 -0400 Received: from mail.secom.com.pl ([213.216.87.26]:49068 "EHLO mail.secom.com.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbgDZN04 (ORCPT ); Sun, 26 Apr 2020 09:26:56 -0400 Received: from localhost.localdomain ([37.109.33.236]) by mail.secom.com.pl; Sun, 26 Apr 2020 15:26:42 +0200 From: =?UTF-8?q?Rafa=C5=82=20Hibner?= Cc: =?UTF-8?q?Rafa=C5=82=20Hibner?= , Alexander Viro , linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and infrastructure)), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] fs: Allow splicing from character device Date: Sun, 26 Apr 2020 15:17:30 +0200 Message-Id: <20200426131730.8438-1-rafal.hibner@secom.com.pl> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Splicing from character devices should be enabled. It allows for efficient (ZEROCOPY) bulk data tranfers from device. --- fs/splice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/splice.c b/fs/splice.c index 4735defc46..306d11c5ea 100644 --- a/fs/splice.c +++ b/fs/splice.c @@ -920,7 +920,7 @@ ssize_t splice_direct_to_actor(struct file *in, struct splice_desc *sd, * piped splicing for that! */ i_mode = file_inode(in)->i_mode; - if (unlikely(!S_ISREG(i_mode) && !S_ISBLK(i_mode))) + if (unlikely(!S_ISREG(i_mode) && !S_ISBLK(i_mode) && !S_ISCHR(i_mode))) return -EINVAL; /* -- 2.24.1