Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1977009ybz; Sun, 26 Apr 2020 08:23:45 -0700 (PDT) X-Google-Smtp-Source: APiQypIzFIdT4QZikIhC6b0OJSlhE9KOLpnqZFrEr3Dr2ojxt4dVKWdzIP3Jlced/GxBv35JF3Dj X-Received: by 2002:a17:907:435d:: with SMTP id oc21mr16323179ejb.100.1587914625028; Sun, 26 Apr 2020 08:23:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587914625; cv=none; d=google.com; s=arc-20160816; b=ca9kEVEo5+CZsL4jG9Qs9SWS2vtOBEN0ZZ5nfX2eg0Y7pZCJgzxDv4VWe6opE+4f7F 9Y9ySK82FLZGLyY1yAQ8/fqAhKEHbtRy9hYmRn0Aj4BY7O2t0BSoBzOHwEFo7aE6VBrL 8E2bt0jrK6RwhsIlaEfiGqmF0SHI+IaBwepOT9QAODX3VDdsBE8+u7guLaNcKn0fnfK+ ZxZddOS2v4icN2hToWeYjLcR6HFBk5A/cdXq4VSMxegn4DmxbflNMeUuA2lJLJzE4fUl fCqXJK6EAj+3k3iqYxJgcCETi4BbM9ao4j7LwYgxVS1qqZ+gX7SWG74uX6mjMkb8B8S7 Pmdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Oec0onKReyMxClDdJY4/0WsT5jFsmRnzuCNfEJGndcY=; b=yaXz1q4SPXfDMK27Zj/+vZg69+h5y2PweYPBlNouP/v/Tp+vXS5DAvKDPq8yr/9mpU GCfmVpHhO+g4yd5xx2RDxs/VcLbRtqQqJxCt+kesI2EgpeNU36dY6MxjKtlVCOH/RVr/ nEa4o4wXOmSTt70aF6jvKndNSCBZmOy+CgnijOpJGUvBeu2cvi1ZlAcC064YkbErzK7F cW2qMeVs2A19y51g1d6vOu0Pr6KRn9uQ4hTY/wJVnFnTNi089Yk5TLNCmO2sSkbCD0vr vPa0grd9pTbnODY46FSeQ/6eOKFgHC/T50hiRpTIsIIFVXCjNWa9eEqZEncW2wwGyD/G Y4IQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@brainfault-org.20150623.gappssmtp.com header.s=20150623 header.b=fKbv3cWk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id du9si7642573ejc.34.2020.04.26.08.23.20; Sun, 26 Apr 2020 08:23:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@brainfault-org.20150623.gappssmtp.com header.s=20150623 header.b=fKbv3cWk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726174AbgDZPVt (ORCPT + 99 others); Sun, 26 Apr 2020 11:21:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbgDZPVt (ORCPT ); Sun, 26 Apr 2020 11:21:49 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97C14C061A0F for ; Sun, 26 Apr 2020 08:21:47 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id v4so13976381wme.1 for ; Sun, 26 Apr 2020 08:21:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Oec0onKReyMxClDdJY4/0WsT5jFsmRnzuCNfEJGndcY=; b=fKbv3cWkTUyDAeQhb386kJbwXWqxg0I/EcVVdTNgbFlmukh7OcHDr2el0Z133lHTDQ rxS5IcZtRpqE7nRsGYrFhrIxnCFwjYWP8IHg976WeSQXCo84T11bEpYW+0MFzEOk508C E4HMKA28awoKmTVPkiBCsjG4JdS9bGt2ybDf2ODOKYwVBpEWqTihfRcew5iQt5iUkV21 S2GF1loV+k1tDi3VZLnM44qJcJSKXqPVN37UynAL89yRacAXTShmZBdmSemblCffHmOI 7istGl3jc1IU3ewbbuDUApzG8AQHnda1YIXrVCYAMfUc1oFW80T6k3GjL1gYAof3SA5p qoxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Oec0onKReyMxClDdJY4/0WsT5jFsmRnzuCNfEJGndcY=; b=CJlka0ytl0sZAxP/RP9zrIsWVeJj9/TFzVM7qYTLuVIIzBnj939HoMv68uRI+i+Bp5 gCXlgnm/z2j6+IIilq6niTe73QWbbSZ+uwiqrDb2qj1hh/6nYphDOHdsWeUdOuHpiobR kRDSsw/5DPbStn2lsxpmdcCi2K2E3Fxw+Tl+v7OTSD4n7EyldzlOajj+LESpOOlbBYmi RStknDowXl5XeoP+CDkk21BneCpTkNy0ENEdNVGNTZMWxAHsVMwsPzv0m0RkLtEKeoZV ob7h95Admy6y+k58YTjCn+DftA9G+vMtNFSSSxY+dF7lSKuR+Xea2QiJcxmdlkTl6PlP 2HRQ== X-Gm-Message-State: AGi0PubfdNg6N/pcFIjBHy18zYbqEguHAY85x86O0oFLeH1x72aH1R3J gTnoc+EDygpVtSAKCUb8g9i8/hb2DEodSfXg68czgA== X-Received: by 2002:a1c:7301:: with SMTP id d1mr22595992wmb.26.1587914505976; Sun, 26 Apr 2020 08:21:45 -0700 (PDT) MIME-Version: 1.0 References: <20200426110740.123638-1-zong.li@sifive.com> In-Reply-To: From: Anup Patel Date: Sun, 26 Apr 2020 20:51:34 +0530 Message-ID: Subject: Re: [PATCH] irqchip/sifive-plic: allow many cores to handle IRQs To: Zong Li Cc: Palmer Dabbelt , Paul Walmsley , "linux-kernel@vger.kernel.org List" , linux-riscv , David Abdurachmanov , Marc Zyngier Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 26, 2020 at 8:42 PM Zong Li wrote: > > On Sun, Apr 26, 2020 at 9:38 PM Anup Patel wrote: > > > > +Mark Z > > > > On Sun, Apr 26, 2020 at 6:49 PM Zong Li wrote: > > > > > > On Sun, Apr 26, 2020 at 8:47 PM Anup Patel wrote: > > > > > > > > On Sun, Apr 26, 2020 at 4:37 PM Zong Li wrote: > > > > > > > > > > Currently, driver forces the IRQs to be handled by only one core. This > > > > > patch provides the way to enable others cores to handle IRQs if needed, > > > > > so users could decide how many cores they wanted on default by boot > > > > > argument. > > > > > > > > > > Use 'irqaffinity' boot argument to determine affinity. If there is no > > > > > irqaffinity in dts or kernel configuration, use irq default affinity, > > > > > so all harts would try to claim IRQ. > > > > > > > > > > For example, add irqaffinity=0 in chosen node to set irq affinity to > > > > > hart 0. It also supports more than one harts to handle irq, such as set > > > > > irqaffinity=0,3,4. > > > > > > > > > > You can change IRQ affinity from user-space using procfs. For example, > > > > > you can make CPU0 and CPU2 serve IRQ together by the following command: > > > > > > > > > > echo 4 > /proc/irq//smp_affinity > > > > > > > > > > Signed-off-by: Zong Li > > > > > --- > > > > > drivers/irqchip/irq-sifive-plic.c | 21 +++++++-------------- > > > > > 1 file changed, 7 insertions(+), 14 deletions(-) > > > > > > > > > > diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c > > > > > index d0a71febdadc..bc1440d54185 100644 > > > > > --- a/drivers/irqchip/irq-sifive-plic.c > > > > > +++ b/drivers/irqchip/irq-sifive-plic.c > > > > > @@ -111,15 +111,12 @@ static inline void plic_irq_toggle(const struct cpumask *mask, > > > > > static void plic_irq_unmask(struct irq_data *d) > > > > > { > > > > > struct cpumask amask; > > > > > - unsigned int cpu; > > > > > struct plic_priv *priv = irq_get_chip_data(d->irq); > > > > > > > > > > cpumask_and(&amask, &priv->lmask, cpu_online_mask); > > > > > - cpu = cpumask_any_and(irq_data_get_affinity_mask(d), > > > > > - &amask); > > > > > - if (WARN_ON_ONCE(cpu >= nr_cpu_ids)) > > > > > - return; > > > > > - plic_irq_toggle(cpumask_of(cpu), d, 1); > > > > > + cpumask_and(&amask, &amask, irq_data_get_affinity_mask(d)); > > > > > + > > > > > + plic_irq_toggle(&amask, d, 1); > > > > > } > > > > > > > > > > static void plic_irq_mask(struct irq_data *d) > > > > > @@ -133,24 +130,20 @@ static void plic_irq_mask(struct irq_data *d) > > > > > static int plic_set_affinity(struct irq_data *d, > > > > > const struct cpumask *mask_val, bool force) > > > > > { > > > > > - unsigned int cpu; > > > > > struct cpumask amask; > > > > > struct plic_priv *priv = irq_get_chip_data(d->irq); > > > > > > > > > > cpumask_and(&amask, &priv->lmask, mask_val); > > > > > > > > > > if (force) > > > > > - cpu = cpumask_first(&amask); > > > > > + cpumask_copy(&amask, mask_val); > > > > > else > > > > > - cpu = cpumask_any_and(&amask, cpu_online_mask); > > > > > - > > > > > - if (cpu >= nr_cpu_ids) > > > > > - return -EINVAL; > > > > > + cpumask_and(&amask, &amask, cpu_online_mask); > > > > > > > > > > plic_irq_toggle(&priv->lmask, d, 0); > > > > > - plic_irq_toggle(cpumask_of(cpu), d, 1); > > > > > + plic_irq_toggle(&amask, d, 1); > > > > > > > > > > - irq_data_update_effective_affinity(d, cpumask_of(cpu)); > > > > > + irq_data_update_effective_affinity(d, &amask); > > > > > > > > > > return IRQ_SET_MASK_OK_DONE; > > > > > } > > > > > -- > > > > > 2.26.1 > > > > > > > > > > > > > I strongly oppose (NACK) this patch due to performance reasons. > > > > > > > > In PLIC, if we enable an IRQ X for N CPUs then when IRQ X occurs: > > > > 1) All N CPUs will take interrupt > > > > 2) All N CPUs will try to read PLIC CLAIM register > > > > 3) Only one of the CPUs will see IRQ X using the CLAIM register > > > > but other N - 1 CPUs will see no interrupt and return back to what > > > > they were doing. In other words, N - 1 CPUs will just waste CPU > > > > every time IRQ X occurs. > > > > > > > > Example1, one Application doing heavy network traffic will > > > > degrade performance of other applications because with every > > > > network RX/TX interrupt N-1 CPUs will waste CPU trying to > > > > process network interrupt. > > > > > > > > Example1, one Application doing heavy MMC/SD traffic will > > > > degrade performance of other applications because with every > > > > SPI read/write interrupt N-1 CPUs will waste CPU trying to > > > > process it. > > > > > > > > In fact, the current PLIC approach is actually a performance > > > > optimization. This implementation also works fine with in-kernel > > > > load-balancer and user space load balancer. > > > > > > > > > > Yes, it's exactly, I know what you pointed out. But the idea of this > > > patch is just providing a way that users could enable other cores if > > > they wanted, it could still enable only one core by this change. The > > > purpose here is thinking of flexible use, rather than limitation. > > > Maybe it would be a happy medium that we make the default case enable > > > only one core? It is a good open discussion. > > > > Making the default case as enable only one core is just a work-around. > > > > As-per my understanding, if we set affinity mask of N CPUs for IRQ X > > then it does not mean all N CPUs should receive IRQ X rather it means > > that exactly one of the N CPUs will receive IRQ X and the IRQ receiving > > CPU will be fixed (reflected by effective affinity returned by the driver). > > is there a case that we only bundle the IRQ to CPU0, but CPU0 is more > much busy than other CPUs, and it would be better if another CPU could > take the IRQ? This is a common problem across architectures. To tackle this, we typically run irqbalance daemon in user-space which will change IRQ affinity based on CPU load. Refer, https://linux.die.net/man/1/irqbalance > > > > > If we ignore above semantics and still provide a mechanism to target > > IRQ X to N CPUs then most likely someone will try and run into > > performance issues. > > > > Please don't go this path. The performance impact in case of Guest/VM > > is even worst because PLIC is trap-n-emulated by hypervisors as MMIO > > device. > > OK, I won't persist in that, just wanna figure out the situation. > > > > > Regards, > > Anup Regards, Anup