Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2008652ybz; Sun, 26 Apr 2020 09:06:11 -0700 (PDT) X-Google-Smtp-Source: APiQypIYuKjp9WXy3GZ8x2cheDVbm4qXO2QTS4rfol1gss+HEoMHuJKs7bKa/RXOKV2ZTCbelAQ3 X-Received: by 2002:a50:ba83:: with SMTP id x3mr14726045ede.193.1587917170795; Sun, 26 Apr 2020 09:06:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587917170; cv=none; d=google.com; s=arc-20160816; b=uYFcvQkBmnjEuEBg2PgCRXEQlI7NT+nYYS5yKNO4FDoCm5mA8g2KqQbePI3OOxn842 K4P08mn45IV5aqqNE145dsgazKWo1EhruzZy8+ja+OEq54EetVWiQwoLil3wvHxVd3hf ZN3bTAzlw4jYdWVc7lpN9YAMBRWIdJXBJ/ncvTII05i2Ez1A0z5is+PgHNf/QM6deCab jr25x3xHe9+wg1CA0K9wrJzleX8ZSLhoyhqx6lzOuebBtRDs5Yyr6tvAOFit2zy7FKhU 0Wl7wJZQ2XZ3mhEly12WAOt5pM1AcpAGJgNlLuAVxcUS7bCkQ0aIlX5MUTJbLq9z5Sp+ Zz5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=uVMo5mYKGraHPBeJ1pf1ZYyBBNC6aAFTC/tR7qWS7Jc=; b=r7bpJHgzkap3CmmIzxvEovXvcs3an0TbDizlIZ6uGT4vQUVBdZ6lc7uXTW8128IVHJ Qsft7MNMcFKe6syllV599UIvrIlIFWfQRqA7wmUjjLgY3XElpAyZD0aPxeENUszGiEp9 3bVtoKVgs4aQR7CMwT1QL7ci06ITm0wdki81NRfExXLFILyka8UyRM5WGhhaELkuEZxS VoPtyS862tKqkK47pHPZq8aYg8pCwuTJLRO/ko+o6wyaAn3HPwrTqZtpYAXktLHsE4r8 Q9cZRbTN0dzagtIQNybkDWJIhL+FHdp+j5apj3gDA3xlHoaxtJ827C866NygGAkkbKBA mklA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=j4U0ucFX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gl22si6227405ejb.402.2020.04.26.09.05.47; Sun, 26 Apr 2020 09:06:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=j4U0ucFX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726281AbgDZQDE (ORCPT + 99 others); Sun, 26 Apr 2020 12:03:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725778AbgDZQDD (ORCPT ); Sun, 26 Apr 2020 12:03:03 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 292BEC061A0F; Sun, 26 Apr 2020 09:03:03 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id a21so12061198ljj.11; Sun, 26 Apr 2020 09:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=uVMo5mYKGraHPBeJ1pf1ZYyBBNC6aAFTC/tR7qWS7Jc=; b=j4U0ucFXvk/rIPae5mhG0g4nvKOC37AhBVhSYPYBT0jYzuso0nDSY9rH8P1MOghtA1 UiAsnJwNHiVUdGCvdkvXH2jsJCGbA2ZWMrCZU2TTHgh2dHnQVIEZxxT/RoZ/IaoRZXmf 4keYyIEQ7DdBk3JXU1UNLc3fcsEjNZ4VgAWAVt4xfo96VNGmPodRNy0GlnZJwPz4T9P9 b6dm3Ukz+odrqdEWd0v6jCrH9tjr8hTP1vGZ0iAjRk9NME39pk/cy1BZzqeD/XYCl2BY qVBMNMYt8PTfYr8Euwn7lOFVqFTVaQ/xTiumi3Jn51zuRfnw9VHrs2ug6H0W2ewIlTxV KKsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=uVMo5mYKGraHPBeJ1pf1ZYyBBNC6aAFTC/tR7qWS7Jc=; b=YuTXYtxzDGviDQcAOP4M/VBXbbRuJtBz11Ca0pgYn/laAeOpPUsxOCL1UVmBZ1zkjN CWmfhJdGIq3fw1YKZ+GRj9vrmPHukE54I3itVMN8ODLIP6FVohCg/C9XqakMJ1jLk5R0 /VD55axfyuZXd0L5a28PXSGPCHnVvPBntiFKOlYZKJUsCfd3vpz58RBaG0CT8tt95d5F FVjkkznYbgs1gRk/ge6vKRiCxg6Uag7ta5+gq51M56pB1vMG8Pt4leig8SziLsJz6NG4 YuQ1C1G1WGonaVd43NkUYiSrdwG6BHwmendK3bL4WpWsjN9dKXK6HubxvWnfGt/9jg/t ERHA== X-Gm-Message-State: AGi0PuY2QfQPJT3NDwtooZ4dDgwRWUM7xzomYI0Eywt7shRlo4ZLLGjr 7/sikeDVtf+LBoT7RRqaXo/xIs+qNTQiFyUhhbg= X-Received: by 2002:a2e:990f:: with SMTP id v15mr10954772lji.7.1587916981488; Sun, 26 Apr 2020 09:03:01 -0700 (PDT) MIME-Version: 1.0 References: <20200420183409.210660-1-zenczykowski@gmail.com> In-Reply-To: <20200420183409.210660-1-zenczykowski@gmail.com> From: Alexei Starovoitov Date: Sun, 26 Apr 2020 09:02:49 -0700 Message-ID: Subject: Re: [PATCH] net: bpf: Allow TC programs to call BPF_FUNC_skb_change_head To: =?UTF-8?Q?Maciej_=C5=BBenczykowski?= Cc: =?UTF-8?Q?Maciej_=C5=BBenczykowski?= , Alexei Starovoitov , Daniel Borkmann , Linux Network Development Mailing List , LKML , "David S . Miller" , Lorenzo Colitti Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 20, 2020 at 11:34 AM Maciej =C5=BBenczykowski wrote: > > From: Lorenzo Colitti > > This allows TC eBPF programs to modify and forward (redirect) packets > from interfaces without ethernet headers (for example cellular) > to interfaces with (for example ethernet/wifi). > > The lack of this appears to simply be an oversight. > > Tested: > in active use in Android R on 4.14+ devices for ipv6 > cellular to wifi tethering offload. > > Signed-off-by: Lorenzo Colitti > Signed-off-by: Maciej =C5=BBenczykowski Applied. Thanks