Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200422233928.GA2816@imac> <8255d8b1-f652-9ece-67d2-68c30a5cfbac@baylibre.com>
In-Reply-To: <8255d8b1-f652-9ece-67d2-68c30a5cfbac@baylibre.com>
From:   Tim Lewis <elatllat@gmail.com>
Date:   Sun, 26 Apr 2020 12:18:54 -0400
Message-ID: <CA+3zgmsVK9Uuv947-pniByP7QJVGcVK_EgiRkFipV5CUx70sHQ@mail.gmail.com>
Subject: Re: [PATCH v3] arm64: dts: meson: S922X: extend cpu opp-points
To:     Neil Armstrong <narmstrong@baylibre.com>
Cc:     khilman@baylibre.com,
        Christian Hewitt <christianshewitt@gmail.com>,
        joy.cho@hardkernel.com, tobetter <tobetter@gmail.com>,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        mark.rutland@arm.com, robh+dt@kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Oops, will fix in v4.


On Thu, Apr 23, 2020 at 3:40 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> On 23/04/2020 01:39, Tim Lewis wrote:
> > HardKernel supports overclock through the addition to extra opp points
> > in their official kernel sources for odroid-n2 [1]. Christian tested
> > on other S922X devices with "no obvious issues". Neil thinks dvfs and
> > thermal managementis can keep other S922X devices safe.
> --------------/\
>           management
>
> >
> > [1] https://github.com/hardkernel/linux/commit/f86cd9487c7483b2a05f448b9ebacf6bd5a2ad2f
> > Tested-by: Christian Hewitt <christianshewitt@gmail.com>
> > Signed-off-by: Tim Lewis <elatllat@gmail.com>
> >
> > ---
> >  arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi | 15 +++++++++++++++
> >  1 files changed, 15 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> > index 046cc332d..1e5d0ee5d 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> > @@ -65,6 +65,11 @@
> >                       opp-hz = /bits/ 64 <1896000000>;
> >                       opp-microvolt = <981000>;
> >               };
> > +
> > +             opp-1992000000 {
> > +                     opp-hz = /bits/ 64 <1992000000>;
> > +                     opp-microvolt = <1001000>;
> > +             };
> >       };
> >
> >       cpub_opp_table_1: opp-table-1 {
> > @@ -120,5 +125,15 @@
> >                       opp-hz = /bits/ 64 <1704000000>;
> >                       opp-microvolt = <891000>;
> >               };
> > +
> > +             opp-1800000000 {
> > +                     opp-hz = /bits/ 64 <1800000000>;
> > +                     opp-microvolt = <981000>;
> > +             };
> > +
> > +             opp-1908000000 {
> > +                     opp-hz = /bits/ 64 <1908000000>;
> > +                     opp-microvolt = <1022000>;
> > +             };
> >       };
> >  };
> >
>
> The patch is well formed but I can only test on Odroid-N2.
>
> Anyway, Christian did a test other S922X boxes and it doesn't crash.
>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>
> Neil