Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2025340ybz; Sun, 26 Apr 2020 09:26:04 -0700 (PDT) X-Google-Smtp-Source: APiQypLOlcJ0TlzH7IgA8vX7501clN62koQiWSdNjqiOe8Ozfy4bWMrQUiW/23Gdn6pHbr/+trXt X-Received: by 2002:aa7:d655:: with SMTP id v21mr15954248edr.355.1587918364813; Sun, 26 Apr 2020 09:26:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587918364; cv=none; d=google.com; s=arc-20160816; b=yr5WEs2O2lZhi+ZnXbDUbq1hpd8RVeppXyui+FyQ33b/OeE3ZYcs5cnZu8lda+E2n3 rBAnshTPUyKYpFSGkeooLxNaTmPBuIN58XAsVvwD1AQa4OL5AuTfwMtv2QWMI/JqmHlK jabnWUoR0pLWSvD6x8FxhH6TigSnxLc1WRplwjOzSWh3HO6nKgxpeH1JPvBWEye9p5/p dO4nPlby1XX/7Qhpvc8PTw7N0DqqGnSFrbvFIojfdlWEOA2lvUwIm+aJ/0D1WrTJtLLe jwI7tD0FwtJ4B4u97lTVJDQYSUqzq4tv3LrVE8xogutLWi1gYfl4urTv1LIsfSMFtTSM oKsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=1rwgSnwTVJnobIMor+102bHXnC1wPqkfj6KAxAT+DoA=; b=FOcX/kZShxGfpphDRub1navE1+d0KDBaF0G9xVAqWaClh+e0NQlIME0G/gEa4j9581 oDHrLqNmOlglkg0T6hmWrfLA9IdkG9bblgkX5kuRip/PpvbS2a+3jFHiPetNbOvCdFTL DQP9gztnjpAndK4+Ep5+B7sun0G9pfSQFjBo7shrG8LIpCnKdwIURmlM7KinQWUtQeQ+ uhcK4WGGkzILsozg+07okFUmAeEEVpSv+e2YvhKFGWzYkBcJtsZlhvKSOvDwM7mSpubC dluweRjgafiVwYHRW1ugMhFzQNhwVGTv8fnV79D1/z4S0McesnOTKkLGSOeyvWALD6Mo 95MA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uQUuL+cG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d4si4756790edo.434.2020.04.26.09.25.41; Sun, 26 Apr 2020 09:26:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uQUuL+cG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726225AbgDZQYU (ORCPT + 99 others); Sun, 26 Apr 2020 12:24:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726146AbgDZQYS (ORCPT ); Sun, 26 Apr 2020 12:24:18 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38F5DC061A0F; Sun, 26 Apr 2020 09:24:18 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id w145so11766571lff.3; Sun, 26 Apr 2020 09:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1rwgSnwTVJnobIMor+102bHXnC1wPqkfj6KAxAT+DoA=; b=uQUuL+cGnRzSkkTGBaXaQude2WmhJRUb1BbC6AwPx2ObLoeSenfug8YbQWWABgjbsj BGjMnKRYgwspj+GA/ahMaIF9jWIxdygzqvn8/Xlovvv17kczxBioqQT8qUepsEuvql+G 54bNZyQPLQRYwUPTDdQWpHWMLGlY663jSPKvLd/UBGWB2iuepmyZWALug/toqilOtB+n B63MKljV79LHu4t5Dfklhe5V6jScD6Mo5KgHLYVtQYX3hM6joiGsGzLtnrRKNcKSgDTw 2PzzrdKC6NwHB4BUYo0+05kp9AIsn1gWaDAwm0oLityScAMEEehWFaz9TrzPhcNjrkgT CySA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1rwgSnwTVJnobIMor+102bHXnC1wPqkfj6KAxAT+DoA=; b=SlQsOjsE8xDLgJDFBu3SVcgFcvHQkxfOxX0YqHPJP9gKyM81S9p8Nlc/gLuny9yQzv Kn2y6KvPbeP43glTtRPnOHNL+TpfdYdb70shIp80OdeTYRJ/u7weQBEh5/8Vi/K6bG5F CsRsZvODjdj/n6fZiR8ineEaf1C1iJRoms3bA2gGSRMLLrYMsyMsPMJmLu9TcDGsSYeo /uwDf4z/12zCRniN1IcIqH9mOR/0Bw1e1j1oBpZXRXi20aVqm1Fr2vdLvjhOQvurnEjX qRC2odRjPSq54wZII0UP8FeiRm9o7DrJzhA4Yo4Qiz/D7lWAmtGnHHgs/WIU4ntApyO6 yncw== X-Gm-Message-State: AGi0Pub31glLeXtBh8MkYNpxKvo0pfQaNZAYyYFGuvXQK21cVZhCCtqm vNUdTOfVuioMM8oov2cNfr5Y7AX4 X-Received: by 2002:ac2:51c9:: with SMTP id u9mr13125082lfm.184.1587918256433; Sun, 26 Apr 2020 09:24:16 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id h6sm7882990ljj.29.2020.04.26.09.24.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Apr 2020 09:24:15 -0700 (PDT) Subject: Re: [PATCH v4 05/10] input: elants: refactor elants_i2c_execute_command() To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , David Heidelberg , Dmitry Torokhov , Henrik Rydberg , James Chen , Johnny Chuang , Rob Herring , Scott Liu Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <4e5bf76e695388d6aeefa00552675c0617c044f1.1587916846.git.mirq-linux@rere.qmqm.pl> From: Dmitry Osipenko Message-ID: <127c4cf0-9bf0-60a4-bc48-28988ae24967@gmail.com> Date: Sun, 26 Apr 2020 19:24:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <4e5bf76e695388d6aeefa00552675c0617c044f1.1587916846.git.mirq-linux@rere.qmqm.pl> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 26.04.2020 19:11, Michał Mirosław пишет: > Apply some DRY-ing to elants_i2c_execute_command() callers. This pulls > polling and error printk()s into a single function. > > Signed-off-by: Michał Mirosław > --- > v4: return 0 on success; use %pe for error code > --- > drivers/input/touchscreen/elants_i2c.c | 189 +++++++++++++------------ > 1 file changed, 96 insertions(+), 93 deletions(-) This patch doesn't apply to the recent linux-next, it needs to be rebased.