Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2031005ybz; Sun, 26 Apr 2020 09:33:25 -0700 (PDT) X-Google-Smtp-Source: APiQypKvNwih4PCQd3kQbQbOPkLKXH6noObo7B2dwE1drXtrc5D8zf8r+dID0WEouB6MHOjStjwt X-Received: by 2002:a17:907:6fc:: with SMTP id yh28mr16826961ejb.326.1587918805067; Sun, 26 Apr 2020 09:33:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587918805; cv=none; d=google.com; s=arc-20160816; b=PPWLTRGo7zSaY0guhv00JJ/O1/29OFk6woQRZ0WsU03xdaLnCFthUHwUpCVTqWrO7P uLK0h0O+iteCLccRqXE9NNU7D6Q2jJ40xcr7qwvIBp+yOkcjLxDViKS6kNNwJtSW/1OA yaD7R6hnATU0pp8wrTU6CRDmkQtANbBwLtSEecXmNt5nWagUVbQp5/3fQqlWEXaC2TnJ jhOjnjLpByZMqzPEYriA/n8ovAjoBpUoq7z2W/b6/U7EAxtp2BKBUSAaY2rU5s/OKSQm +FMijP0u1cUFsbQ0HYWe/2TkGdMCXmHgmnfjexJJjw5r9SVjMEG0a5UxC+gfRaMKpNRS nFpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=JftPLIptlGdZQu6glQqL9kYGbquEnJgxe+P0oVuYl+k=; b=I5mb+R5c0zL2T0gmX8rwAoK/lEodL9D1tPuksJagzN3L+65rfFWVKSpgTCMQWyaJMi tE7LvxbMUlOdclfbNHRC0GVG5w8siy7Sq5wqUs7sgt061I7Go0wnpTgBQuevLKZJSiHF FW3VfVdAl8+crZJA2k839zg09mXGD/OS9VI095HRJsE9K7/k/quLqzfy7LIOsJaoTjOf xNeYRxqHblLPHolcWx1GVbXM+BcZMxbvaXWWLtdegG0S5AFnFPIMWIp7DCxFjEcFcGBF 0lzk98dZAhKkuLZQ6mX/YqXlN/HDYXq2x940IS4D4R8hnKuosWF7jfQNm5ogY30L91hi moQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=R5AkkzWh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l9si7217432ejc.237.2020.04.26.09.32.57; Sun, 26 Apr 2020 09:33:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=R5AkkzWh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726165AbgDZQbb (ORCPT + 99 others); Sun, 26 Apr 2020 12:31:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726144AbgDZQba (ORCPT ); Sun, 26 Apr 2020 12:31:30 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B317AC061A0F; Sun, 26 Apr 2020 09:31:30 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id e6so6265507pjt.4; Sun, 26 Apr 2020 09:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=JftPLIptlGdZQu6glQqL9kYGbquEnJgxe+P0oVuYl+k=; b=R5AkkzWhmKtVHFAab9dLU+POlmMCVkok7ZkJ5yko8Grt5RGlW8ECa88J+LGU2HLF/n yk7Qcu/xSrEuq/NJWrDYuURPtOj0/Vh1wagNVv3JHnqFal4AL0jEHldYZbXcrPnP5GDE NgbEcoWgOpOcAFOAVws7uYyl2WmMceqwSZOObU2w9+PnUtyqNZfE0c8j3GS9majzYcLM nPS2JCKJ8gi7oByY8nLXYjUUSvj/uC3fAomE4iVSGnIviQtopEKFVomaXPC2w4TfO4Iv S+KwsvNi+BKJjcJGqjIPzArNNu87lyBT0k+5iewF2OxQKmFuur21VkKa23FsoXsbDn7p lq1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=JftPLIptlGdZQu6glQqL9kYGbquEnJgxe+P0oVuYl+k=; b=bgQT+LGK/4LX2R4LtfJ+GyGiZZQ0FYerJrBE/9PX3Bpo4ayQEQWJeSU64Fz0nhUeX1 s263WeCQU5YUrl08wtMoFjit8elqip9BYJd8rXJJfG3BKzMZWvqkRnOnnR89ZyA+Maro PE0qTsCAUsNOwAiD2WirN3KGrCm25iiRLmZZRPmKycVlqLmSMeh0m+cZKAj2jbOdxyVW wJ0YpENHQPA1zYJ+Ah9UgoCGhkixsPY3yzBL8gFvsrl4IaSMjQFiNGqyECwZlLsq2JMc 6xQCSMqXn1TBGVo1QoFcfC1YA2jT4sV/im6qhOHIWdsBeN4SvT7CdzsVh5q4ntTD5F00 AngQ== X-Gm-Message-State: AGi0PuagXAFcIigDTYbLReWLFeVfiSx9UUZ/yV5qmlUKUo75GvwKctiI /2NmyV5e70Mm2EGPENWdvxs= X-Received: by 2002:a17:902:a40e:: with SMTP id p14mr18334010plq.297.1587918689044; Sun, 26 Apr 2020 09:31:29 -0700 (PDT) Received: from ast-mbp ([2620:10d:c090:400::5:9db4]) by smtp.gmail.com with ESMTPSA id u12sm10307839pfc.15.2020.04.26.09.31.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2020 09:31:28 -0700 (PDT) Date: Sun, 26 Apr 2020 09:31:25 -0700 From: Alexei Starovoitov To: Maciej =?utf-8?Q?=C5=BBenczykowski?= Cc: Maciej =?utf-8?Q?=C5=BBenczykowski?= , Alexei Starovoitov , Daniel Borkmann , Linux Network Development Mailing List , linux-kernel@vger.kernel.org, "David S . Miller" , bpf@vger.kernel.org Subject: Re: [PATCH] net: bpf: add bpf_ktime_get_boot_ns() Message-ID: <20200426163125.rnxwntthcrx5qejf@ast-mbp> References: <20200420202643.87198-1-zenczykowski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200420202643.87198-1-zenczykowski@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 20, 2020 at 01:26:43PM -0700, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > On a device like a cellphone which is constantly suspending > and resuming CLOCK_MONOTONIC is not particularly useful for > keeping track of or reacting to external network events. > Instead you want to use CLOCK_BOOTTIME. > > Hence add bpf_ktime_get_boot_ns() as a mirror of bpf_ktime_get_ns() > based around CLOCK_BOOTTIME instead of CLOCK_MONOTONIC. > > Signed-off-by: Maciej Żenczykowski ... > diff --git a/net/core/filter.c b/net/core/filter.c > index 755867867e57..ec567d1e6fb9 100644 > --- a/net/core/filter.c > +++ b/net/core/filter.c > @@ -6009,6 +6009,8 @@ bpf_base_func_proto(enum bpf_func_id func_id) > return &bpf_tail_call_proto; > case BPF_FUNC_ktime_get_ns: > return &bpf_ktime_get_ns_proto; > + case BPF_FUNC_ktime_get_boot_ns: > + return &bpf_ktime_get_boot_ns_proto; > default: > break; > } That part got moved into kernel/bpf/helpers.c in the mean time. I fixed it up and applied. Thanks In the future please cc bpf@vger for all bpf related patches.