Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 26 Apr 2020 19:06:40 +0200
From:   Paul Cercueil <paul@crapouillou.net>
Subject: Re: [PATCH v2 1/3] PM: introduce pm_ptr() macro
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc:     Ulf Hansson <ulf.hansson@linaro.org>, Pavel Machek <pavel@ucw.cz>,
        Len Brown <len.brown@intel.com>, od@zcrc.me,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org
Message-Id: <4JNE9Q.Y5HBZ952XKLI@crapouillou.net>
In-Reply-To: <2708095.iQXV2FnTNx@kreacher>
References: <20200413123207.74552-1-paul@crapouillou.net>
        <2708095.iQXV2FnTNx@kreacher>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Rafael,

Le dim. 26 avril 2020 =E0 17:40, Rafael J. Wysocki <rjw@rjwysocki.net> a=20
=E9crit :
> On Monday, April 13, 2020 2:32:05 PM CEST Paul Cercueil wrote:
>>  This macro is analogous to the infamous of_match_ptr(). If CONFIG_PM
>>  is enabled, this macro will resolve to its argument, otherwise to=20
>> NULL.
>=20
> Well, this is going to result in quite a bit of unused code being
> added to the kernels built with CONFIG_PM unset.
>=20
> Is there any way to avoid that somehow?

Using __maybe_unused on the dev_pm_ops struct and the callbacks, as=20
long as they are static, they should be dropped by the compiler when=20
CONFIG_PM is not set.

-Paul

>=20
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>>  ---
>>=20
>>  Notes:
>>      v2: Remove pm_sleep_ptr() macro
>>=20
>>   include/linux/pm.h | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>=20
>>  diff --git a/include/linux/pm.h b/include/linux/pm.h
>>  index e057d1fa2469..1c0eec06905d 100644
>>  --- a/include/linux/pm.h
>>  +++ b/include/linux/pm.h
>>  @@ -374,6 +374,12 @@ const struct dev_pm_ops name =3D { \
>>   	SET_RUNTIME_PM_OPS(suspend_fn, resume_fn, idle_fn) \
>>   }
>>=20
>>  +#ifdef CONFIG_PM
>>  +#define pm_ptr(_ptr) (_ptr)
>>  +#else
>>  +#define pm_ptr(_ptr) NULL
>>  +#endif
>>  +
>>   /*
>>    * PM_EVENT_ messages
>>    *
>>=20
>=20
>=20
>=20
>=20