Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2081594ybz; Sun, 26 Apr 2020 10:42:57 -0700 (PDT) X-Google-Smtp-Source: APiQypKhxCrR7MQ8CjlHzP6zTInUlGpCIpE++sC4ZfpzTGLFaeZ4PMKHXCh983KMXf0+ay/UmXME X-Received: by 2002:a17:906:c839:: with SMTP id dd25mr15903742ejb.164.1587922976876; Sun, 26 Apr 2020 10:42:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587922976; cv=none; d=google.com; s=arc-20160816; b=Mm11phcC644HjPfB+O5dl1MZgUzqqdS3KwndEQ+ynRn7+YAU5GFrq3NeWY2mzDcSOv 7Eycmdxqe7B9oyAzzkCz6KpYpHOWD9YvUSLgvS9Zcw0iSIEjNuoPIm6TTNLSfCB6NGIF DGYBot1PERgnb0Hk89kocRhDkNd5Skf6PmurEE9iLNezVL1jte6u7uRjiim6KCw+GMy+ 7cSHoGyW5qmIpqIihNDu4NBexdONsLKQ3O1EoEIlzxL6oONebVG4wgYxxDh/QazSmm8S SbFicPPTqmDG+sVNveBHlSsvzWVGUTgZeU/knvgLEi5M6MmBuBmZ0mzVqBmZ+hETv3zA Ugzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HZGEfaYG7zBELDLYLXOaUW03OdAbxUIWmmKm5bAu6F0=; b=Op0Sf1i2w//bxMDR/PjrkCI6NE1AHF32YWsPJhB7zOpFANKa2+yZ6G1elPBg/5O0os 2h1LyA73I+9ImOfZBAlBy74D9w8Pha2qzeT5Mu6bECv+yGYaKjyfUTF+KtGYG2gFtg1K faeHPGZ7KN0JLAn20glbkk8rvxLrGPgPsB8pfuWjTuY2zVFmVX4eOv0BNqs0MzWTZdWx f+kGVyzyb0kDUwM+Us92g1hVam9H25lESn/j92HIVnWpeV5xMTHSyE4Vk80mxnHEipqd md+g8GKD8KRAjg1pnrsSkoAZwMB9qRQhvKc6M6ad4BfNS+7ZacWweB7DC9Otjvn7wDAH QPZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rere.qmqm.pl header.s=1 header.b=ieiRqUv2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o15si6826662eje.13.2020.04.26.10.42.33; Sun, 26 Apr 2020 10:42:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@rere.qmqm.pl header.s=1 header.b=ieiRqUv2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726264AbgDZRlB (ORCPT + 99 others); Sun, 26 Apr 2020 13:41:01 -0400 Received: from rere.qmqm.pl ([91.227.64.183]:29302 "EHLO rere.qmqm.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726154AbgDZRlA (ORCPT ); Sun, 26 Apr 2020 13:41:00 -0400 Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 499FZ24YmjzDY; Sun, 26 Apr 2020 19:40:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1587922858; bh=JLGALo/UiOILtQBtpA+1RzP50dZmtkvUbk0MBxCAtU0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ieiRqUv2js6Xx6/zbV8hMN8z+1T9FYsNDWeCarKZS1/Oh2yvV5RLnsSV1QgE2RUHM cDTbxCis/xvaoXbm0Ioxrw7hJ1B1hyMccty2yA8IxWS1qcIbtkx2AMrvGapHdHE6Ho dzEGoOYZ9pCoiGlU3UrHFw0AjBNJd+ukplwczjZEtfnKVcZKZcy+JjC+gez33gZ3jB okVb2isuyh31bZanGwX/fylOrAW/9902SQVaP+mfUUtp/dSnLXpspvSV+bf0QeZOTY qT0r/7GecdxJCaTKVfVgYakw1Q99n0fkpIAVq3WkjJIWuGQe/pMwb/6DQgSiKfsZSV GYX5vrlali/Lg== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.2 at mail Date: Sun, 26 Apr 2020 19:40:57 +0200 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= To: Dmitry Osipenko Cc: David Heidelberg , Dmitry Torokhov , Henrik Rydberg , James Chen , Johnny Chuang , Rob Herring , Scott Liu , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 05/10] input: elants: refactor elants_i2c_execute_command() Message-ID: <20200426174057.GB15436@qmqm.qmqm.pl> References: <4e5bf76e695388d6aeefa00552675c0617c044f1.1587916846.git.mirq-linux@rere.qmqm.pl> <127c4cf0-9bf0-60a4-bc48-28988ae24967@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <127c4cf0-9bf0-60a4-bc48-28988ae24967@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 26, 2020 at 07:24:14PM +0300, Dmitry Osipenko wrote: > 26.04.2020 19:11, Michał Mirosław пишет: > > Apply some DRY-ing to elants_i2c_execute_command() callers. This pulls > > polling and error printk()s into a single function. > > > > Signed-off-by: Michał Mirosław > > --- > > v4: return 0 on success; use %pe for error code > > --- > > drivers/input/touchscreen/elants_i2c.c | 189 +++++++++++++------------ > > 1 file changed, 96 insertions(+), 93 deletions(-) > > This patch doesn't apply to the recent linux-next, it needs to be rebased. I'm rebasing against for-linus brach at [1]. Will send v5 shortly. [1] git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git