Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932290AbWCFNuG (ORCPT ); Mon, 6 Mar 2006 08:50:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932292AbWCFNuF (ORCPT ); Mon, 6 Mar 2006 08:50:05 -0500 Received: from cantor2.suse.de ([195.135.220.15]:16780 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S932290AbWCFNuE (ORCPT ); Mon, 6 Mar 2006 08:50:04 -0500 Date: Mon, 06 Mar 2006 14:50:03 +0100 Message-ID: From: Takashi Iwai To: Dave Jones Cc: Linux Kernel Subject: Re: emu10k1_synth use after free In-Reply-To: <20060306085317.GA19831@redhat.com> References: <20060306085317.GA19831@redhat.com> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta21) (corn) (+CVS-20050720) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 906 Lines: 33 At Mon, 6 Mar 2006 03:53:17 -0500, Dave Jones wrote: > > Thou shalt not dereference freed memory. > > Coverity bug #958 > > Signed-off-by: Dave Jones > > --- linux-2.6/sound/pci/emu10k1/emu10k1_synth.c~ 2006-03-06 03:51:26.000000000 -0500 > +++ linux-2.6/sound/pci/emu10k1/emu10k1_synth.c 2006-03-06 03:51:36.000000000 -0500 > @@ -62,7 +62,6 @@ static int snd_emu10k1_synth_new_device( > > if (snd_emux_register(emu, dev->card, arg->index, "Emu10k1") < 0) { > snd_emux_free(emu); > - emu->hw = NULL; > return -ENOMEM; > } > > Thanks, I applied it to ALSA tree, too. Signed-off-by: Takashi Iwai Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/