Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2152340ybz; Sun, 26 Apr 2020 12:18:45 -0700 (PDT) X-Google-Smtp-Source: APiQypIJyUJJA0DVl3UcivJcATTbj08ShFh2Q0fqFb5PhjnrIjo/7sHmpZ6VKvJIsDQcES66JD28 X-Received: by 2002:a17:906:2458:: with SMTP id a24mr16247846ejb.239.1587928725780; Sun, 26 Apr 2020 12:18:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587928725; cv=none; d=google.com; s=arc-20160816; b=GdrP2QrTWPFXx71tWDoua4yr0/kpHMpPBZmDNTj3XxH/3XF/5A1nVD6Vj5Hv2e5HHH eZQaCV7Xy2hL4ZOoiDfEYgR/zPOvB20thvo5C6po98AKMgchRCvkpwobjXDC5RKP6Y/a DSii9bMSDhN1FCTawqZkhuYymtqitLyK/W5z8u+0NoOKyQH4OPnhsBCNIM7yUqi2KONs xKySz5DcpJXBzQKIJII0flt82coJ39vleFKZgjhbRbVQ/JbPHflGtgS/Ai1mYeQg+Qlj 5hm45Tj7582QnVCwCde42tkRZ+0MAuTtIeDJRsyey/0QMSMY1phR94JMOEdlVC6gmM3K /V3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=oXfJn50citGxohkYndS50uGnOJy657oXYe1cVuWp3vg=; b=tXJz4urW9NZCQqcBi972CqCyc7AlXyBfLte+pppaWyFPGKoXc9s9iWrpO7PnB0rGPG 1ohI7Pv5JuW6JefPQMibwX3XqwTkTlOLFnc04V/vKiC8nU3/WPUOx2rdHpenhnwFxRW2 okcWzNT/tgiSV2uGlUM8v713pv2LuDnjg9ZBVMn6ZF1jOMqyWnlGHaqV1AayicvpDXfv K5hxc/BwErbwdyT4q+KK6U4gjrVpqhpuUFSCmE1vRYwqBAkXOS4sfOjzATtSQxGo5acI O44FegLV/H+BRkSp0CDxyAEEe0X0eU3ewxZz7qzFzxGgll03QrDK7Mpkpte1oz51Rt3u uyjA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g14si7366821ejo.108.2020.04.26.12.18.22; Sun, 26 Apr 2020 12:18:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726208AbgDZTQh (ORCPT + 99 others); Sun, 26 Apr 2020 15:16:37 -0400 Received: from smtp06.smtpout.orange.fr ([80.12.242.128]:27620 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726171AbgDZTQg (ORCPT ); Sun, 26 Apr 2020 15:16:36 -0400 Received: from localhost.localdomain ([93.23.12.11]) by mwinf5d64 with ME id XXGZ220060EJ3pp03XGZe2; Sun, 26 Apr 2020 21:16:34 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 26 Apr 2020 21:16:34 +0200 X-ME-IP: 93.23.12.11 From: Christophe JAILLET To: thierry.reding@gmail.com Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] gpu: host1x: Clean up debugfs in error handling path in 'host1x_probe()' Date: Sun, 26 Apr 2020 21:16:30 +0200 Message-Id: <20200426191630.41290-1-christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'host1x_debug_init()' must be reverted in an error handling path. This is already fixed in the remove function since commit 44156eee91ba ("gpu: host1x: Clean up debugfs on removal") Signed-off-by: Christophe JAILLET --- drivers/gpu/host1x/dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c index 388bcc2889aa..be46554968af 100644 --- a/drivers/gpu/host1x/dev.c +++ b/drivers/gpu/host1x/dev.c @@ -435,6 +435,7 @@ static int host1x_probe(struct platform_device *pdev) return 0; deinit_intr: + host1x_debug_deinit(host); host1x_intr_deinit(host); deinit_syncpt: host1x_syncpt_deinit(host); -- 2.25.1