Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2174015ybz; Sun, 26 Apr 2020 12:48:49 -0700 (PDT) X-Google-Smtp-Source: APiQypIxssiZdyRqLNA5kKeAWQ9iOPreQM7AW0TZdMEubJ0fKkw2nSloZ+yOt2eG4LC8tG2lFdx1 X-Received: by 2002:a17:906:90cc:: with SMTP id v12mr16876575ejw.211.1587930529345; Sun, 26 Apr 2020 12:48:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587930529; cv=none; d=google.com; s=arc-20160816; b=dxZJSSDafA3sw7zW/jw0joukZri7ZPad9AsnVUO3/3LOKps4oixO4bOElSjhF+eDLM oJZRqAkQysUHYzINWl8N6WM+1Mj/FV+BjJIDtS20hsIt3irA5b4dv1uxOuc3ZUynzrJv 4xH1UpU9oEdcJKZwSsOiB6EadiU6VtbmFS8iDosDU9LTP7AlNJ7+lZG0+QTYKvxesfZp VsnXTbTaAK4GSWsHlb++QK8QcDDaoynu9fE33VcpwG4LaLfBIw+u2r6OUSaCMCek+9/z MWJomdc5YIFFBz72i8BsOBTEluJrFT9maqfj4Ixsck/ZlKcreYuS7A7jkv8Wya4S+QhO Gr3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=gVxpxhqx7Us0593Q1zpLEL+qrwvpHwD6w9wuaEqln4E=; b=SDiQWEcIl/1cNh2bwDIcZz2ux+A/n9dP2nu482JRhLy2wK53WmqXZB2LOA6WfTWF70 53ofq2fQEATA9iSC165gSGKVotYziCyR/3SjazM8Q9Y6jZmUwB6HfbiaUFweSTsO/nTO HxxWwVTpyZFqcTcx0OtjzTAwEDQQu9qa3FnnrJTgBJyniSWwomGPu0jhzmH7r2nVoLcq aM14nesv0bvOCoHVDPEs83YSvTlyVMUXsGVn4OoI+j/ni0cbXOEFF8IMMp7qM71fbbCn zR5UehFTW3xzja7e6evp8ZNO0GC32vDj/To7IwEO3SnR3kSUBguMQOYDprYkLCCHdHAs XVRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h21si7289069ejt.479.2020.04.26.12.48.25; Sun, 26 Apr 2020 12:48:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726184AbgDZToL (ORCPT + 99 others); Sun, 26 Apr 2020 15:44:11 -0400 Received: from smtp06.smtpout.orange.fr ([80.12.242.128]:60153 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726176AbgDZToK (ORCPT ); Sun, 26 Apr 2020 15:44:10 -0400 Received: from localhost.localdomain ([93.23.12.11]) by mwinf5d64 with ME id XXk72200Q0EJ3pp03Xk7zB; Sun, 26 Apr 2020 21:44:09 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 26 Apr 2020 21:44:09 +0200 X-ME-IP: 93.23.12.11 From: Christophe JAILLET To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, maitysanchayan@gmail.com, robh@kernel.org Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] iio: dac: vf610: Fix an error handling path in 'vf610_dac_probe()' Date: Sun, 26 Apr 2020 21:44:03 +0200 Message-Id: <20200426194403.41913-1-christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A call to 'vf610_dac_exit()' is missing in an error handling path. Fixes: 1b983bf42fad ("iio: dac: vf610_dac: Add IIO DAC driver for Vybrid SoC") Signed-off-by: Christophe JAILLET --- Un-tested. Proposal based on function names and functions called in the remove function --- drivers/iio/dac/vf610_dac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iio/dac/vf610_dac.c b/drivers/iio/dac/vf610_dac.c index 71f8a5c471c4..7f1e9317c3f3 100644 --- a/drivers/iio/dac/vf610_dac.c +++ b/drivers/iio/dac/vf610_dac.c @@ -223,6 +223,7 @@ static int vf610_dac_probe(struct platform_device *pdev) return 0; error_iio_device_register: + vf610_dac_exit(info); clk_disable_unprepare(info->clk); return ret; -- 2.25.1