Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <93994350620b4809e515c295c55ed23aceb9c3a0.camel@perches.com>
Subject: Re: [PATCH -next] perf script: remove unneeded conversion to bool
From:   Joe Perches <joe@perches.com>
To:     Zou Wei <zou_wei@huawei.com>, peterz@infradead.org,
        mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@redhat.com,
        namhyung@kernel.org
Cc:     linux-kernel@vger.kernel.org
Date:   Sun, 26 Apr 2020 13:59:36 -0700
In-Reply-To: <1587904265-865-1-git-send-email-zou_wei@huawei.com>
References: <1587904265-865-1-git-send-email-zou_wei@huawei.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.36.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 2020-04-26 at 20:31 +0800, Zou Wei wrote:
> This issue was detected by using the Coccinelle software:
> 
> tools/perf/builtin-script.c:3285:48-53: WARNING: conversion to bool not needed here
> tools/perf/builtin-script.c:2839:36-41: WARNING: conversion to bool not needed here
> 
> The conversion to bool is unneeded, remove it
[]
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
[]
> @@ -2836,7 +2836,7 @@ static int parse_output_fields(const struct option *opt __maybe_unused,
>  				break;
>  		}
>  		if (i == imax && strcmp(tok, "flags") == 0) {
> -			print_flags = change == REMOVE ? false : true;
> +			print_flags = change == REMOVE;

Read the deleted code above this again.

(you have inverted the logic)

>  			continue;
>  		}
>  		if (i == imax) {
> @@ -3282,7 +3282,7 @@ static char *get_script_path(const char *script_root, const char *suffix)
>  
>  static bool is_top_script(const char *script_path)
>  {
> -	return ends_with(script_path, "top") == NULL ? false : true;
> +	return ends_with(script_path, "top") == NULL;

and here.