Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2284694ybz; Sun, 26 Apr 2020 15:25:47 -0700 (PDT) X-Google-Smtp-Source: APiQypJFD9+pwGoFoWAlKn0U4NsWZ3QW/hUSTuWQgIs+meT/PX5O6TijT+UoD4DoA66sjtWsq613 X-Received: by 2002:a17:906:81d7:: with SMTP id e23mr15758863ejx.309.1587939947232; Sun, 26 Apr 2020 15:25:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587939947; cv=none; d=google.com; s=arc-20160816; b=iruSfjk+edFMdCwjJ7K4pMqHxvRQAsbAuXG7pK7IZaOsU/ikisXdZ9rvGgUCZYGM9I Coyiy4LY/Umz2oC0yl9V05GfIcoFbvHGyBHpuCATgAsA/53IrHAtbfXO0bQYunvwjJ0w NttagtwRdGevmuadTSWPfWoa+mFaBeJXakxilZMku7ejoD2yh6+5GUxHeQr7hZ7oHwwC 6vAyIg+DbVxfVBvTQ7JGwW+tvGAcLAFAqASv9s5K6XovTy458FfvgH3S+vl0f6EITBco aePgmO3xyFXrXDT0AiQvsoqPt7BmhN+ioRUh0PrfJAztquax8h2YPdLfJUuE3MFDH+3i qV/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=YXG+6RY5oE2qLN5BHil1gFjMctExGNr4YXCxH0kSpXU=; b=JtlieGmy7emKOCxF3biGt+Brhp9kA0r7ghLpecl/M7Joc3tYzJ19d1XCdcJ40jE6d6 spS/by6zW3CMeMgmbbrMP4rCNn+p0qufHabSMp8bwoODDaxecKlgo5iNQdA0Ua8/cjYy 3oy1EnOmCSPFz5KbEdwkR2mcfoMq3ETca7waDy6b2wRanMkg/u2Ew87d5sPaCazH1WyC 9GZWQ4m4UEUQFanuEiK8F+dpHLVGuqR2HhcEUrga4jYlloyteIdMVJ9czXzRjEjzInjp 0xlBeJI0ztDjHSrTgr2i72XJ1o4m8lhB/qmeNgFrBX9jrrAOCw1YTa+SBUC1mBcBnRfu KQvw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h7si7169585eds.336.2020.04.26.15.25.24; Sun, 26 Apr 2020 15:25:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726405AbgDZWXg (ORCPT + 99 others); Sun, 26 Apr 2020 18:23:36 -0400 Received: from mga18.intel.com ([134.134.136.126]:57089 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726199AbgDZWXf (ORCPT ); Sun, 26 Apr 2020 18:23:35 -0400 IronPort-SDR: /EeYe0Az8a6pxrdjFFSn4HxU/VVcAl/f756mT7VWsPy2UN4gu2g1UHYhqClo4iSpsH3GJop/uV dH0qQnBPkHjw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2020 15:23:35 -0700 IronPort-SDR: 8yV2Y6IG5lNoT1jn6/HH2CElcZY0fcyD0N/RoyhP0ObnAngZTUc4uRHLGC5CCH89hOtD39Sa16 WtvX0Mtzph+g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,321,1583222400"; d="scan'208";a="458601785" Received: from iweiny-desk2.sc.intel.com ([10.3.52.147]) by fmsmga006.fm.intel.com with ESMTP; 26 Apr 2020 15:23:34 -0700 Date: Sun, 26 Apr 2020 15:23:34 -0700 From: Ira Weiny To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, Andrew Morton , Dan Williams , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Chris Zankel , Max Filippov , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org Subject: Re: [PATCH 2/5] arch/kmap: Remove redundant arch specific kmaps Message-ID: <20200426222333.GA135929@iweiny-DESK2.sc.intel.com> References: <20200426055406.134198-1-ira.weiny@intel.com> <20200426055406.134198-3-ira.weiny@intel.com> <20200426071715.GA22024@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200426071715.GA22024@infradead.org> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 26, 2020 at 12:17:15AM -0700, Christoph Hellwig wrote: > On Sat, Apr 25, 2020 at 10:54:03PM -0700, ira.weiny@intel.com wrote: > > From: Ira Weiny > > > > The kmap code for all the architectures is almost 100% identical. > > > > Lift the common code to the core. Use ARCH_HAS_KMAP to indicate if an > > arch needs a special kmap. > > Can you add a kmap_flush_tlb hook that csky and mips define, and the > just entirely consolidate the code instead? Sure that seems to work. Ira