Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2434819ybz; Sun, 26 Apr 2020 19:19:22 -0700 (PDT) X-Google-Smtp-Source: APiQypLgdz72NuWhNubEHm5+eQiuKdViDxP/0WKljhtabd0sWg6WxO7G6uHv0dXUJC9OzlOI6kua X-Received: by 2002:a17:906:548:: with SMTP id k8mr17258361eja.259.1587953962393; Sun, 26 Apr 2020 19:19:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587953962; cv=none; d=google.com; s=arc-20160816; b=qsxG6fOq90tD5DFVC4T+56tOg0Bd/9aYHzbqiU/h8Iwc3lrN7eip0+eYvxYSv25w00 +eZl38W/wX7PBUJicqJfAI4iLP6EDFtlrSJ0uMiHGhIZ+Q7O1xZTlhBbuekCthfr/oqe 1i6Ltp1Krl+AFvuvesQkbfuhBptX5KiEoanphdM6b83xObEgPe1pWCVevv0A3GUasr6+ +FyKfsCsxzbJf2Cjb0MvAx93715ykxpraJb4rru32eiownIovvg89zKrOB1lx7yR8wQz drBeBQbJSeigjj2xuFn+vkQmurdEhYzM0DBM2aLaGl5i/ThD/wafIXpU1qFarwyhIiDp 57yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=UFAbsurhm9W7gQL4YaP6pKKUiutehFwwa2Yky7fbrhk=; b=l4vDcYTDFlI+bS8cocGUio/9p9oJFdoc6xW9GAcvZJnY+y0ihMcoZ+1FEiAYblUtaW 7PeNdjhUjFvD2ZT+bO8mS10lPBOC2dQh4cRUvFDGIXw3QXU3FtAb3sG3ReNDKlotgvTU sAEzQ1wacBfDOWks4ZG7D7rfXOkN7SbqD2X+TshrOBTUf/Y1SpXbiS3xgUASueKbPZ36 7fdfxAz/BcACit0FrUyqRzDIvDiV4QG5ot8iktKIHj+g15m6Ym05q2EJpmWUBo0+RDJQ zAAgzGxq+hTVc3youZTBU3LwOIWSKpu9f0GwIG+MX3Vdynl5AOyOCWcDvtVBJvxkSQzk 3o9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lc17si7837415ejb.413.2020.04.26.19.18.58; Sun, 26 Apr 2020 19:19:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726374AbgD0CRm (ORCPT + 99 others); Sun, 26 Apr 2020 22:17:42 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3307 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726234AbgD0CRm (ORCPT ); Sun, 26 Apr 2020 22:17:42 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 7F4CD604439C8E50E61F; Mon, 27 Apr 2020 10:17:40 +0800 (CST) Received: from [127.0.0.1] (10.166.213.7) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Mon, 27 Apr 2020 10:17:29 +0800 Subject: Re: [PATCH] staging: rtl8723bs: remove set but not used 'pregistrypriv' To: , , , CC: Hulk Robot References: <20200426094334.24346-1-yanaijie@huawei.com> From: Jason Yan Message-ID: Date: Mon, 27 Apr 2020 10:17:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200426094334.24346-1-yanaijie@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.166.213.7] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry, it has already been fixed by YueHaibing. Please ignore this. 在 2020/4/26 17:43, Jason Yan 写道: > Fix the following gcc warning: > > drivers/staging/rtl8723bs/hal/sdio_halinit.c:547:24: warning: variable > ‘pregistrypriv’ set but not used [-Wunused-but-set-variable] > struct registry_priv *pregistrypriv; > ^~~~~~~~~~~~~ > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan > --- > drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c > index 7853af53051d..e42d8c18e1ae 100644 > --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c > +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c > @@ -544,13 +544,9 @@ static void _InitRetryFunction(struct adapter *padapter) > > static void HalRxAggr8723BSdio(struct adapter *padapter) > { > - struct registry_priv *pregistrypriv; > u8 valueDMATimeout; > u8 valueDMAPageCount; > > - > - pregistrypriv = &padapter->registrypriv; > - > valueDMATimeout = 0x06; > valueDMAPageCount = 0x06; > >