Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Date:   Mon, 27 Apr 2020 15:21:17 +0900
To:     Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Petr Mladek <pmladek@suse.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        linux-kernel@vger.kernel.org, Dmitry Safonov <dima@arista.com>,
        Michal Hocko <mhocko@suse.com>,
        Yafang Shao <laoar.shao@gmail.com>
Subject: Re: [PATCH] printk: Add loglevel for "do not print to consoles".
Message-ID: <20200427062117.GC486@jagdpanzerIV.localdomain>
References: <20200424024239.63607-1-penguin-kernel@I-love.SAKURA.ne.jp>
 <20200425004609.GE8982@jagdpanzerIV.localdomain>
 <842ff40b-a232-6098-4333-996a3033b30a@i-love.sakura.ne.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <842ff40b-a232-6098-4333-996a3033b30a@i-love.sakura.ne.jp>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On (20/04/25 10:07), Tetsuo Handa wrote:
> On 2020/04/25 9:46, Sergey Senozhatsky wrote:
> > On (20/04/24 11:42), Tetsuo Handa wrote:
> > [..]
> >> @@ -19,6 +19,7 @@ static inline int printk_get_level(const char *buffer)
> >>  		switch (buffer[1]) {
> >>  		case '0' ... '7':
> >>  		case 'c':	/* KERN_CONT */
> >> +		case 'S':       /* KERN_NO_CONSOLES */
> >>  			return buffer[1];
> >>  		}
> >>  	}
> > 
> > So this means NO_CONSOLES_AT_ALL, slow + fast ones.
> 
> Right.
> 
> >                                                     I wonder if this
> > wants to be NO_SLOW_CONSOLES instead. Which then brings us to the
> > next question - can this be done with per-console loglevel setting?
> 
> It is difficult to define what is slow consoles. While netconsole will be
> a fast console, we can forward kernel messages via syslog daemon if desired.

Yes, there is no universal definition for "fast" and "slow" console and
I'm not suggesting to come with such a definition.

> KERN_NO_CONSOLES is for type of messages where "saved for later analysis" is
> important but "printed for immediate notification" is not important.
> In other words, KERN_NO_CONSOLES is NOT for dying messages where "printed for
> immediate notification" is important.

per-console loglevel is a user configurable parameter.
KERN_NO_CONSOLES is a hard-coded policy.

	-ss