Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2568522ybz; Sun, 26 Apr 2020 23:25:48 -0700 (PDT) X-Google-Smtp-Source: APiQypKRvMvj2j2kA0jn0+uRz3bEdqAFi0Vz7JoDtKyhMOsEQH7Cwanpc4/YhvPLAJsVqmX39mor X-Received: by 2002:a17:907:11de:: with SMTP id va30mr18549820ejb.121.1587968748792; Sun, 26 Apr 2020 23:25:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587968748; cv=none; d=google.com; s=arc-20160816; b=gyz/Vw4vRJkUNWWMpdtMuKCr88RMESkXpUYsDLDg+EQYg0qwn53DYyK6BfBujddCBy 1niFfMHxXuBZmG2Vjw2fRNwlR5VmJIZ/aUIbvwFFbq2cjtlSyDFgEpWVtWOS0PXGHwF1 HRT3UT4YHGYoQngoaRlNDjIwx9Mi3Bvd3aiixOj6h9SZdLncVjdmlqQGkMkjMosryQIR v9mtkYNCQdozlphQ6xJT5OU6Zd3KmmqMtpZZrroKqF2svKz061uXEuYGZwRgyvZZBYPX 7SVJv0AZzoiQbgDM+nNd5OwsbFXY5g9hsc3d+ayxcEx3V8VGYtDHsfu2ycu5DtpVkcRR 8pmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=kUJ2IOIfZxc2gfoEAE1R4dapVEqh0mafu/Wcnar+8RI=; b=AW+QNqAYeO1315YdD8sgc27o9Sqr3/a66PuHo2/3wibv/by8cJjYhiMB+zhmjBXuyR v0+FlDawJGHqXlceigUupgciH6TY3BlIQeu65vhHmA4TMrYIoyzGm8KCazsDm/+2xKqh X6kxpqAItZkYbg763coHyMrqSd5qAVwiODuo0NewOTcFscqgCNv6n0LZb7zUC8Rr1amD AmiW3kqvZA5izHw2p0kCrdQEyyJi/+hJqM7eu1iuUSEZvu4WNTlo1ZeWnrTKbyh8f+ax HLIe5c0NzSF8uCy88c3FoxvYsB4nkxELDCWrtfLTLTaaHuutkTtt7lytgWlAoAWWs+d4 kkQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u5si8095801edx.196.2020.04.26.23.25.24; Sun, 26 Apr 2020 23:25:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726611AbgD0GWJ (ORCPT + 99 others); Mon, 27 Apr 2020 02:22:09 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:46296 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726231AbgD0GWI (ORCPT ); Mon, 27 Apr 2020 02:22:08 -0400 Received: by mail-io1-f67.google.com with SMTP id i3so17552717ioo.13; Sun, 26 Apr 2020 23:22:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kUJ2IOIfZxc2gfoEAE1R4dapVEqh0mafu/Wcnar+8RI=; b=o8NQdbkM103DitvkcE3nC2m03MpA/MxYycaNUGuqokiAmc71tXX+y4yL8pn9BuHt6z Ph4axFmEUTl6doanBv0MKCGBE0Mvnx3htIdJoFgalnMTmjUb6sneJGg67A2sw+UndD4O Xinl34k1uVXHHe9iOFurmpcQF4B07wtPZOa8OQmTGKPxHLfzi6JRSwa4iPdLVM39A/fn ZlkahTnRgXJhjY5fGF5n04zslFioqMhT/lv3cvG0S2hNTWFt3vx3EPrv0jImoQjG1s54 gjfBYHtqdg9gjW6/xWboHjNoftt6IjgyWzvappNU52cyuMbYYAvlrmp9iwtFXvDL476x uv5Q== X-Gm-Message-State: AGi0PuZhUMgbw2TdRJ0ipb5Z8ykR+Sb+8iDVC6vq+D+/Q+xP8ChJNhol U7ifJ8Fm1TA2RnlaP+GpB5j4hDFOv5hUjOfpKKE= X-Received: by 2002:a6b:5109:: with SMTP id f9mr19693167iob.125.1587968526932; Sun, 26 Apr 2020 23:22:06 -0700 (PDT) MIME-Version: 1.0 References: <20200427060551.1372591-1-jiaxun.yang@flygoat.com> <20200427060551.1372591-3-jiaxun.yang@flygoat.com> In-Reply-To: <20200427060551.1372591-3-jiaxun.yang@flygoat.com> From: Huacai Chen Date: Mon, 27 Apr 2020 14:29:34 +0800 Message-ID: Subject: Re: [PATCH v6 2/5] PCI: Add Loongson PCI Controller support To: Jiaxun Yang Cc: "open list:MIPS" , Bjorn Helgaas , Rob Herring , Thomas Bogendoerfer , Lorenzo Pieralisi , Paul Burton , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Jiaxun, On Mon, Apr 27, 2020 at 2:06 PM Jiaxun Yang wrote: > > This controller can be found on Loongson-2K SoC, Loongson-3 > systems with RS780E/LS7A PCH. > > The RS780E part of code was previously located at > arch/mips/pci/ops-loongson3.c and now it can use generic PCI > driver implementation. > > Signed-off-by: Jiaxun Yang > > -- > v2: > - Clean up according to rob's suggestions > - Claim that it can't work as a module > v3: > - Fix a typo > v4: > - More clean-ups: Drop flag check, use devfn > --- > drivers/pci/controller/Kconfig | 10 + > drivers/pci/controller/Makefile | 1 + > drivers/pci/controller/pci-loongson.c | 251 ++++++++++++++++++++++++++ > 3 files changed, 262 insertions(+) > create mode 100644 drivers/pci/controller/pci-loongson.c > > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig > index 91bfdb784829..ae36edb1d7db 100644 > --- a/drivers/pci/controller/Kconfig > +++ b/drivers/pci/controller/Kconfig > @@ -258,6 +258,16 @@ config PCI_HYPERV_INTERFACE > The Hyper-V PCI Interface is a helper driver allows other drivers to > have a common interface with the Hyper-V PCI frontend driver. > > +config PCI_LOONGSON > + bool "LOONGSON PCI Controller" > + depends on MACH_LOONGSON64 || COMPILE_TEST > + depends on OF > + depends on PCI_QUIRKS > + default MACH_LOONGSON64 > + help > + Say Y here if you want to enable PCI controller support on > + Loongson systems. > + > source "drivers/pci/controller/dwc/Kconfig" > source "drivers/pci/controller/mobiveil/Kconfig" > source "drivers/pci/controller/cadence/Kconfig" > diff --git a/drivers/pci/controller/Makefile b/drivers/pci/controller/Makefile > index 158c59771824..fbac4b0190a0 100644 > --- a/drivers/pci/controller/Makefile > +++ b/drivers/pci/controller/Makefile > @@ -28,6 +28,7 @@ obj-$(CONFIG_PCIE_MEDIATEK) += pcie-mediatek.o > obj-$(CONFIG_PCIE_TANGO_SMP8759) += pcie-tango.o > obj-$(CONFIG_VMD) += vmd.o > obj-$(CONFIG_PCIE_BRCMSTB) += pcie-brcmstb.o > +obj-$(CONFIG_PCI_LOONGSON) += pci-loongson.o > # pcie-hisi.o quirks are needed even without CONFIG_PCIE_DW > obj-y += dwc/ > obj-y += mobiveil/ > diff --git a/drivers/pci/controller/pci-loongson.c b/drivers/pci/controller/pci-loongson.c > new file mode 100644 > index 000000000000..6cb8de384d36 > --- /dev/null > +++ b/drivers/pci/controller/pci-loongson.c > @@ -0,0 +1,251 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Loongson PCI Host Controller Driver > + * > + * Copyright (C) 2020 Jiaxun Yang > + */ > + > +#include > +#include > +#include > +#include > + > +#include "../pci.h" > + > +/* Device IDs */ > +#define DEV_PCIE_PORT_0 0x7a09 > +#define DEV_PCIE_PORT_1 0x7a19 > +#define DEV_PCIE_PORT_2 0x7a29 > + > +#define DEV_LS2K_APB 0x7a02 > +#define DEV_LS7A_CONF 0x7a10 > +#define DEV_LS7A_LPC 0x7a0c > + > +#define FLAG_CFG0 BIT(0) > +#define FLAG_CFG1 BIT(1) > +#define FLAG_DEV_FIX BIT(2) > + > +struct loongson_pci { > + void __iomem *cfg0_base; > + void __iomem *cfg1_base; > + struct platform_device *pdev; > + u32 flags; > +}; > + > +/* Fixup wrong class code in PCIe bridges */ > +static void bridge_class_quirk(struct pci_dev *dev) > +{ > + dev->class = PCI_CLASS_BRIDGE_PCI << 8; > +} > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LOONGSON, > + DEV_PCIE_PORT_0, bridge_class_quirk); > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LOONGSON, > + DEV_PCIE_PORT_1, bridge_class_quirk); > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LOONGSON, > + DEV_PCIE_PORT_2, bridge_class_quirk); > + > +static void system_bus_quirk(struct pci_dev *pdev) > +{ > + u16 tmp; > + > + pdev->mmio_always_on = 1; > + pdev->non_compliant_bars = 1; > + /* Enable MEM & IO Decoding */ > + pci_read_config_word(pdev, PCI_STATUS, &tmp); > + tmp |= PCI_COMMAND_IO | PCI_COMMAND_MEMORY; > + pci_write_config_word(pdev, PCI_STATUS, tmp); > +} > + > +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_LOONGSON, > + DEV_LS2K_APB, system_bus_quirk); > +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_LOONGSON, > + DEV_LS7A_CONF, system_bus_quirk); > +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_LOONGSON, > + DEV_LS7A_LPC, system_bus_quirk); > + > +static void loongson_mrrs_quirk(struct pci_dev *dev) > +{ > + struct pci_bus *bus = dev->bus; > + struct pci_dev *bridge; > + static const struct pci_device_id bridge_devids[] = { > + { PCI_VDEVICE(LOONGSON, DEV_PCIE_PORT_0) }, > + { PCI_VDEVICE(LOONGSON, DEV_PCIE_PORT_1) }, > + { PCI_VDEVICE(LOONGSON, DEV_PCIE_PORT_2) }, > + { 0, }, > + }; > + > + > + /* look for the matching bridge */ > + while (!pci_is_root_bus(bus)) { > + bridge = bus->self; > + bus = bus->parent; > + /* > + * Some Loongson PCIE ports has a h/w limitation of > + * 256 bytes maximum read request size. It can't handle > + * anything higher than this. So force this limit on > + * any devices attached under these ports. > + */ > + if (pci_match_id(bridge_devids, bridge)) { > + if (pcie_get_readrq(dev) > 256) { > + dev_info(&dev->dev, "limiting MRRS to 256\n"); > + pcie_set_readrq(dev, 256); > + } > + break; > + } > + } > +} > +DECLARE_PCI_FIXUP_ENABLE(PCI_ANY_ID, PCI_ANY_ID, loongson_mrrs_quirk); > + > +static void __iomem *cfg1_map(struct loongson_pci *priv, int bus, > + unsigned int devfn, int where) > +{ > + unsigned long addroff = 0x0; > + > + if (bus != 0) > + addroff |= BIT(28); /* Type 1 Access */ > + addroff |= (where & 0xff) | ((where & 0xf00) << 16); > + addroff |= (bus << 16) | (devfn << 8); > + return priv->cfg1_base + addroff; > +} > + > +static void __iomem *cfg0_map(struct loongson_pci *priv, int bus, > + unsigned int devfn, int where) > +{ > + unsigned long addroff = 0x0; > + > + if (bus != 0) > + addroff |= BIT(24); /* Type 1 Access */ > + addroff |= (bus << 16) | (devfn << 8) | where; > + return priv->cfg0_base + addroff; > +} > + > +void __iomem *pci_loongson_map_bus(struct pci_bus *bus, unsigned int devfn, > + int where) > +{ > + unsigned char busnum = bus->number; > + struct pci_host_bridge *bridge = pci_find_host_bridge(bus); > + struct loongson_pci *priv = pci_host_bridge_priv(bridge); > + > + /* > + * Do not read more than one device on the bus other than > + * the host bridge. > + */ > + if (bus->primary != 0 && PCI_SLOT(devfn) > 0 && > + priv->flags & FLAG_DEV_FIX) > + return NULL; > + > + /* CFG0 can only access standard space */ > + if (where < PCI_CFG_SPACE_SIZE && priv->cfg0_base) > + return cfg0_map(priv, busnum, devfn, where); > + > + /* CFG1 can access extended space */ > + if (where < PCI_CFG_SPACE_EXP_SIZE && priv->cfg1_base) > + return cfg1_map(priv, busnum, devfn, where); > + > + return NULL; > +} > + > +static int loongson_map_irq(const struct pci_dev *dev, u8 slot, u8 pin) > +{ > + int irq; > + u8 val; > + > + irq = of_irq_parse_and_map_pci(dev, slot, pin); > + if (irq > 0) > + return irq; > + > + /* Care i8259 legacy systems */ > + pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &val); > + /* i8259 only have 15 IRQs */ > + if (val > 15) > + return 0; > + > + return val; > +} > + > +/* H/w only accept 32-bit PCI operations */ > +static struct pci_ops loongson_pci_ops = { > + .map_bus = pci_loongson_map_bus, > + .read = pci_generic_config_read32, > + .write = pci_generic_config_write32, > +}; > + > +static const struct of_device_id loongson_pci_of_match[] = { > + { .compatible = "loongson,rs780e-pci", > + .data = (void *)(FLAG_CFG0), }, > + { .compatible = "loongson,ls2k-pci", > + .data = (void *)(FLAG_CFG0 | FLAG_CFG1 | FLAG_DEV_FIX), }, > + { .compatible = "loongson,ls7a-pci", > + .data = (void *)(FLAG_CFG0 | FLAG_CFG1 | FLAG_DEV_FIX), }, I suggest to use alpha-betical order here: ls2k, ls7a and rs780 at last. > + {} > +}; > + > +static int loongson_pci_probe(struct platform_device *pdev) > +{ > + struct loongson_pci *priv; > + struct device *dev = &pdev->dev; > + struct device_node *node = dev->of_node; > + struct pci_host_bridge *bridge; > + struct resource *regs; > + int err; > + > + if (!node) > + return -ENODEV; > + > + bridge = devm_pci_alloc_host_bridge(dev, sizeof(*priv)); > + if (!bridge) > + return -ENODEV; > + > + priv = pci_host_bridge_priv(bridge); > + priv->pdev = pdev; > + priv->flags = (unsigned long)of_device_get_match_data(dev); > + > + regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!regs) { > + dev_err(dev, "missing mem resources for cfg0\n"); > + return -EINVAL; > + } > + > + priv->cfg0_base = devm_pci_remap_cfg_resource(dev, regs); > + if (IS_ERR(priv->cfg0_base)) > + return PTR_ERR(priv->cfg0_base); > + > + /* CFG1 is optional */ > + if (priv->flags & FLAG_CFG1) { > + regs = platform_get_resource(pdev, IORESOURCE_MEM, 1); > + if (!regs) > + dev_info(dev, "missing mem resource for cfg1\n"); > + else { > + priv->cfg1_base = devm_pci_remap_cfg_resource(dev, regs); > + if (IS_ERR(priv->cfg1_base)) > + priv->cfg1_base = NULL; > + } > + } > + > + err = pci_parse_request_of_pci_ranges(dev, &bridge->windows, > + &bridge->dma_ranges, NULL); > + if (err) { > + dev_err(dev, "Failed to get bridge resources\n"); > + return err; > + } > + > + bridge->dev.parent = dev; > + bridge->sysdata = priv; > + bridge->ops = &loongson_pci_ops; > + bridge->map_irq = loongson_map_irq; > + > + err = pci_host_probe(bridge); > + if (err) > + return err; > + > + return 0; > +} > + > +static struct platform_driver loongson_pci_driver = { > + .driver = { > + .name = "loongson-pci", > + .of_match_table = loongson_pci_of_match, > + }, > + .probe = loongson_pci_probe, > +}; > +builtin_platform_driver(loongson_pci_driver); > -- > 2.26.0.rc2 > Thanks, Huacai